From: kernel test robot <lkp@intel.com>
To: Saurabh Sengar <ssengar@linux.microsoft.com>,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, mikelley@microsoft.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 1/5] uio: Add hv_vmbus_client driver
Date: Sun, 4 Jun 2023 10:05:10 +0800 [thread overview]
Message-ID: <202306040910.13oLufQd-lkp@intel.com> (raw)
In-Reply-To: <1685692629-31351-2-git-send-email-ssengar@linux.microsoft.com>
Hi Saurabh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.4-rc4 next-20230602]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Saurabh-Sengar/uio-Add-hv_vmbus_client-driver/20230602-160029
base: char-misc/char-misc-testing
patch link: https://lore.kernel.org/r/1685692629-31351-2-git-send-email-ssengar%40linux.microsoft.com
patch subject: [PATCH 1/5] uio: Add hv_vmbus_client driver
config: i386-randconfig-c001-20230604 (https://download.01.org/0day-ci/archive/20230604/202306040910.13oLufQd-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306040910.13oLufQd-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/uio/uio_hv_vmbus_client.c:195:1-6: WARNING: invalid free of devm_ allocated data
vim +195 drivers/uio/uio_hv_vmbus_client.c
158
159 static int uio_hv_vmbus_probe(struct hv_device *dev, const struct hv_vmbus_device_id *dev_id)
160 {
161 struct uio_hv_vmbus_dev *pdata;
162 int ret = 0;
163 char *name = NULL;
164
165 pdata = devm_kzalloc(&dev->device, sizeof(*pdata), GFP_KERNEL);
166 if (!pdata)
167 return -ENOMEM;
168
169 name = kasprintf(GFP_KERNEL, "%pUl", &dev->dev_instance);
170
171 /* Fill general uio info */
172 pdata->info.name = name; /* /sys/class/uio/uioX/name */
173 pdata->info.version = DRIVER_VERSION;
174 pdata->info.irqcontrol = uio_hv_vmbus_irqcontrol;
175 pdata->info.open = uio_hv_vmbus_open;
176 pdata->info.release = uio_hv_vmbus_release;
177 pdata->info.irq = UIO_IRQ_CUSTOM;
178 pdata->info.priv = pdata;
179 pdata->device = dev;
180
181 ret = uio_register_device(&dev->device, &pdata->info);
182 if (ret) {
183 dev_err(&dev->device, "uio_hv_vmbus register failed\n");
184 goto fail;
185 }
186
187 ret = sysfs_create_file(&dev->device.kobj, &dev_attr_ring_size.attr);
188 if (ret)
189 dev_notice(&dev->device, "sysfs create ring size file failed; %d\n", ret);
190
191 hv_set_drvdata(dev, pdata);
192 return 0;
193
194 fail:
> 195 kfree(pdata);
196 return ret;
197 }
198
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-06-04 2:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 7:57 [PATCH 0/5] UIO driver for low speed Hyper-V devices Saurabh Sengar
2023-06-02 7:57 ` [PATCH 1/5] uio: Add hv_vmbus_client driver Saurabh Sengar
2023-06-04 2:05 ` kernel test robot [this message]
2023-06-04 7:09 ` Greg KH
2023-06-05 3:00 ` [EXTERNAL] " Saurabh Singh Sengar
2023-06-02 7:57 ` [PATCH 2/5] tools: hv: Add vmbus_bufring Saurabh Sengar
2023-06-02 7:57 ` [PATCH 3/5] tools: hv: Add new fcopy application based on uio driver Saurabh Sengar
2023-06-02 7:57 ` [PATCH 4/5] tools: hv: Remove hv_fcopy_daemon Saurabh Sengar
2023-06-02 7:57 ` [PATCH 5/5] Drivers: hv: Remove fcopy driver Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306040910.13oLufQd-lkp@intel.com \
--to=lkp@intel.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.