All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: James Seo <james@equiv.tech>
Cc: Jonathan Corbet <corbet@lwn.net>, Kalle Valo <kvalo@kernel.org>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] docs: process: Send patches 'To' maintainers and 'Cc' lists
Date: Sun, 4 Jun 2023 11:33:49 -0700	[thread overview]
Message-ID: <20230604113349.495f8e79@kernel.org> (raw)
In-Reply-To: <20230603151447.29288-1-james@equiv.tech>

On Sat,  3 Jun 2023 08:14:47 -0700 James Seo wrote:
> +You should always notify the appropriate subsystem maintainer(s) and list(s)

s/notify/specify as recipients/ ?
notify sounds like an out of band ping, maybe just to me.

> +about any patch to code that they maintain.  Identify them by looking through
> +the MAINTAINERS file and the source code revision history, and by using the
> +script scripts/get_maintainer.pl (pass paths to your patches as arguments to
> +scripts/get_maintainer.pl).  Send your patch e-mail "To:" those maintainers and
> +"Cc:" those lists.

There's a handful of people who run get_maintainer on the file paths,

 ./scripts/get_maintainer.pl net/core/dev.c
rather than
 ./scripts/get_maintainer.pl 0001-my.patch

This leads to ignoring Fixes tags, and authors of fixed commits should
really be CCed.

Since we're touching this paragraph maybe we can massage the wording 
a bit:

(pass paths to your patches generated by git format-patch as arguments
to scripts/get_maintainer.pl)

> +If you cannot find a maintainer for the subsystem you are working on, Andrew
> +Morton (akpm@linux-foundation.org) serves as a maintainer of last resort.  Also,

Thanks for the patch, btw, we also see To-less patches a couple times 
a month on netdev@ :(

      parent reply	other threads:[~2023-06-04 18:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-03 15:14 [RFC] docs: process: Send patches 'To' maintainers and 'Cc' lists James Seo
2023-06-03 15:55 ` Randy Dunlap
2023-06-03 16:06   ` Willy Tarreau
2023-06-04 18:26     ` Jakub Kicinski
2023-06-05  4:12       ` Laurent Pinchart
2023-06-05 13:22         ` Kalle Valo
2023-06-05 17:30           ` Jakub Kicinski
2023-06-06 13:46             ` Kalle Valo
2023-06-04 13:56   ` Bagas Sanjaya
2023-06-04 14:01 ` Bagas Sanjaya
2023-06-04 21:53   ` Randy Dunlap
2023-06-04 18:33 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230604113349.495f8e79@kernel.org \
    --to=kuba@kernel.org \
    --cc=corbet@lwn.net \
    --cc=james@equiv.tech \
    --cc=kvalo@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.