Re: [PATCH RESEND bpf-next 01/18] bpf: introduce BPF token object

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230602150011.1657856-2-andrii@kernel.org>
References: <20230602150011.1657856-2-andrii@kernel.org>
TO: Andrii Nakryiko <andrii@kernel.org>
TO: bpf@vger.kernel.org
CC: linux-security-module@vger.kernel.org
CC: keescook@chromium.org
CC: brauner@kernel.org
CC: lennart@poettering.net
CC: cyphar@cyphar.com
CC: luto@kernel.org

Hi Andrii,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/bpf-introduce-BPF-token-object/20230602-230448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230602150011.1657856-2-andrii%40kernel.org
patch subject: [PATCH RESEND bpf-next 01/18] bpf: introduce BPF token object
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: openrisc-randconfig-c031-20230604 (https://download.01.org/0day-ci/archive/20230604/202306041344.sIqXOEJL-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202306041344.sIqXOEJL-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> kernel/bpf/token.c:30:6-27: WARNING: atomic_dec_and_test variation before object free at line 34.

vim +30 kernel/bpf/token.c

59e6ef2000a056 Andrii Nakryiko 2023-06-02  24  
59e6ef2000a056 Andrii Nakryiko 2023-06-02  25  void bpf_token_put(struct bpf_token *token)
59e6ef2000a056 Andrii Nakryiko 2023-06-02  26  {
59e6ef2000a056 Andrii Nakryiko 2023-06-02  27  	if (!token)
59e6ef2000a056 Andrii Nakryiko 2023-06-02  28  		return;
59e6ef2000a056 Andrii Nakryiko 2023-06-02  29  
59e6ef2000a056 Andrii Nakryiko 2023-06-02 @30  	if (!atomic64_dec_and_test(&token->refcnt))
59e6ef2000a056 Andrii Nakryiko 2023-06-02  31  		return;
59e6ef2000a056 Andrii Nakryiko 2023-06-02  32  
59e6ef2000a056 Andrii Nakryiko 2023-06-02  33  	INIT_WORK(&token->work, bpf_token_put_deferred);
59e6ef2000a056 Andrii Nakryiko 2023-06-02 @34  	schedule_work(&token->work);
59e6ef2000a056 Andrii Nakryiko 2023-06-02  35  }
59e6ef2000a056 Andrii Nakryiko 2023-06-02  36  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki