All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: yishaih@nvidia.com, virtualization@lists.linux-foundation.org,
	stefanha@redhat.com, bodong@nvidia.com, oren@nvidia.com
Subject: Re: [PATCH 1/1] virtio: move pci drivers files to a directory
Date: Sun, 4 Jun 2023 18:21:57 -0400	[thread overview]
Message-ID: <20230604181927-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230515171338.8227-1-mgurtovoy@nvidia.com>

On Mon, May 15, 2023 at 08:13:38PM +0300, Max Gurtovoy wrote:
> The PCI transport drivers have many files under virtio directory. Move
> them to a dedicated directory to ease on the subsystem maintenance.
> 
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>

The benefit here seems marginal, they all have
virtio_pci prefix, pci/virtio_pci_ just seems redundant. OTOH I
could see a benefit to have transports, core, and a bunch of
misc devices in 3 separate directories.

> ---
>  drivers/virtio/Makefile                          | 7 ++-----
>  drivers/virtio/pci/Makefile                      | 7 +++++++
>  drivers/virtio/{ => pci}/virtio_pci_common.c     | 0
>  drivers/virtio/{ => pci}/virtio_pci_common.h     | 0
>  drivers/virtio/{ => pci}/virtio_pci_legacy.c     | 0
>  drivers/virtio/{ => pci}/virtio_pci_legacy_dev.c | 0
>  drivers/virtio/{ => pci}/virtio_pci_modern.c     | 0
>  drivers/virtio/{ => pci}/virtio_pci_modern_dev.c | 0
>  8 files changed, 9 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/virtio/pci/Makefile
>  rename drivers/virtio/{ => pci}/virtio_pci_common.c (100%)
>  rename drivers/virtio/{ => pci}/virtio_pci_common.h (100%)
>  rename drivers/virtio/{ => pci}/virtio_pci_legacy.c (100%)
>  rename drivers/virtio/{ => pci}/virtio_pci_legacy_dev.c (100%)
>  rename drivers/virtio/{ => pci}/virtio_pci_modern.c (100%)
>  rename drivers/virtio/{ => pci}/virtio_pci_modern_dev.c (100%)
> 
> diff --git a/drivers/virtio/Makefile b/drivers/virtio/Makefile
> index 8e98d24917cc..8c39c0594cea 100644
> --- a/drivers/virtio/Makefile
> +++ b/drivers/virtio/Makefile
> @@ -1,14 +1,11 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_VIRTIO) += virtio.o virtio_ring.o
>  obj-$(CONFIG_VIRTIO_ANCHOR) += virtio_anchor.o
> -obj-$(CONFIG_VIRTIO_PCI_LIB) += virtio_pci_modern_dev.o
> -obj-$(CONFIG_VIRTIO_PCI_LIB_LEGACY) += virtio_pci_legacy_dev.o
>  obj-$(CONFIG_VIRTIO_MMIO) += virtio_mmio.o
> -obj-$(CONFIG_VIRTIO_PCI) += virtio_pci.o
> -virtio_pci-y := virtio_pci_modern.o virtio_pci_common.o
> -virtio_pci-$(CONFIG_VIRTIO_PCI_LEGACY) += virtio_pci_legacy.o
>  obj-$(CONFIG_VIRTIO_BALLOON) += virtio_balloon.o
>  obj-$(CONFIG_VIRTIO_INPUT) += virtio_input.o
>  obj-$(CONFIG_VIRTIO_VDPA) += virtio_vdpa.o
>  obj-$(CONFIG_VIRTIO_MEM) += virtio_mem.o
>  obj-$(CONFIG_VIRTIO_DMA_SHARED_BUFFER) += virtio_dma_buf.o
> +
> +obj-$(CONFIG_VIRTIO_PCI)		+= pci/
> diff --git a/drivers/virtio/pci/Makefile b/drivers/virtio/pci/Makefile
> new file mode 100644
> index 000000000000..673c7532430a
> --- /dev/null
> +++ b/drivers/virtio/pci/Makefile
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +obj-$(CONFIG_VIRTIO_PCI) += virtio_pci.o
> +obj-$(CONFIG_VIRTIO_PCI_LIB) += virtio_pci_modern_dev.o
> +obj-$(CONFIG_VIRTIO_PCI_LIB_LEGACY) += virtio_pci_legacy_dev.o
> +
> +virtio_pci-y := virtio_pci_modern.o virtio_pci_common.o
> +virtio_pci-$(CONFIG_VIRTIO_PCI_LEGACY) += virtio_pci_legacy.o
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/pci/virtio_pci_common.c
> similarity index 100%
> rename from drivers/virtio/virtio_pci_common.c
> rename to drivers/virtio/pci/virtio_pci_common.c
> diff --git a/drivers/virtio/virtio_pci_common.h b/drivers/virtio/pci/virtio_pci_common.h
> similarity index 100%
> rename from drivers/virtio/virtio_pci_common.h
> rename to drivers/virtio/pci/virtio_pci_common.h
> diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/pci/virtio_pci_legacy.c
> similarity index 100%
> rename from drivers/virtio/virtio_pci_legacy.c
> rename to drivers/virtio/pci/virtio_pci_legacy.c
> diff --git a/drivers/virtio/virtio_pci_legacy_dev.c b/drivers/virtio/pci/virtio_pci_legacy_dev.c
> similarity index 100%
> rename from drivers/virtio/virtio_pci_legacy_dev.c
> rename to drivers/virtio/pci/virtio_pci_legacy_dev.c
> diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/pci/virtio_pci_modern.c
> similarity index 100%
> rename from drivers/virtio/virtio_pci_modern.c
> rename to drivers/virtio/pci/virtio_pci_modern.c
> diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/pci/virtio_pci_modern_dev.c
> similarity index 100%
> rename from drivers/virtio/virtio_pci_modern_dev.c
> rename to drivers/virtio/pci/virtio_pci_modern_dev.c
> -- 
> 2.18.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

           reply	other threads:[~2023-06-04 22:22 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20230515171338.8227-1-mgurtovoy@nvidia.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230604181927-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=bodong@nvidia.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=oren@nvidia.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.