From: Christoph Hellwig <hch@lst.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
Qu Wenruo <wqu@suse.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [linux-next:master 6080/6849] fs/btrfs/volumes.c:6412 btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6250)
Date: Mon, 5 Jun 2023 09:09:05 +0200 [thread overview]
Message-ID: <20230605070905.GC15651@lst.de> (raw)
In-Reply-To: <14e5f928-5395-4cc4-90ff-8223ef857320@kadam.mountain>
On Fri, Jun 02, 2023 at 05:04:37PM +0300, Dan Carpenter wrote:
> Hi Christoph,
>
> This is just a rename function so the warning is older but I didn't
> send this email before.
Yeah. The old version is my fault as well :)
It is not a bug as all callers that set smap pass in the mirror_num_ret
as well, but it definitively isn't very maintainable code. I see what
I can do.
next prev parent reply other threads:[~2023-06-05 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 14:04 [linux-next:master 6080/6849] fs/btrfs/volumes.c:6412 btrfs_map_block() error: we previously assumed 'mirror_num_ret' could be null (see line 6250) Dan Carpenter
2023-06-05 7:09 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-02 13:51 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605070905.GC15651@lst.de \
--to=hch@lst.de \
--cc=dan.carpenter@linaro.org \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.