From: "Michael S. Tsirkin" <mst@redhat.com>
To: 赵盛 <sheng.zhao@bytedance.com>
Cc: Yongji Xie <xieyongji@bytedance.com>,
Xianjun Zeng <zengxianjun@bytedance.com>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] vduse: avoid empty string for dev name
Date: Mon, 5 Jun 2023 09:23:49 -0400 [thread overview]
Message-ID: <20230605092326-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CA+nqC_FVJS2Fv98ztY=Szbv7KhqZQ1bQxc-6E909u3z1zub9zA@mail.gmail.com>
On Mon, Jun 05, 2023 at 06:17:55AM -0700, 赵盛 wrote:
> Hi Yongji,
> Thanks for your feedback, I'll resubmit the patch with this change.
Just send a Fixes tag in a reply no need to resubmit - I queued it
already.
> Sheng
> From: "Yongji Xie"<xieyongji@bytedance.com>
> Date: Thu, Jun 1, 2023, 11:31
> Subject: Re: [PATCH] vduse: avoid empty string for dev name
> To: "Sheng Zhao"<sheng.zhao@bytedance.com>
> Cc: "Michael S. Tsirkin"<mst@redhat.com>, "Jason Wang"<jasowang@redhat.com>,
> "virtualization"<virtualization@lists.linux-foundation.org>, "Xianjun Zeng"<
> zengxianjun@bytedance.com>
> On Tue, May 30, 2023 at 11:37 AM Sheng Zhao <sheng.zhao@bytedance.com> wrote:
> >
> > Syzkaller hits a kernel WARN when the first character of the dev name
> > provided is NULL. Solution is to add a NULL check before calling
> > cdev_device_add() in vduse_create_dev().
> >
> > kobject: (0000000072042169): attempted to be registered with empty name!
> > WARNING: CPU: 0 PID: 112695 at lib/kobject.c:236
> > Call Trace:
> > kobject_add_varg linux/src/lib/kobject.c:390 [inline]
> > kobject_add+0xf6/0x150 linux/src/lib/kobject.c:442
> > device_add+0x28f/0xc20 linux/src/drivers/base/core.c:2167
> > cdev_device_add+0x83/0xc0 linux/src/fs/char_dev.c:546
> > vduse_create_dev linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2254 [inline]
> > vduse_ioctl+0x7b5/0xf30 linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2316
> > vfs_ioctl linux/src/fs/ioctl.c:47 [inline]
> > file_ioctl linux/src/fs/ioctl.c:510 [inline]
> > do_vfs_ioctl+0x14b/0xa80 linux/src/fs/ioctl.c:697
> > ksys_ioctl+0x7c/0xa0 linux/src/fs/ioctl.c:714
> > __do_sys_ioctl linux/src/fs/ioctl.c:721 [inline]
> > __se_sys_ioctl linux/src/fs/ioctl.c:719 [inline]
> > __x64_sys_ioctl+0x42/0x50 linux/src/fs/ioctl.c:719
> > do_syscall_64+0x94/0x330 linux/src/arch/x86/entry/common.c:291
> > entry_SYSCALL_64_after_hwframe+0x44/0xa9
> >
> > Reported-by: Xianjun Zeng <zengxianjun@bytedance.com>
> > Signed-off-by: Sheng Zhao <sheng.zhao@bytedance.com>
>
> Miss a "Fixes" tag. Others look good to me.
>
> Reviewed-by: Xie Yongji <xieyongji@bytedance.com>
>
> Thanks,
> Yongji
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-06-05 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230530033626.1266794-1-sheng.zhao@bytedance.com>
2023-05-31 1:51 ` [PATCH] vduse: avoid empty string for dev name Jason Wang
[not found] ` <CACycT3sPTZLho19ZRKPmcTmvRYh4NW9QBT6z=dkq1U_Acd2o6g@mail.gmail.com>
[not found] ` <CA+nqC_FVJS2Fv98ztY=Szbv7KhqZQ1bQxc-6E909u3z1zub9zA@mail.gmail.com>
2023-06-05 13:23 ` Michael S. Tsirkin [this message]
[not found] ` <CA+nqC_E44t30v8Kjrx3A36kcyEcAesnEHoP7Q_XJbn129wOT1A@mail.gmail.com>
2023-06-05 14:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605092326-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=sheng.zhao@bytedance.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
--cc=zengxianjun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.