From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com
Subject: Re: [PATCH net-next] ethtool: ioctl: improve error checking for set_wol
Date: Mon, 5 Jun 2023 11:21:38 -0700 [thread overview]
Message-ID: <20230605112138.7fb4b963@kernel.org> (raw)
In-Reply-To: <1685566429-2869-1-git-send-email-justin.chen@broadcom.com>
On Wed, 31 May 2023 13:53:49 -0700 Justin Chen wrote:
> The netlink version of set_wol checks for not supported wolopts and avoids
> setting wol when the correct wolopt is already set. If we do the same with
> the ioctl version then we can remove these checks from the driver layer.
>
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
If I understand the discussion correctly the patch is ready to be
applied. Could you repost it? It has been marked as "changes requested"
in patchwork, I'm not 100% sure about the reason.
next prev parent reply other threads:[~2023-06-05 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 20:53 [PATCH net-next] ethtool: ioctl: improve error checking for set_wol Justin Chen
2023-06-01 15:55 ` Simon Horman
2023-06-01 16:03 ` Jakub Kicinski
2023-06-01 16:23 ` Simon Horman
2023-06-01 16:23 ` Justin Chen
2023-06-01 16:22 ` Justin Chen
2023-06-01 18:27 ` Justin Chen
2023-06-01 18:37 ` Florian Fainelli
2023-06-01 18:48 ` Andrew Lunn
2023-06-01 18:58 ` Justin Chen
2023-06-01 20:41 ` Woojung.Huh
2023-06-02 8:54 ` Simon Horman
2023-06-05 18:21 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-05 18:46 Justin Chen
2023-06-07 3:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605112138.7fb4b963@kernel.org \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.