From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
brett.creeley@amd.com, drivers@pensando.io,
Nitya Sunkad <nitya.sunkad@amd.com>
Subject: Re: [PATCH net-next] ionic: add support for ethtool extended stat link_down_count
Date: Mon, 5 Jun 2023 12:05:05 -0700 [thread overview]
Message-ID: <20230605120505.71f518ae@kernel.org> (raw)
In-Reply-To: <be5f26b8-fbe5-841d-5469-3adcfc178ab3@amd.com>
On Mon, 5 Jun 2023 09:26:25 -0700 Shannon Nelson wrote:
> > Hm, could you say more about motivation? The ethtool stat is supposed to
> > come from HW and represent PHY-level flap count. It's used primarily to
> > find bad cables in a datacenter. Is this also the use case for ionic?
> > It's unclear to me whether ionic interfaces are seeing an actual PHY or
> > just some virtual link state of the IPU and in the latter case it's not
> > really a match.
>
> This is a fair question - yes, it is possible that the FW could fake it,
> but normally this is a signal from the HW. However, I suppose it would
> be best to only have the PF reporting this counter, and not the VFs,
> which is currently the case here. I'll have Nitya modify this for PF only.
Perfect, thanks!
prev parent reply other threads:[~2023-06-05 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 17:32 [PATCH net-next] ionic: add support for ethtool extended stat link_down_count Shannon Nelson
2023-06-03 6:11 ` Siddharth Vadapalli
2023-06-05 16:31 ` Shannon Nelson
2023-06-03 6:47 ` Jakub Kicinski
2023-06-05 16:26 ` Shannon Nelson
2023-06-05 19:05 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605120505.71f518ae@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=netdev@vger.kernel.org \
--cc=nitya.sunkad@amd.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.