From: Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
To: abbotti@mev.co.uk
Cc: hsweeten@visionengravers.com, linux-kernel@vger.kernel.org,
Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
Subject: [PATCH] drivers: comedi: drivers: s526: fixed a commented out if else coding style issue
Date: Mon, 5 Jun 2023 18:43:06 +0530 [thread overview]
Message-ID: <20230605131306.427682-1-neelchakrabortykernelwork@gmail.com> (raw)
Fixed a coding style issue.
Signed-off-by: Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
---
drivers/comedi/drivers/s526.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/comedi/drivers/s526.c b/drivers/comedi/drivers/s526.c
index 9245c679a3c4..12aa40920575 100644
--- a/drivers/comedi/drivers/s526.c
+++ b/drivers/comedi/drivers/s526.c
@@ -229,7 +229,6 @@ static int s526_gpct_insn_config(struct comedi_device *dev,
*/
devpriv->gpct_config[chan] = data[0];
-#if 1
/* Set Counter Mode Register */
val = data[1] & 0xffff;
outw(val, dev->iobase + S526_GPCT_MODE_REG(chan));
@@ -246,7 +245,6 @@ static int s526_gpct_insn_config(struct comedi_device *dev,
* dev->iobase + S526_GPCT_CTRL_REG(chan));
*/
}
-#else
val = S526_GPCT_MODE_CTDIR_CTRL_QUAD;
/* data[1] contains GPCT_X1, GPCT_X2 or GPCT_X4 */
--
2.40.1
next reply other threads:[~2023-06-05 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 13:13 Neel Chakraborty [this message]
2023-06-05 20:31 ` [PATCH] drivers: comedi: drivers: s526: fixed a commented out if else coding style issue kernel test robot
2023-06-06 16:06 ` kernel test robot
2023-06-14 14:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605131306.427682-1-neelchakrabortykernelwork@gmail.com \
--to=neelchakrabortykernelwork@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.