From: cem@kernel.org
To: linux-xfs@vger.kernel.org
Subject: [PATCH V2] xfs: Comment out unreachable code within xchk_fscounters()
Date: Tue, 6 Jun 2023 17:11:22 +0200 [thread overview]
Message-ID: <20230606151122.853315-1-cem@kernel.org> (raw)
From: Carlos Maiolino <cem@kernel.org>
Comment the code out so kernel test robot stop complaining about it
every single test build.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
fs/xfs/scrub/fscounters.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/xfs/scrub/fscounters.c b/fs/xfs/scrub/fscounters.c
index e382a35e98d88..228efe0c99be8 100644
--- a/fs/xfs/scrub/fscounters.c
+++ b/fs/xfs/scrub/fscounters.c
@@ -153,6 +153,7 @@ xchk_setup_fscounters(
return xchk_trans_alloc(sc, 0);
}
+#if 0
/*
* Part 1: Collecting filesystem summary counts. For each AG, we add its
* summary counts (total inodes, free inodes, free data blocks) to an incore
@@ -349,6 +350,7 @@ xchk_fscount_count_frextents(
return 0;
}
#endif /* CONFIG_XFS_RT */
+#endif
/*
* Part 2: Comparing filesystem summary counters. All we have to do here is
@@ -422,7 +424,10 @@ xchk_fscounters(
struct xfs_mount *mp = sc->mp;
struct xchk_fscounters *fsc = sc->buf;
int64_t icount, ifree, fdblocks, frextents;
+
+#if 0
int error;
+#endif
/* Snapshot the percpu counters. */
icount = percpu_counter_sum(&mp->m_icount);
@@ -452,6 +457,7 @@ xchk_fscounters(
*/
return 0;
+#if 0
/*
* If ifree exceeds icount by more than the minimum variance then
* something's probably wrong with the counters.
@@ -489,4 +495,5 @@ xchk_fscounters(
xchk_set_corrupt(sc);
return 0;
+#endif
}
--
2.30.2
next reply other threads:[~2023-06-06 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 15:11 cem [this message]
2023-06-06 15:17 ` [PATCH V2] xfs: Comment out unreachable code within xchk_fscounters() Darrick J. Wong
2023-06-07 6:39 ` Christoph Hellwig
2023-06-07 7:37 ` Carlos Maiolino
2023-06-07 7:48 ` Christoph Hellwig
2023-06-07 8:48 ` Carlos Maiolino
2023-06-07 14:28 ` Darrick J. Wong
2023-06-07 14:30 ` Christoph Hellwig
2023-06-07 14:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606151122.853315-1-cem@kernel.org \
--to=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.