From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <linux-tegra@vger.kernel.org>,
Petlozu Pravareshwar <petlozup@nvidia.com>,
Bharat Nihalani <bnihalani@nvidia.com>,
Kartik <kkartik@nvidia.com>, "Jon Hunter" <jonathanh@nvidia.com>
Subject: [PATCH 1/3] soc/tegra: pmc: Use debugfs_initialized()
Date: Tue, 6 Jun 2023 16:36:06 +0100 [thread overview]
Message-ID: <20230606153608.94289-1-jonathanh@nvidia.com> (raw)
From: Bharat Nihalani <bnihalani@nvidia.com>
The kernel command line parameter debugfs=off can be used to dynamically
disable debugfs support at boot time. However, the Tegra PMC driver will
always attempt to register debugfs entries if CONFIG_DEBUG_FS is
enabled. Therefore, if CONFIG_DEBUG_FS is enabled but the user sets
debugfs=off, then probing the PMC driver will fail.
Fix this by using the function debugfs_initialized() to check if debugfs
support is enabled before calling any debugfs functions in the Tegra PMC
driver. Note that if CONFIG_DEBUG_FS is not defined
debugfs_initialized() will return false.
Signed-off-by: Bharat Nihalani <bnihalani@nvidia.com>
Signed-off-by: Kartik <kkartik@nvidia.com>
Co-developed-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/soc/tegra/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 5d17799524c9..12e852a8a609 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -3026,7 +3026,7 @@ static int tegra_pmc_probe(struct platform_device *pdev)
tegra_pmc_reset_sysfs_init(pmc);
- if (IS_ENABLED(CONFIG_DEBUG_FS)) {
+ if (debugfs_initialized()) {
err = tegra_powergate_debugfs_init();
if (err < 0)
goto cleanup_sysfs;
--
2.34.1
next reply other threads:[~2023-06-06 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 15:36 Jon Hunter [this message]
2023-06-06 15:36 ` [PATCH 2/3] soc/tegra: pmc: Add AON SW Wake support for Tegra234 Jon Hunter
2023-06-06 15:36 ` [PATCH 3/3] soc/tegra: fuse: Fix Tegra234 fuse size Jon Hunter
2023-06-08 16:33 ` [PATCH 1/3] soc/tegra: pmc: Use debugfs_initialized() Thierry Reding
2023-06-08 16:36 ` (subset) " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606153608.94289-1-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bnihalani@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=petlozup@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.