From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5911C7EE25 for ; Wed, 7 Jun 2023 04:30:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38F7D10E416; Wed, 7 Jun 2023 04:30:48 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9AD5F10E416 for ; Wed, 7 Jun 2023 04:30:45 +0000 (UTC) Received: from pendragon.ideasonboard.com (om126233170111.36.openmobile.ne.jp [126.233.170.111]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D56332B6; Wed, 7 Jun 2023 06:30:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686112218; bh=yOoSdsEWv7NH++TRQ7A5AmADmeDU2Han4n3O5WQdd6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DvZo1H58PEsl6InTU6IxfFDp2EM0i5JqO9H2PALxEzwv5QTBy2CrSv4cboL7MwraX /9NK+8D8Z8GzJpritnYhWXoTOrAbPDV16Co2PYPKUilY3tm+nfq/wwBVALvgbUjJy9 J1e9b+wsuI6fvc/1k+c0NTD2pBEJB4+AXLWv3pTo= Date: Wed, 7 Jun 2023 07:30:41 +0300 From: Laurent Pinchart To: Siddh Raman Pant Subject: Re: [PATCH v9 0/8] drm: Remove usage of deprecated DRM_* macros Message-ID: <20230607043041.GE14101@pendragon.ideasonboard.com> References: <20230606150545.GJ5197@pendragon.ideasonboard.com> <18891c17458.393a54b1127185.1502341592143085000@siddh.me> <20230606174928.GB14101@pendragon.ideasonboard.com> <18891edf10b.42f0ffa4128414.8582548531031990480@siddh.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <18891edf10b.42f0ffa4128414.8582548531031990480@siddh.me> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Andrzej Hajda , Jonas Karlman , Thomas Zimmermann , dri-devel , linux-kernel , Maxime Ripard , Jernej Skrabec , Suraj Upadhyay Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 06, 2023 at 11:47:50PM +0530, Siddh Raman Pant wrote: > On Tue, 06 Jun 2023 23:19:28 +0530, Laurent Pinchart wrote: > > The idea would be to include the drm_print_deprecated.h header in > > drivers that still use the deprecated macros. > > Yeah, what I meant was in a "first pass" kind of sense. > > > > Not every file can be seen at a case-by-case basis or by coccinelle > > > as far as I understand its usage. Consider the following: > > > > > > DRM_INFO is used on line 210 of amd/amdgpu/amdgpu_acpi.c, but the > > > file does not even include drm_print.h directly. It includes the > > > amdgpu.h header, which includes the amdgpu_ring.h header, which > > > finally has the "#include " line. > > > > > > If a simple find and replace has to be done, then that can be added > > > at the end of the series. > > > > Maybe a simple grep for the deprecated macros would be enough to > > identify all the files that still use them ? > > Hmm, so the drm_print_deprecated.h should be included individually on > all the files, regardless of whether they include drm_print.h directly > or not? > > Actually that makes sense, so further inclusion of top-level header > would not automatically include the deprecated macros. That's the idea, yes. It would also clearly flag drivers that need to be converted to the new macros. > Since this needs some thought, I will be sending v10 without this. > This change can be sent later separately, as it will anyways be a > huge patch, and 10 is already a big enough revision number. Sounds good to me. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 873F7C77B7A for ; Wed, 7 Jun 2023 04:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbjFGEdP (ORCPT ); Wed, 7 Jun 2023 00:33:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjFGEce (ORCPT ); Wed, 7 Jun 2023 00:32:34 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 061B81FF7 for ; Tue, 6 Jun 2023 21:30:46 -0700 (PDT) Received: from pendragon.ideasonboard.com (om126233170111.36.openmobile.ne.jp [126.233.170.111]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D56332B6; Wed, 7 Jun 2023 06:30:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686112218; bh=yOoSdsEWv7NH++TRQ7A5AmADmeDU2Han4n3O5WQdd6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DvZo1H58PEsl6InTU6IxfFDp2EM0i5JqO9H2PALxEzwv5QTBy2CrSv4cboL7MwraX /9NK+8D8Z8GzJpritnYhWXoTOrAbPDV16Co2PYPKUilY3tm+nfq/wwBVALvgbUjJy9 J1e9b+wsuI6fvc/1k+c0NTD2pBEJB4+AXLWv3pTo= Date: Wed, 7 Jun 2023 07:30:41 +0300 From: Laurent Pinchart To: Siddh Raman Pant Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Jani Nikula , dri-devel , linux-kernel , Suraj Upadhyay Subject: Re: [PATCH v9 0/8] drm: Remove usage of deprecated DRM_* macros Message-ID: <20230607043041.GE14101@pendragon.ideasonboard.com> References: <20230606150545.GJ5197@pendragon.ideasonboard.com> <18891c17458.393a54b1127185.1502341592143085000@siddh.me> <20230606174928.GB14101@pendragon.ideasonboard.com> <18891edf10b.42f0ffa4128414.8582548531031990480@siddh.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <18891edf10b.42f0ffa4128414.8582548531031990480@siddh.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 11:47:50PM +0530, Siddh Raman Pant wrote: > On Tue, 06 Jun 2023 23:19:28 +0530, Laurent Pinchart wrote: > > The idea would be to include the drm_print_deprecated.h header in > > drivers that still use the deprecated macros. > > Yeah, what I meant was in a "first pass" kind of sense. > > > > Not every file can be seen at a case-by-case basis or by coccinelle > > > as far as I understand its usage. Consider the following: > > > > > > DRM_INFO is used on line 210 of amd/amdgpu/amdgpu_acpi.c, but the > > > file does not even include drm_print.h directly. It includes the > > > amdgpu.h header, which includes the amdgpu_ring.h header, which > > > finally has the "#include " line. > > > > > > If a simple find and replace has to be done, then that can be added > > > at the end of the series. > > > > Maybe a simple grep for the deprecated macros would be enough to > > identify all the files that still use them ? > > Hmm, so the drm_print_deprecated.h should be included individually on > all the files, regardless of whether they include drm_print.h directly > or not? > > Actually that makes sense, so further inclusion of top-level header > would not automatically include the deprecated macros. That's the idea, yes. It would also clearly flag drivers that need to be converted to the new macros. > Since this needs some thought, I will be sending v10 without this. > This change can be sent later separately, as it will anyways be a > huge patch, and 10 is already a big enough revision number. Sounds good to me. -- Regards, Laurent Pinchart