From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: hare@suse.de, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, kbusch@kernel.org
Subject: Re: [PATCH V2 3/4] nvmet-auth: use helper for auth send/recv cmd prep
Date: Wed, 7 Jun 2023 06:57:49 +0200 [thread overview]
Message-ID: <20230607045749.GA19819@lst.de> (raw)
In-Reply-To: <20230605064434.45233-4-kch@nvidia.com>
On Sun, Jun 04, 2023 at 11:44:33PM -0700, Chaitanya Kulkarni wrote:
> Add a common helper to factor out secp/spsp values check and transfer
> buffer allocation in nvmet_execute_auth_send() and
> nvmet_execute_auth_receive().
While the patch looks correct, I can't say I really like. Having a
"common prep" function for just two unrelated things doesn't exactly
improve readability. And it also doesn't remove all that much code.
next prev parent reply other threads:[~2023-06-07 4:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 6:44 [PATCH V2 0/4] nvmet-auth: auth send / receive cleanup Chaitanya Kulkarni
2023-06-05 6:44 ` [PATCH V2 1/4] nvmet-auth: use common helper to check secp/spsp Chaitanya Kulkarni
2023-06-05 7:42 ` Hannes Reinecke
2023-06-05 6:44 ` [PATCH V2 2/4] nvmet_auth: use common helper for buffer alloc Chaitanya Kulkarni
2023-06-05 7:45 ` Hannes Reinecke
2023-06-05 6:44 ` [PATCH V2 3/4] nvmet-auth: use helper for auth send/recv cmd prep Chaitanya Kulkarni
2023-06-05 7:46 ` Hannes Reinecke
2023-06-05 8:41 ` Chaitanya Kulkarni
2023-06-07 4:57 ` Christoph Hellwig [this message]
2023-06-05 6:44 ` [PATCH V2 4/4] nvmet-auth: use correct type for status variable Chaitanya Kulkarni
2023-06-05 7:49 ` Hannes Reinecke
2023-06-07 4:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607045749.GA19819@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.