From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA6EDC7EE25 for ; Wed, 7 Jun 2023 05:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X6yIwseaBtInVMd/whpYtXei0Jvj0lo0025Cghnb8BY=; b=smrh3Y/MglRkdB oRm99GE5QNimiclw05RV2TmkWvDAN4S5NxyTQQMAli0ous3vVdM/Enc0O3aRMvYgMJNJcQbSPO7YM ZhPBdk/xN/WARrUAyHWfZ+SfFkOX95SrgnrIHsEYIg9irjNJaH5Nwv81/UNqWHTZj6aqYwIpGVZCp OBYl0GlHlLguOnxvqm8h6YDCbMuGEDOTDCX3plEkJJgSqkKzoaCkT6CPTd8ZwCSLeOIO4wLZoIPl6 HUjLnK3U6fRdISe60dQFriqmbh/qc1ac9BgCPIsEwwlhKjlWC8Cipber3t88+gLe7+8SM723i3QYR Xg3ytB8xZ0RMo+vJ0P5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6lO9-004O2x-0p; Wed, 07 Jun 2023 05:07:17 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6lO7-004O1b-0n for linux-arm-kernel@lists.infradead.org; Wed, 07 Jun 2023 05:07:16 +0000 Received: from pendragon.ideasonboard.com (om126233170111.36.openmobile.ne.jp [126.233.170.111]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2292E75B; Wed, 7 Jun 2023 07:06:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686114403; bh=OY3A9j7LWxOtGxybg39w2drC3GWF5OQYZWWDTDkqIl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e+qzQQ5Ms+6pyd+JJuGtTCMUTlrdpkI66ZpoUc0G0AIVMadYFeM6oErtqYj5rfk4r gj2PIIrbvDaabOh/tJ7w7tq4MBacAjZffFdzBjj2pAcdOcn4apUQjywT3SyHjLGkfN v59wNOfHzqgPxm4LuMifva0ZC55wPCBWEdVeCin0= Date: Wed, 7 Jun 2023 08:07:05 +0300 From: Laurent Pinchart To: Jiasheng Jiang Cc: hyun.kwon@xilinx.com, airlied@gmail.com, daniel@ffwll.ch, michal.simek@amd.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tomi Valkeinen Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask Message-ID: <20230607050705.GF14101@pendragon.ideasonboard.com> References: <20230607020529.22934-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607020529.22934-1-jiasheng@iscas.ac.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_220715_455788_BE1F54A2 X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Jiasheng, Thank you for the patch. On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote: > Add check for dma_set_mask() and return the error if it fails. > > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") > Signed-off-by: Jiasheng Jiang > --- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > index bab862484d42..068413be6527 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) > dpsub->dev = &pdev->dev; > platform_set_drvdata(pdev, dpsub); > > - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + if (ret) > + return ret; This seems reasonable. Reviewed-by: Laurent Pinchart Tomi, would you be able to quickly test this ? > > /* Try the reserved memory. Proceed if there's none. */ > of_reserved_mem_device_init(&pdev->dev); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C623C7EE25 for ; Wed, 7 Jun 2023 05:07:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FB4310E420; Wed, 7 Jun 2023 05:07:14 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A5F610E420 for ; Wed, 7 Jun 2023 05:07:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (om126233170111.36.openmobile.ne.jp [126.233.170.111]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2292E75B; Wed, 7 Jun 2023 07:06:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686114403; bh=OY3A9j7LWxOtGxybg39w2drC3GWF5OQYZWWDTDkqIl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e+qzQQ5Ms+6pyd+JJuGtTCMUTlrdpkI66ZpoUc0G0AIVMadYFeM6oErtqYj5rfk4r gj2PIIrbvDaabOh/tJ7w7tq4MBacAjZffFdzBjj2pAcdOcn4apUQjywT3SyHjLGkfN v59wNOfHzqgPxm4LuMifva0ZC55wPCBWEdVeCin0= Date: Wed, 7 Jun 2023 08:07:05 +0300 From: Laurent Pinchart To: Jiasheng Jiang Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask Message-ID: <20230607050705.GF14101@pendragon.ideasonboard.com> References: <20230607020529.22934-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230607020529.22934-1-jiasheng@iscas.ac.cn> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hyun.kwon@xilinx.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , michal.simek@amd.com, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Jiasheng, Thank you for the patch. On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote: > Add check for dma_set_mask() and return the error if it fails. > > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") > Signed-off-by: Jiasheng Jiang > --- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > index bab862484d42..068413be6527 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) > dpsub->dev = &pdev->dev; > platform_set_drvdata(pdev, dpsub); > > - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + if (ret) > + return ret; This seems reasonable. Reviewed-by: Laurent Pinchart Tomi, would you be able to quickly test this ? > > /* Try the reserved memory. Proceed if there's none. */ > of_reserved_mem_device_init(&pdev->dev); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07A6C7EE25 for ; Wed, 7 Jun 2023 05:07:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233485AbjFGFHQ (ORCPT ); Wed, 7 Jun 2023 01:07:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbjFGFHM (ORCPT ); Wed, 7 Jun 2023 01:07:12 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9284E7E for ; Tue, 6 Jun 2023 22:07:10 -0700 (PDT) Received: from pendragon.ideasonboard.com (om126233170111.36.openmobile.ne.jp [126.233.170.111]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2292E75B; Wed, 7 Jun 2023 07:06:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686114403; bh=OY3A9j7LWxOtGxybg39w2drC3GWF5OQYZWWDTDkqIl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e+qzQQ5Ms+6pyd+JJuGtTCMUTlrdpkI66ZpoUc0G0AIVMadYFeM6oErtqYj5rfk4r gj2PIIrbvDaabOh/tJ7w7tq4MBacAjZffFdzBjj2pAcdOcn4apUQjywT3SyHjLGkfN v59wNOfHzqgPxm4LuMifva0ZC55wPCBWEdVeCin0= Date: Wed, 7 Jun 2023 08:07:05 +0300 From: Laurent Pinchart To: Jiasheng Jiang Cc: hyun.kwon@xilinx.com, airlied@gmail.com, daniel@ffwll.ch, michal.simek@amd.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tomi Valkeinen Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask Message-ID: <20230607050705.GF14101@pendragon.ideasonboard.com> References: <20230607020529.22934-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230607020529.22934-1-jiasheng@iscas.ac.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jiasheng, Thank you for the patch. On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote: > Add check for dma_set_mask() and return the error if it fails. > > Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") > Signed-off-by: Jiasheng Jiang > --- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > index bab862484d42..068413be6527 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) > dpsub->dev = &pdev->dev; > platform_set_drvdata(pdev, dpsub); > > - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); > + if (ret) > + return ret; This seems reasonable. Reviewed-by: Laurent Pinchart Tomi, would you be able to quickly test this ? > > /* Try the reserved memory. Proceed if there's none. */ > of_reserved_mem_device_init(&pdev->dev); -- Regards, Laurent Pinchart