From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7BB7C7EE29 for ; Wed, 7 Jun 2023 08:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686126834; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cub2xrTpwYecB+NAWDdZ/00CLGUmDiCk5Hz2OEXj9eE=; b=QbJ8x4F5LLE/pxdGEwa6su+erzyYGXbi2aU7YX+WDQZvx0S7Cb1zEwut4uD/36dN7g4fc1 FWGmHFGFuJaZyJ3qjgdIJtPrK0tG/VrGQ0eZEJMBqYFdhSnGyOuyA3GdF78DexBVZtVNnM o5yav7flyc8EEKHfA9sdPjaUqEhghcY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-292-ICcZknxWOY-E-siW1QdPag-1; Wed, 07 Jun 2023 04:33:51 -0400 X-MC-Unique: ICcZknxWOY-E-siW1QdPag-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7419028135AC; Wed, 7 Jun 2023 08:33:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 708619E8B; Wed, 7 Jun 2023 08:33:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9F3AF19452C3; Wed, 7 Jun 2023 08:33:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 60E8219465BA for ; Wed, 7 Jun 2023 08:33:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9EFCE403367; Wed, 7 Jun 2023 08:33:01 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 983EF477F61 for ; Wed, 7 Jun 2023 08:33:01 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E228811E86 for ; Wed, 7 Jun 2023 08:33:01 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-FiCsXNqyN_mORWEOK7sNDg-1; Wed, 07 Jun 2023 04:32:59 -0400 X-MC-Unique: FiCsXNqyN_mORWEOK7sNDg-1 Received: by verein.lst.de (Postfix, from userid 2407) id E15E86732D; Wed, 7 Jun 2023 10:32:53 +0200 (CEST) Date: Wed, 7 Jun 2023 10:32:53 +0200 From: Christoph Hellwig To: Christian Brauner Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> MIME-Version: 1.0 In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Subject: Re: [dm-devel] [PATCH 01/31] block: also call ->open for incremental partition opens X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , Christoph Hellwig , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: lst.de Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77C1C77B7A for ; Wed, 7 Jun 2023 08:33:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239422AbjFGIdM (ORCPT ); Wed, 7 Jun 2023 04:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239314AbjFGIdI (ORCPT ); Wed, 7 Jun 2023 04:33:08 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C1A610F9; Wed, 7 Jun 2023 01:33:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id E15E86732D; Wed, 7 Jun 2023 10:32:53 +0200 (CEST) Date: Wed, 7 Jun 2023 10:32:53 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 01/31] block: also call ->open for incremental partition opens Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFE6AC83005 for ; Wed, 7 Jun 2023 08:33:11 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q6obO-0003bx-VR; Wed, 07 Jun 2023 08:33:11 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q6obN-0003bq-3z for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 08:33:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y/0t9c4SY3SShfmM/+4Kp5Hz5Wz8u51E8hCvz4NiAPs=; b=WRaFHjus5t24xqeKnl8z8lYkhb 0KGb29xgLTjoHeZUuaYn6Oj9TKeAySu0hiWnMR6g4eBq/9vL9SWjvpDjR/kzN5KoWYvFyI55xdD65 6YTBkZ3SjtFMwTBtym5ozhzu+JTQ4EQ07e/+gxOEBK8RfQrZO1rnxNx951WjZvws5rTI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y/0t9c4SY3SShfmM/+4Kp5Hz5Wz8u51E8hCvz4NiAPs=; b=l8t3IWdgedVVKHnq6zZrnvCEQx qXLpZuLqUoT2l+ysk2qsabyAFSI18nOjB5pr1u0AxEIrli4fwNkFC9DvHPMN6XJRa65ZgwAJjw+pI ZOaziOECdLKsIP5MsrS7sMivSPo4AY1fkeZIicFIfi2Cct0MylWH0VxjWoZneEQ8N+8E=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1q6obL-0003Pv-Fe for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 08:33:09 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E15E86732D; Wed, 7 Jun 2023 10:32:53 +0200 (CEST) Date: Wed, 7 Jun 2023 10:32:53 +0200 From: Christoph Hellwig To: Christian Brauner Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1q6obL-0003Pv-Fe Subject: Re: [f2fs-dev] [PATCH 01/31] block: also call ->open for incremental partition opens X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , Christoph Hellwig , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/31] block: also call ->open for incremental partition opens Date: Wed, 7 Jun 2023 10:32:53 +0200 Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-nvme@lists. On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64A67C7EE29 for ; Wed, 7 Jun 2023 08:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QuXprJezD5YbucKDDUl9XoLAEGmas5o/njLCwJSUGeE=; b=vAAMoPPdbKpu4q M62LX5sj0UbCKV6yodo9GyQ7kYRbYa0y/SiekwmDX3D0rVc4tIUxT+izOon1py5ZqrfpCm+fTB6d7 HhAv+M7vJf+up1wUxJtkm2wRsg7Sl5ZUnXAl72ATbdDBiuE9Sb0MSn+AOQv43QOA/7UcZjnMKiYgs XQ+MiWp9wTQC3oQgkhg9pml7qUrgteRkeXpcufGtaix8TFl4EdTzWIQLuqmWiHrJcO8QVRyecnmbE 68pFEKpQBSgBKqX4xuDoOag+RMVXSsfpFrhNZM9n0Ui8qsJBXhvj6TIqwZJHqGW0r5OF4+JEdyfYH 0Ci1n2irtimcmmYZxgfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6obM-004ysc-0X; Wed, 07 Jun 2023 08:33:08 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6obI-004ynr-0C; Wed, 07 Jun 2023 08:33:06 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E15E86732D; Wed, 7 Jun 2023 10:32:53 +0200 (CEST) Date: Wed, 7 Jun 2023 10:32:53 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 01/31] block: also call ->open for incremental partition opens Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_013304_263358_5AB5A308 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4354C7EE43 for ; Wed, 7 Jun 2023 08:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1f+jQ2WhC8UkOjw6TzAV7OJUHfjfUXUKWYMvvCRyVFg=; b=q3wKAU/XcfMdWW UI+EoZkzauZG230KzSXQ+fZCdn3hxz5iSrlHLHkPWICW9nXie2s4og6xlMHqHw4ztm3Rl5T6b7jDM ANdjfHNnmwvCv0fEuP68i1Egzm+2wvdqS22k7yPiIjmNerosVVK2Vbf8iZWg/nwTLGmsQvBUEUYzH e1uijE8VdWB4UdNSmPYsWM7q2eiWobFhd/NzhJS5zO2xd7OkmCXdpnBydKcdmlekfkUivD2aW5U5C vAcnB6NLJ/ouKrXYpVu9Q7oHlWTwQ8lwCvuJlXvAJa0Z3IEmZKyba+gZ35YAI0hmVE0xyaDkBmg8k 6bmQBer8Y2vekuYphN8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6obN-004ytL-1V; Wed, 07 Jun 2023 08:33:09 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6obI-004ynr-0C; Wed, 07 Jun 2023 08:33:06 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E15E86732D; Wed, 7 Jun 2023 10:32:53 +0200 (CEST) Date: Wed, 7 Jun 2023 10:32:53 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 01/31] block: also call ->open for incremental partition opens Message-ID: <20230607083253.GA29653@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607-behelfen-abnormal-8ccf8e1e99c9@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_013304_263358_5AB5A308 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 10:14:22AM +0200, Christian Brauner wrote: > This assumes that all drivers deal with additional ->open() calls for > each partition correctly which I assumed you checked so, They have to, because they already get the additional open for extra opens of the whole device. The current behavior is: open("/dev/vdb", ...) ->open called open("/dev/vdb", ...) ->open called ---- open("/dev/vdb", ...) ->open called open("/dev/vdb1", ...) ->open called ---- open("/dev/vdb1", ...) ->open called open("/dev/vdb1", ...) ->open NOT called which is very inconsistent. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um