From: Jakub Kicinski <kuba@kernel.org>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>,
"Michal Swiatkowski" <michal.swiatkowski@linux.intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>,
<aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next 1/3] iavf: add check for current MAC address in set_mac callback
Date: Wed, 7 Jun 2023 09:38:10 -0700 [thread overview]
Message-ID: <20230607093810.36b03b55@kernel.org> (raw)
In-Reply-To: <b7b63c6b-7bfb-6bd7-e361-298da38011a4@intel.com>
On Wed, 7 Jun 2023 12:29:36 +0200 Piotr Gardocki wrote:
> I need a piece of advice though:
> 1) Should I fix it in this patch set, or treat it as a separate thread?
Separate is probably better, you can post such a change directly
to netdev, without going via the Intel tree.
> 2) I suppose the change is required only in dev_set_mac_address function, but
> am I right assuming we should do it before call to dev_pre_changeaddr_notify
> and return from function early? What about call to add_device_randomness?
I'd add the check right after the netif_device_present() check and not
worry about notifier or randomness. The address isn't changing so
nothing to notify about and no real randomness to be gained.
next prev parent reply other threads:[~2023-06-07 16:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 17:12 [PATCH net-next 0/3][pull request] Intel Wired LAN Driver Updates 2023-06-02 (iavf) Tony Nguyen
2023-06-02 17:13 ` [PATCH net-next 1/3] iavf: add check for current MAC address in set_mac callback Tony Nguyen
2023-06-03 14:06 ` Simon Horman
2023-06-05 19:02 ` Maciej Fijalkowski
2023-06-06 9:22 ` Piotr Gardocki
2023-06-06 10:21 ` Maciej Fijalkowski
2023-06-06 12:54 ` Alexander Lobakin
2023-06-06 17:24 ` Jakub Kicinski
2023-06-07 10:29 ` Piotr Gardocki
2023-06-07 16:38 ` Jakub Kicinski [this message]
2023-06-07 20:22 ` Maciej Fijalkowski
2023-06-02 17:13 ` [PATCH net-next 2/3] iavf: fix err handling for MAC replace Tony Nguyen
2023-06-03 14:07 ` Simon Horman
2023-06-05 19:17 ` Maciej Fijalkowski
2023-06-06 10:14 ` Przemek Kitszel
2023-06-06 10:23 ` Maciej Fijalkowski
2023-06-06 11:59 ` Przemek Kitszel
2023-06-07 13:57 ` Przemek Kitszel
2023-06-07 19:08 ` Fijalkowski, Maciej
2023-06-16 7:09 ` Przemek Kitszel
2023-06-16 17:13 ` Tony Nguyen
2023-06-02 17:13 ` [PATCH net-next 3/3] iavf: remove mask from iavf_irq_enable_queues() Tony Nguyen
2023-06-03 14:07 ` Simon Horman
2023-06-05 19:25 ` Maciej Fijalkowski
2023-06-05 19:56 ` Ahmed Zaki
2023-06-06 10:26 ` Maciej Fijalkowski
2023-06-06 15:23 ` Ahmed Zaki
2023-06-06 16:01 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607093810.36b03b55@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotrx.gardocki@intel.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.