From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Chuck Lever <chuck.lever@oracle.com>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Ahern <dsahern@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 03/14] splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage()
Date: Wed, 7 Jun 2023 09:55:41 -0700 [thread overview]
Message-ID: <20230607095541.586a3300@kernel.org> (raw)
In-Reply-To: <20230607140559.2263470-4-dhowells@redhat.com>
On Wed, 7 Jun 2023 15:05:48 +0100 David Howells wrote:
> Replace generic_splice_sendpage() + splice_from_pipe + pipe_to_sendpage()
> with a net-specific handler, splice_to_socket(), that calls sendmsg() with
> MSG_SPLICE_PAGES set instead of calling ->sendpage().
>
> MSG_MORE is used to indicate if the sendmsg() is expected to be followed
> with more data.
>
> This allows multiple pipe-buffer pages to be passed in a single call in a
> BVEC iterator, allowing the processing to be pushed down to a loop in the
> protocol driver. This helps pave the way for passing multipage folios down
> too.
>
> Protocols that haven't been converted to handle MSG_SPLICE_PAGES yet should
> just ignore it and do a normal sendmsg() for now - although that may be a
> bit slower as it may copy everything.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-06-07 16:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:05 [PATCH net-next v5 00/14] splice, net: Rewrite splice-to-socket, fix SPLICE_F_MORE and handle MSG_SPLICE_PAGES in AF_TLS David Howells
2023-06-07 14:05 ` [PATCH net-next v5 01/14] net: Block MSG_SENDPAGE_* from being passed to sendmsg() by userspace David Howells
2023-06-07 14:05 ` [PATCH net-next v5 02/14] tls: Allow MSG_SPLICE_PAGES but treat it as normal sendmsg David Howells
2023-06-07 14:05 ` [PATCH net-next v5 03/14] splice, net: Use sendmsg(MSG_SPLICE_PAGES) rather than ->sendpage() David Howells
2023-06-07 16:55 ` Jakub Kicinski [this message]
2023-06-07 14:05 ` [PATCH net-next v5 04/14] splice, net: Add a splice_eof op to file-ops and socket-ops David Howells
2023-06-07 16:56 ` Jakub Kicinski
2023-06-07 14:05 ` [PATCH net-next v5 05/14] tls/sw: Use splice_eof() to flush David Howells
2023-06-07 16:57 ` Jakub Kicinski
2023-06-07 14:05 ` [PATCH net-next v5 06/14] tls/device: " David Howells
2023-06-07 16:58 ` Jakub Kicinski
2023-06-07 14:05 ` [PATCH net-next v5 07/14] ipv4, ipv6: " David Howells
2023-06-07 15:32 ` Kuniyuki Iwashima
2023-06-07 15:43 ` David Howells
2023-06-07 15:54 ` Kuniyuki Iwashima
2023-06-07 16:01 ` David Howells
2023-06-07 14:05 ` [PATCH net-next v5 08/14] chelsio/chtls: " David Howells
2023-06-07 14:05 ` [PATCH net-next v5 09/14] kcm: " David Howells
2023-06-07 16:05 ` Kuniyuki Iwashima
2023-06-07 17:10 ` David Howells
2023-06-07 14:05 ` [PATCH net-next v5 10/14] splice, net: Fix SPLICE_F_MORE signalling in splice_direct_to_actor() David Howells
2023-06-07 14:05 ` [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES David Howells
2023-06-07 17:19 ` Jakub Kicinski
2023-06-07 17:29 ` David Howells
2023-06-07 17:31 ` David Howells
2023-06-07 17:34 ` Jakub Kicinski
2023-06-07 14:05 ` [PATCH net-next v5 12/14] tls/sw: Convert tls_sw_sendpage() to use MSG_SPLICE_PAGES David Howells
2023-06-07 17:20 ` Jakub Kicinski
2023-06-07 14:05 ` [PATCH net-next v5 13/14] tls/device: Support MSG_SPLICE_PAGES David Howells
2023-06-07 17:25 ` Jakub Kicinski
2023-06-07 14:05 ` [PATCH net-next v5 14/14] tls/device: Convert tls_device_sendpage() to use MSG_SPLICE_PAGES David Howells
2023-06-07 17:26 ` Jakub Kicinski
2023-06-07 17:35 ` David Howells
2023-06-07 17:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607095541.586a3300@kernel.org \
--to=kuba@kernel.org \
--cc=axboe@kernel.dk \
--cc=borisp@nvidia.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.