From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CEACC7EE37 for ; Thu, 8 Jun 2023 06:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686206950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zSve+Ihjl9g9fwhALXmxBnqJ82IN8InlfX7npBXQhyg=; b=E20xR+DMraKK662NhGB5bf9n3lDfPyX8KpAag8nbuEhulopUJK2OY1F6M2z+eI/ndkc/dy bjg4GV9duno0JuMGLD2HYd4aVj61gKjcrwwO5rwUuBYgI/h7s7qYkMSuUxeEC7bfCr4aon I/5EaQlQ+qlN4uZZ/SApzjQ6w44MZnY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-LvfLUPnJNe280WbM-hr8PQ-1; Thu, 08 Jun 2023 02:49:06 -0400 X-MC-Unique: LvfLUPnJNe280WbM-hr8PQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4670101B044; Thu, 8 Jun 2023 06:49:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C09C64026E2; Thu, 8 Jun 2023 06:49:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BB72519451DE; Thu, 8 Jun 2023 06:48:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5650B19451CA for ; Wed, 7 Jun 2023 12:19:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id CE3689E9E; Wed, 7 Jun 2023 12:18:56 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C62639E9C for ; Wed, 7 Jun 2023 12:18:56 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ABDC6811E92 for ; Wed, 7 Jun 2023 12:18:56 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-iRcnD41gPqu1DTNBvxff2w-1; Wed, 07 Jun 2023 08:18:54 -0400 X-MC-Unique: iRcnD41gPqu1DTNBvxff2w-1 Received: by verein.lst.de (Postfix, from userid 2407) id AC1196732D; Wed, 7 Jun 2023 14:18:50 +0200 (CEST) Date: Wed, 7 Jun 2023 14:18:50 +0200 From: Christoph Hellwig To: Christian Brauner Message-ID: <20230607121850.GA14396@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-31-hch@lst.de> <20230607-verjagen-weise-4fb3d76a6313@brauner> MIME-Version: 1.0 In-Reply-To: <20230607-verjagen-weise-4fb3d76a6313@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mailman-Approved-At: Thu, 08 Jun 2023 06:48:46 +0000 Subject: Re: [dm-devel] [PATCH 30/31] block: store the holder in file->private_data X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , Christoph Hellwig , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: lst.de Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote: > > Store the file struct used as the holder in file->private_data as an > > indicator that this file descriptor was opened exclusively to remove > > the last use of FMODE_EXCL. > > > > Signed-off-by: Christoph Hellwig > > --- > > Feels a bit odd to store the object itself but anyway, > Acked-by: Christian Brauner We could literally store anything we want. The only reason I picked the file is because: a) we have it around and b) that allows passing it to blkdev_put without a branch in blkdev_release. If you prefer something else I can change it. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDD4C7EE23 for ; Wed, 7 Jun 2023 12:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240577AbjFGMTA (ORCPT ); Wed, 7 Jun 2023 08:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240641AbjFGMS6 (ORCPT ); Wed, 7 Jun 2023 08:18:58 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20A311BF5; Wed, 7 Jun 2023 05:18:55 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id AC1196732D; Wed, 7 Jun 2023 14:18:50 +0200 (CEST) Date: Wed, 7 Jun 2023 14:18:50 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 30/31] block: store the holder in file->private_data Message-ID: <20230607121850.GA14396@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-31-hch@lst.de> <20230607-verjagen-weise-4fb3d76a6313@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607-verjagen-weise-4fb3d76a6313@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote: > > Store the file struct used as the holder in file->private_data as an > > indicator that this file descriptor was opened exclusively to remove > > the last use of FMODE_EXCL. > > > > Signed-off-by: Christoph Hellwig > > --- > > Feels a bit odd to store the object itself but anyway, > Acked-by: Christian Brauner We could literally store anything we want. The only reason I picked the file is because: a) we have it around and b) that allows passing it to blkdev_put without a branch in blkdev_release. If you prefer something else I can change it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34001C7EE23 for ; Wed, 7 Jun 2023 12:19:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1q6s88-0007zJ-Sf; Wed, 07 Jun 2023 12:19:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q6s81-0007zB-9v for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 12:19:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G1xVSMT4nYeIjHeAvG7KBUYvK0CX2nm2f0U1ZadXKG8=; b=cqRClxjjIJ5XNuOxedliWdCjXU b2sFgferb1Py6XfFLXrgahLwtQAHjBlrPqhVqzS+gUpADLrRHTuefSpRCul0hIuh0mhzXSfNfh5Dt L+fete4Ha+1cyAExT/hohtbEHbAJjsibSw1E57g5RRqig0a9Wu/UmS7TA16O+ubJV3i8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G1xVSMT4nYeIjHeAvG7KBUYvK0CX2nm2f0U1ZadXKG8=; b=BLk6mRliqWheKJk2LJRGNioDGT LDTX9Us4d1wq/+ObPRPQvrf9gEvVszPHLpTy70THw9NOp8FJgJEJEQ3W6QJd9oqyWBVHsBwglY8Jv MxsR0ewNzb8Js7hjk6WMNOyRFCH3ELmbCdx/TTeK0CocBM7LJSXfSFZo6hFbkWPogmHQ=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1q6s7v-0003JC-7d for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Jun 2023 12:19:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AC1196732D; Wed, 7 Jun 2023 14:18:50 +0200 (CEST) Date: Wed, 7 Jun 2023 14:18:50 +0200 From: Christoph Hellwig To: Christian Brauner Message-ID: <20230607121850.GA14396@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-31-hch@lst.de> <20230607-verjagen-weise-4fb3d76a6313@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607-verjagen-weise-4fb3d76a6313@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1q6s7v-0003JC-7d Subject: Re: [f2fs-dev] [PATCH 30/31] block: store the holder in file->private_data X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , "Rafael J. Wysocki" , linux-nvme@lists.infradead.org, Phillip Potter , Chris Mason , dm-devel@redhat.com, "Md. Haris Iqbal" , Pavel Machek , Miquel Raynal , Jack Wang , Christoph Hellwig , linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , linux-pm@vger.kernel.org, linux-um@lists.infradead.org, Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, Alexander Viro , David Sterba , Jens Axboe , "Martin K. Petersen" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote: > > Store the file struct used as the holder in file->private_data as an > > indicator that this file descriptor was opened exclusively to remove > > the last use of FMODE_EXCL. > > > > Signed-off-by: Christoph Hellwig > > --- > > Feels a bit odd to store the object itself but anyway, > Acked-by: Christian Brauner We could literally store anything we want. The only reason I picked the file is because: a) we have it around and b) that allows passing it to blkdev_put without a branch in blkdev_release. If you prefer something else I can change it. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 30/31] block: store the holder in file->private_data Date: Wed, 7 Jun 2023 14:18:50 +0200 Message-ID: <20230607121850.GA14396@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-31-hch@lst.de> <20230607-verjagen-weise-4fb3d76a6313@brauner> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20230607-verjagen-weise-4fb3d76a6313@brauner> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-nvme@lists. On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote: > > Store the file struct used as the holder in file->private_data as an > > indicator that this file descriptor was opened exclusively to remove > > the last use of FMODE_EXCL. > > > > Signed-off-by: Christoph Hellwig > > --- > > Feels a bit odd to store the object itself but anyway, > Acked-by: Christian Brauner We could literally store anything we want. The only reason I picked the file is because: a) we have it around and b) that allows passing it to blkdev_put without a branch in blkdev_release. If you prefer something else I can change it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C365C7EE23 for ; Wed, 7 Jun 2023 12:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vbzIQYe3euZfPbsbz4K9O7kB5KmQjD5apWgZx9hF1qU=; b=nQOy93Mg9oWco+ sb9iGH9vjhZjANTP305Ftp1sZuy1qn9VwlbnIHyAFmoNZUddamO7khgkLq9KBH3UzCKf8FLOnOaFK GxZnjL8PTxyYSw+6k/9Yy8QR15dqz9SCcIObJdmSPHSFYL5U+9MKuobtvUQtCpbDRY54CxYL+Zro8 Gecy1LLP67h6Jh/jPmR792FM8tpipSxz93UUjqKnjQhlUtPgLhaSIkbCxd6bh59OfHHUhrKLSKZDS sYGdJ1qb9yUVC554jf96j2P4WO4YS3mtDfaM0xX/TJgXGuoutSNSx/t9kEpdqboLONQmW6F4/iAn3 FeY5D6KM6BBAWjOvPeBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6s7s-005ped-38; Wed, 07 Jun 2023 12:18:56 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6s7q-005pd4-0L; Wed, 07 Jun 2023 12:18:55 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AC1196732D; Wed, 7 Jun 2023 14:18:50 +0200 (CEST) Date: Wed, 7 Jun 2023 14:18:50 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 30/31] block: store the holder in file->private_data Message-ID: <20230607121850.GA14396@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-31-hch@lst.de> <20230607-verjagen-weise-4fb3d76a6313@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607-verjagen-weise-4fb3d76a6313@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_051854_289769_D6D87729 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote: > > Store the file struct used as the holder in file->private_data as an > > indicator that this file descriptor was opened exclusively to remove > > the last use of FMODE_EXCL. > > > > Signed-off-by: Christoph Hellwig > > --- > > Feels a bit odd to store the object itself but anyway, > Acked-by: Christian Brauner We could literally store anything we want. The only reason I picked the file is because: a) we have it around and b) that allows passing it to blkdev_put without a branch in blkdev_release. If you prefer something else I can change it. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADB19C7EE29 for ; Wed, 7 Jun 2023 12:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G+sDmS8qDtOih8Hz0HeEYfXz7hU8vBs/kGelyL/kgCY=; b=g58Iy3akqS8O3w Vynsi4Rw7/yY4p3N+rvgvkhLXpGiXr5nyqP6i6cdCKZzFI0ZK9I26Lbt9ktCckCKfZ+cCVEozTDms aaZZqccnohRTm6Msw68G+fXWw6Vo3bbkuI7kq1rbw6u072BjgGaxTcTY/jwR6HsiBiK4rXMcXByoz Ck/cT+C0rvXgS3CEpg85JxchP89hHsEYTw/HbpHRzRPJ2Ohq54WMRpErr4uvctUw6L5x+6GrIa8sU izRiwDQiqU1V6qa9ON43yRYxKmnO8XKyTRchhQb5/u7ttyygWugURsbUqqn27HI1pACTJpeD9hHKY Uk+CxCqj1zxW/AOazHLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6s7u-005pff-19; Wed, 07 Jun 2023 12:18:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6s7q-005pd4-0L; Wed, 07 Jun 2023 12:18:55 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id AC1196732D; Wed, 7 Jun 2023 14:18:50 +0200 (CEST) Date: Wed, 7 Jun 2023 14:18:50 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 30/31] block: store the holder in file->private_data Message-ID: <20230607121850.GA14396@lst.de> References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-31-hch@lst.de> <20230607-verjagen-weise-4fb3d76a6313@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230607-verjagen-weise-4fb3d76a6313@brauner> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_051854_289769_D6D87729 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote: > > Store the file struct used as the holder in file->private_data as an > > indicator that this file descriptor was opened exclusively to remove > > the last use of FMODE_EXCL. > > > > Signed-off-by: Christoph Hellwig > > --- > > Feels a bit odd to store the object itself but anyway, > Acked-by: Christian Brauner We could literally store anything we want. The only reason I picked the file is because: a) we have it around and b) that allows passing it to blkdev_put without a branch in blkdev_release. If you prefer something else I can change it. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um