From: Asmaa Mnebhi <asmaa@nvidia.com>
To: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Cc: Asmaa Mnebhi <asmaa@nvidia.com>, <netdev@vger.kernel.org>,
<cai.huoqing@linux.dev>, <brgl@bgdev.pl>,
<chenhao288@hisilicon.com>, <huangguangbin2@huawei.com>,
David Thompson <davthompson@nvidia.com>
Subject: [PATCH net v2 1/1] mlxbf_gige: Fix kernel panic at shutdown
Date: Wed, 7 Jun 2023 10:03:35 -0400 [thread overview]
Message-ID: <20230607140335.1512-1-asmaa@nvidia.com> (raw)
There is a race condition happening during shutdown due to pending napi transactions.
Since mlxbf_gige_poll is still running, it tries to access a NULL pointer and as a
result causes a kernel panic.
To fix this during shutdown, invoke mlxbf_gige_remove to disable and dequeue napi.
Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
.../net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
index 694de9513b9f..609d038b034e 100644
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
@@ -475,6 +475,9 @@ static int mlxbf_gige_remove(struct platform_device *pdev)
{
struct mlxbf_gige *priv = platform_get_drvdata(pdev);
+ if (!priv)
+ return 0;
+
unregister_netdev(priv->netdev);
phy_disconnect(priv->netdev->phydev);
mlxbf_gige_mdio_remove(priv);
@@ -485,10 +488,7 @@ static int mlxbf_gige_remove(struct platform_device *pdev)
static void mlxbf_gige_shutdown(struct platform_device *pdev)
{
- struct mlxbf_gige *priv = platform_get_drvdata(pdev);
-
- writeq(0, priv->base + MLXBF_GIGE_INT_EN);
- mlxbf_gige_clean_port(priv);
+ mlxbf_gige_remove(pdev);
}
static const struct acpi_device_id __maybe_unused mlxbf_gige_acpi_match[] = {
--
2.30.1
next reply other threads:[~2023-06-07 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:03 Asmaa Mnebhi [this message]
2023-06-08 23:25 ` [PATCH net v2 1/1] mlxbf_gige: Fix kernel panic at shutdown Samudrala, Sridhar
2023-06-12 17:26 ` Jakub Kicinski
2023-06-11 18:11 ` Leon Romanovsky
2023-06-12 11:34 ` Maciej Fijalkowski
2023-06-12 11:59 ` Leon Romanovsky
2023-06-12 12:37 ` Vladimir Oltean
2023-06-12 13:17 ` Leon Romanovsky
2023-06-12 13:28 ` Vladimir Oltean
2023-06-12 13:38 ` Leon Romanovsky
2023-06-12 14:05 ` Vladimir Oltean
2023-06-13 7:19 ` Leon Romanovsky
2023-06-13 8:30 ` Vladimir Oltean
2023-06-13 9:09 ` Leon Romanovsky
2023-06-13 9:35 ` Vladimir Oltean
2023-06-13 10:10 ` Leon Romanovsky
2023-06-13 10:34 ` Vladimir Oltean
2023-06-13 11:28 ` Leon Romanovsky
2023-06-13 11:40 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607140335.1512-1-asmaa@nvidia.com \
--to=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=cai.huoqing@linux.dev \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.