From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1q70mm-0006PN-3A for mharc-grub-devel@gnu.org; Wed, 07 Jun 2023 17:33:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q70mk-0006PE-NJ for grub-devel@gnu.org; Wed, 07 Jun 2023 17:33:42 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q70mg-0008U7-CX for grub-devel@gnu.org; Wed, 07 Jun 2023 17:33:42 -0400 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-53404873a19so4077319a12.3 for ; Wed, 07 Jun 2023 14:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686173616; x=1688765616; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4qArejVih73RVuJzblyk3uvpnJiHRSt/hQzGZxnh3Zs=; b=CnSxmi0DuOQFTaVHHp+Om64kAvHgc2f647WNP3WN3UFPIT/B9vhi7zli8hhAkF7Dod K1m8GUl5WeeQaeoDO7Smjxgvgji3Y5khV5sPJRN9xjgBcWdQBdMNwCxL7JJNwy0FVSdA 1bZaU11tmHxKjefKSMxhUBM643SMYei+xpNg8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686173616; x=1688765616; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4qArejVih73RVuJzblyk3uvpnJiHRSt/hQzGZxnh3Zs=; b=AjGoAJa/dNADdWywhbM0Ce/nadkDjonYT32+67RCyBiWbQ3XRk0Fe7dMj6gD7neaoQ tiTG+9tHwP4l5U9ocpr/kKTTkSqXuZRk+Ktpb0Rr/2+/xBegGtDvEYBf+PnmQiIOKIzC Ni5txAK8hcz2fPDmb/Fq57kRt9rH6MNHmVXCt4kohgz1jp7cx4ceUAZGKaduw2yIGTCG DAjleo0xFcAmIo95ctu0g48V8YyDLbwyjORjAZTothiEyVImckvgN0QqM6xHHaDyyKGJ YbToGUaS11upB+PMmaYhH6WDhnFQrOgjQJwbOX0m3WgqLBN15L0MYFrDCRzXLRqKlQPD Plbg== X-Gm-Message-State: AC+VfDy3OrwqPUWV/OOl3YUFUPqldZ7ixutWKyLpgQhEPIASOjnxBB21 tx2fCR/nljDFKzG+ZnhexVPo9Q== X-Google-Smtp-Source: ACHHUZ6NHC4rfsElJWk3U2ZaC3hPMHnm16kkriZm0NNY8xczkq/xcPv1vD9uYhLUEhuzbrVtp3rUaA== X-Received: by 2002:a17:903:2343:b0:1b1:b830:fea1 with SMTP id c3-20020a170903234300b001b1b830fea1mr4577659plh.48.1686173616382; Wed, 07 Jun 2023 14:33:36 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id m9-20020a17090a3f8900b0025645d118adsm1805430pjc.14.2023.06.07.14.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 14:33:36 -0700 (PDT) Date: Wed, 7 Jun 2023 14:33:35 -0700 From: Kees Cook To: Daniel Kiper Cc: Julian Andres Klode , The development of GNU GRUB Subject: Re: [PATCH] osdep/linux: Fix md array device enumeration Message-ID: <202306071432.A5D6F42@keescook> References: <20230606161020.2337550-1-julian.klode@canonical.com> <20230606161527.wlq4bhz7kg3qabpy@jak-t14-g3> <20230606170926.7lawabajepyppt7v@tomti.i.net-space.pl> <20230606172657.574yzsfgsq624k4i@jak-t14-g3> <20230607133924.4w6a3qietjlmnzdt@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230607133924.4w6a3qietjlmnzdt@tomti.i.net-space.pl> Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=keescook@chromium.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2023 21:33:43 -0000 On Wed, Jun 07, 2023 at 03:39:24PM +0200, Daniel Kiper wrote: > On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote: > > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode > > wrote: > > > > > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > > > > On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > > > > > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > > > [...] > > > > This patch is in upstream as commit c39f27cd6 (osdep/linux: Fix md array > > > > device enumeration). > > > > Oh good. I really thought it had landed already, so thanks for > > checking. I got worried this morning when I saw the email to > > grub-devel. :P "Wasn't that fixed already?" :) But thank you for > > making sure it hadn't gotten lost! Is there a way to close the tracker > > item for it? > > I think you should be able to do that. Ah-ha, yes, I've closed it now. :) https://salsa.debian.org/grub-team/grub/-/merge_requests/23 > > > > [...] > > > > I realized right now that MD_MAX_DISKS defined in commit c39f27cd6 > > > > (osdep/linux: Fix md array device enumeration) is not in sync with > > > > commit 2a5e3c1f2 (disk/diskfilter: Don't make a RAID array with more > > > > than 1024 disks). I think we should sync both numbers down to 1024... > > > > > > +1 > > > > Yeah, seems reasonable, though as I hinted in the original patch, this > > number appeared to have been arbitrarily chosen by mdadm at the time. > > OK, we will bump it to 4096 as well. Yeah, I think _technically_ it can be higher than 1024, though ... I struggle to imagine this for a boot device. ;) -- Kees Cook