From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: edward.cree@amd.com, linux-net-drivers@amd.com,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, habetsm.xilinx@gmail.com
Subject: Re: [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload
Date: Wed, 7 Jun 2023 16:00:40 -0700 [thread overview]
Message-ID: <20230607160040.412fd9b2@kernel.org> (raw)
In-Reply-To: <9f05ef7a-479c-05a6-e38b-f792034c7afd@gmail.com>
On Wed, 7 Jun 2023 21:51:35 +0100 Edward Cree wrote:
> Fair point. Guessing that applies to the netns reference as well?
Yes. I should add that to the checker..
> (Though looking back I honestly can't remember why we need to hold
> the neigh->net reference for the life of efx_neigh_binder; but I
> presumably had some reason for it at the time and I'm leery of
> removing it now in case it's load-bearing.
> Chesterton's Fence and all that.)
You don't seem to be doing much with the reference, just holding it.
Your call.
next prev parent reply other threads:[~2023-06-07 23:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 19:17 [PATCH net-next 0/6] sfc: TC encap actions offload edward.cree
2023-06-05 19:17 ` [PATCH net-next 1/6] sfc: add fallback action-set-lists for TC offload edward.cree
2023-06-06 10:10 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 2/6] sfc: some plumbing towards TC encap action offload edward.cree
2023-06-06 10:30 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 3/6] sfc: add function to atomically update a rule in the MAE edward.cree
2023-06-06 10:32 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 4/6] sfc: MAE functions to create/update/delete encap headers edward.cree
2023-06-06 10:44 ` Pieter Jansen van Vuuren
2023-06-05 19:17 ` [PATCH net-next 5/6] sfc: neighbour lookup for TC encap action offload edward.cree
2023-06-06 10:54 ` Pieter Jansen van Vuuren
2023-06-07 4:56 ` Jakub Kicinski
2023-06-07 20:51 ` Edward Cree
2023-06-07 23:00 ` Jakub Kicinski [this message]
2023-06-07 8:34 ` Simon Horman
2023-06-05 19:17 ` [PATCH net-next 6/6] sfc: generate encap headers for TC offload edward.cree
2023-06-06 3:52 ` Hao Lan
2023-06-06 15:03 ` Edward Cree
2023-06-06 15:23 ` Hao Lan
2023-06-06 11:02 ` Pieter Jansen van Vuuren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607160040.412fd9b2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.