All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krister Johansen <kjlx@templeofstupid.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Krister Johansen <kjlx@templeofstupid.com>, linux-ext4@vger.kernel.org
Subject: Re: [e2fsprogs PATCH] resize2fs: use directio when reading superblock
Date: Wed, 7 Jun 2023 11:50:41 -0700	[thread overview]
Message-ID: <20230607185041.GA2023@templeofstupid.com> (raw)
In-Reply-To: <20230607133909.GA1309044@mit.edu>

On Wed, Jun 07, 2023 at 09:39:09AM -0400, Theodore Ts'o wrote:
> On Mon, Jun 05, 2023 at 03:52:21PM -0700, Krister Johansen wrote:
> > Invocations of resize2fs intermittently report failure due to superblock
> > checksum mismatches in this author's environment.  This might happen a few
> > times a week.  The following script can make this happen within minutes.
> > (It assumes /dev/nvme1n1 is available and not in use by anything else).
> 
> What version of e2fsprogs are you using, and what is your environment?

I hit this originally using e2fsprogs 1.45.5.  That didn't have your
patch for retrying the superblock read on checksum failure.  I pulled
that patch in initially, but it did not fully resolve the checksum
mismatch error.  The test provided in the report was using an EBS volume
attached to an EC2 instance.  (Let me know what additional environment
details would be useful, if these are not).

> Are you perhaps trying to change the UUID of the file system (for
> example, in a cloud image environment) in parallel with resizing the
> file system to fit the size of the block device?

The growpart / resize2fs in the reproducer are essentially verbatim from
our system provisioning scripts.  Unless those modify the UUID, we're
not taking any explicit action to do so.

Thanks,

-K

  reply	other threads:[~2023-06-07 18:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 22:52 [e2fsprogs PATCH] resize2fs: use directio when reading superblock Krister Johansen
2023-06-07 13:39 ` Theodore Ts'o
2023-06-07 18:50   ` Krister Johansen [this message]
2023-06-09  4:22     ` Theodore Ts'o
2023-06-10  2:11       ` Krister Johansen
2023-06-28 23:02         ` Krister Johansen
2023-08-17  0:37           ` Krister Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607185041.GA2023@templeofstupid.com \
    --to=kjlx@templeofstupid.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.