From: Rishabh Bhatnagar <risbhat@amazon.com>
To: <gregkh@linuxfoundation.org>
Cc: <sfrench@amazon.com>, <stable@vger.kernel.org>,
<linux-cifs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Paulo Alcantara <pc@cjr.nz>, Aurelien Aptel <aaptel@suse.com>,
Steve French <stfrench@microsoft.com>,
Rishabh Bhatnagar <risbhat@amazon.com>
Subject: [PATCH v2 5.4 1/2] cifs: get rid of unused parameter in reconn_setup_dfs_targets()
Date: Wed, 7 Jun 2023 20:33:32 +0000 [thread overview]
Message-ID: <20230607203333.26669-2-risbhat@amazon.com> (raw)
In-Reply-To: <20230607203333.26669-1-risbhat@amazon.com>
From: Paulo Alcantara <pc@cjr.nz>
commit baf3f08ef4083b76ca67b143e135213a7f941879 upstream.
The target iterator parameter "it" is not used in
reconn_setup_dfs_targets(), so just remove it.
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Rishabh Bhatnagar <risbhat@amazon.com>
---
fs/cifs/connect.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 6c8dd7c0b83a..b5cd3dc479ce 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -469,8 +469,7 @@ static void reconn_inval_dfs_target(struct TCP_Server_Info *server,
}
static inline int reconn_setup_dfs_targets(struct cifs_sb_info *cifs_sb,
- struct dfs_cache_tgt_list *tl,
- struct dfs_cache_tgt_iterator **it)
+ struct dfs_cache_tgt_list *tl)
{
if (!cifs_sb->origin_fullpath)
return -EOPNOTSUPP;
@@ -515,7 +514,7 @@ cifs_reconnect(struct TCP_Server_Info *server)
} else {
cifs_sb = CIFS_SB(sb);
- rc = reconn_setup_dfs_targets(cifs_sb, &tgt_list, &tgt_it);
+ rc = reconn_setup_dfs_targets(cifs_sb, &tgt_list);
if (rc && (rc != -EOPNOTSUPP)) {
cifs_server_dbg(VFS, "%s: no target servers for DFS failover\n",
__func__);
--
2.39.2
next prev parent reply other threads:[~2023-06-07 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 20:33 [PATCH v2 5.4 0/2] Backport few dfs related fixes to cifs Rishabh Bhatnagar
2023-06-07 20:33 ` Rishabh Bhatnagar [this message]
2023-06-07 20:33 ` [PATCH v2 5.4 2/2] cifs: handle empty list of targets in cifs_reconnect() Rishabh Bhatnagar
2023-06-08 20:54 ` [PATCH v2 5.4 0/2] Backport few dfs related fixes to cifs Paulo Alcantara
2023-06-12 9:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607203333.26669-2-risbhat@amazon.com \
--to=risbhat@amazon.com \
--cc=aaptel@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=sfrench@amazon.com \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.