From: Rob Herring <robh@kernel.org>
To: "Leonard Göhrs" <l.goehrs@pengutronix.de>
Cc: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties
Date: Wed, 7 Jun 2023 17:03:15 -0600 [thread overview]
Message-ID: <20230607230315.GA141591-robh@kernel.org> (raw)
In-Reply-To: <20230607115508.2964574-4-l.goehrs@pengutronix.de>
On Wed, Jun 07, 2023 at 01:55:03PM +0200, Leonard Göhrs wrote:
> The termination-gpios property allows specifying a GPIO pin that
> enables/disables a termination resistor on said CAN interface.
> The termination-ohms property specifies the resistance of said resistor.
>
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index 67879aab623b5..106c79fa560c3 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -118,6 +118,9 @@ properties:
> phys:
> maxItems: 1
>
> + termination-gpios: true
> + termination-ohms: true
All you should need here is change additionalProperties to
unevaluatedProperties as these are defined by can-controller.yaml.
> +
> required:
> - compatible
> - reg
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-06-07 23:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 11:55 [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible Leonard Göhrs
2023-06-07 11:55 ` Leonard Göhrs
2023-06-07 11:55 ` [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property Leonard Göhrs
2023-06-07 11:55 ` Leonard Göhrs
2023-06-07 17:54 ` Conor Dooley
2023-06-07 17:54 ` Conor Dooley
2023-06-07 19:59 ` Noralf Trønnes
2023-06-07 19:59 ` Noralf Trønnes
2023-06-07 22:58 ` Rob Herring
2023-06-07 22:58 ` Rob Herring
2023-06-07 22:59 ` Rob Herring
2023-06-07 22:59 ` Rob Herring
2023-06-07 11:55 ` [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property Leonard Göhrs
2023-06-07 16:36 ` andy.shevchenko
2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-13 14:54 ` Bartosz Golaszewski
2023-06-07 11:55 ` [PATCH v1 4/8] dt-bindings: can: m_can: add termination-{gpios,ohms} properties Leonard Göhrs
2023-06-07 17:51 ` Conor Dooley
2023-06-07 23:03 ` Rob Herring [this message]
2023-06-07 11:55 ` [PATCH v1 5/8] dt-bindings: net: dsa: microchip: add missing spi-{cpha,cpol} properties Leonard Göhrs
2023-06-07 17:50 ` Conor Dooley
2023-06-07 23:04 ` Rob Herring
2023-06-07 11:55 ` [PATCH v1 6/8] ARM: dts: stm32: Add pinmux groups for Linux Automation GmbH TAC Leonard Göhrs
2023-06-07 11:55 ` Leonard Göhrs
2023-06-08 13:02 ` Alexandre TORGUE
2023-06-08 13:02 ` Alexandre TORGUE
2023-06-07 11:55 ` [PATCH v1 7/8] dt-bindings: arm: stm32: Add compatible string for Linux Automation LXA TAC Leonard Göhrs
2023-06-07 11:55 ` Leonard Göhrs
2023-06-07 17:29 ` Conor Dooley
2023-06-07 17:29 ` Conor Dooley
2023-06-07 11:55 ` [PATCH v1 8/8] ARM: dts: stm32: lxa-tac: add Linux Automation GmbH TAC Leonard Göhrs
2023-06-07 11:55 ` Leonard Göhrs
2023-06-08 13:13 ` Alexandre TORGUE
2023-06-08 13:13 ` Alexandre TORGUE
2023-06-14 12:46 ` Leonard Göhrs
2023-06-14 12:46 ` Leonard Göhrs
2023-06-07 17:55 ` [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible Conor Dooley
2023-06-07 17:55 ` Conor Dooley
2023-06-07 22:59 ` Rob Herring
2023-06-07 22:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607230315.GA141591-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=l.goehrs@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.