From: Damien Le Moal <dlemoal@kernel.org>
To: ltp <ltp@lists.linux.it>, Linus Walleij <linus.walleij@linaro.org>
Cc: Niklas Cassel <niklas.cassel@wdc.com>
Subject: [LTP] [PATCH v2 0/2] Improve ioprio tests
Date: Thu, 8 Jun 2023 09:53:13 +0900 [thread overview]
Message-ID: <20230608005315.3703446-1-dlemoal@kernel.org> (raw)
The ioprio syscall tests rely on ltp internal definitions of the
IOPRIO_XXX() macro defining priority classes and levels. With changes
to the ioprio API to support command duration limits, these internal
definitions are incomplete, causing test case ioprio_set03 to fail.
Avoid this issue by having the iprio tests use the kernel header file
definitions if that header exists. This enables additional checks in
the header file [1] which restores the expected results with test
ioprio_set03.
[1] https://lore.kernel.org/linux-block/20230530061307.525644-1-dlemoal@kernel.org/
Note: a review of this patch on the kernel block mailing list would be
very appreciated.
Changes from v1:
- Added Linus's review tag
- Resend with being subscribed to ltp list this time :)
Damien Le Moal (2):
ioprio: use ioprio.h kernel header if it exists
ioprio: Use IOPRIO_PRIO_NUM to check prio range
configure.ac | 1 +
testcases/kernel/syscalls/ioprio/ioprio.h | 33 ++++++++++++++-----
.../kernel/syscalls/ioprio/ioprio_set03.c | 2 +-
3 files changed, 26 insertions(+), 10 deletions(-)
--
2.40.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2023-06-08 0:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 0:53 Damien Le Moal [this message]
2023-06-08 0:53 ` [LTP] [PATCH v2 1/2] ioprio: use ioprio.h kernel header if it exists Damien Le Moal
2023-06-20 10:14 ` Petr Vorel
2023-06-20 13:01 ` Damien Le Moal
2023-06-20 18:52 ` Linus Walleij
2023-06-08 0:53 ` [LTP] [PATCH v2 2/2] ioprio: Use IOPRIO_PRIO_NUM to check prio range Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608005315.3703446-1-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=ltp@lists.linux.it \
--cc=niklas.cassel@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.