From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Jadav, Raag" <raag.jadav@intel.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>,
"N, Pandith" <pandith.n@intel.com>
Subject: Re: [PATCH v1 1/4] pinctrl: intel: optimize set_mux hook
Date: Thu, 8 Jun 2023 13:56:34 +0300 [thread overview]
Message-ID: <20230608105634.GL45886@black.fi.intel.com> (raw)
In-Reply-To: <DM6PR11MB2779B6863DA4A390EC68F4978C50A@DM6PR11MB2779.namprd11.prod.outlook.com>
On Thu, Jun 08, 2023 at 10:20:58AM +0000, Jadav, Raag wrote:
> > On Thu, Jun 08, 2023 at 12:30:14PM +0530, Raag Jadav wrote:
> > > Utilize a temporary variable for common shift operation inside
> > > ->set_mux() hook and save a few bytes.
> > >
> > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
> > > Function old new delta
> > > intel_pinmux_set_mux 245 242 -3
> > > Total: Before=10472, After=10469, chg -0.03%
> >
> > Shouldn't the compiler be able to optimize this if you ask with the -Ox
> > options?
>
> Forgot to add. This is with default -O2.
> Is it a good idea to mention it?
Yes, I think it is.
next prev parent reply other threads:[~2023-06-08 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:00 [PATCH v1 0/4] Minor optimizations for Intel pinctrl Raag Jadav
2023-06-08 7:00 ` [PATCH v1 1/4] pinctrl: intel: optimize set_mux hook Raag Jadav
2023-06-08 8:08 ` Mika Westerberg
2023-06-08 10:20 ` Jadav, Raag
2023-06-08 10:56 ` Mika Westerberg [this message]
2023-06-08 7:00 ` [PATCH v1 2/4] pinctrl: intel: optimize irq_set_type hook Raag Jadav
2023-06-08 7:00 ` [PATCH v1 3/4] pinctrl: intel: simplify exit path of set_mux hook Raag Jadav
2023-06-08 8:09 ` Mika Westerberg
2023-06-08 7:00 ` [PATCH v1 4/4] pinctrl: intel: simplify exit path of gpio_request_enable hook Raag Jadav
2023-06-08 8:10 ` Mika Westerberg
2023-06-08 14:30 ` [PATCH v1 0/4] Minor optimizations for Intel pinctrl Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608105634.GL45886@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=pandith.n@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.