From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE667C7EE29 for ; Thu, 8 Jun 2023 18:03:18 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 3E33626A32 for ; Thu, 8 Jun 2023 18:03:18 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 258FE98669F for ; Thu, 8 Jun 2023 18:03:18 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 1B6D698667A; Thu, 8 Jun 2023 18:03:18 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 09B6B98667E for ; Thu, 8 Jun 2023 18:03:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: iricW2i5OTCPD9l56YyOQw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686247386; x=1688839386; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IkzOGhZ5dCW376oaGomicjqWXldPf++3zoj0rPxwfyY=; b=d71vWmyHUGSAVmSWvCHn5ZuekgILPMM6ri9rF3MH4BJeuzAByVpAdKg/bo4ae4KfuF OYQoVKqSI3MygQ88fefiQRcHpDeQ7DGmgMDR+m3lxUROPJdst8rm+Q7STcOavUwvIOpo 8gapgIZyPknQrS6XGQj+dqzSdJMJlh0NYkp54mY72kIpoYsafOsfFpDCf82TMEyZHu3q kIfcEuW2dyz6pPBHc3mLuSfbW9B+7FvnxFd1+2UEe6mTNG5l2ymbRVasBCTJ5WlP09RS aTDHGq55JS/CuH1cCzJF6R9A1jEwZYvRPxcCPjK7kUl1na+33NwDuaNv37YBYogCJg7L T6iA== X-Gm-Message-State: AC+VfDxnOoOA7hpsPhGNjqSp5TJD2P8Li4pYliURQvvCXmdEYpMoq8km I7h06+PClEGigaHWhE+RMuP55UhFNKyeTjNntUiNW4I5xsQoHBqHJ0MSwBL32BaXVSBMrnMcIEc touw5fbI61QbuODDZjiVDrrtPWZmp4lLplQ== X-Received: by 2002:adf:ce8d:0:b0:307:9194:9a94 with SMTP id r13-20020adfce8d000000b0030791949a94mr7774980wrn.17.1686247385898; Thu, 08 Jun 2023 11:03:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70mcRsXyaQWfXTi8WoOINLAbIKun+S4h4PZQ+LJRJrLZtf7D+ixkXZpUk2fsucQDncqY1rZQ== X-Received: by 2002:adf:ce8d:0:b0:307:9194:9a94 with SMTP id r13-20020adfce8d000000b0030791949a94mr7774966wrn.17.1686247385556; Thu, 08 Jun 2023 11:03:05 -0700 (PDT) Date: Thu, 8 Jun 2023 14:03:01 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Jason Wang , "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "sburla@marvell.com" , Yishai Hadas , Maor Gottlieb , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler Message-ID: <20230608140013-mutt-send-email-mst@kernel.org> References: <20230606073544-mutt-send-email-mst@kernel.org> <20230608104215-mutt-send-email-mst@kernel.org> <20230608105640-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-comment] Re: [virtio-dev] Re: [PATCH v3 0/3] transport-pci: Introduce legacy registers access using AQ On Thu, Jun 08, 2023 at 03:16:02PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, June 8, 2023 11:04 AM > > > > On Thu, Jun 08, 2023 at 02:53:28PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Thursday, June 8, 2023 10:44 AM > > > > > Since this ABI reflects what we agree on, I would want to raise > > > > > for vote in coming days to be part of 1.3 in few days as we have > > > > > more than 3 > > > > weeks to sort out non-ABI language part. > > > > > > > > I think there's a bunch of work to tighten wording in v4, don't > > > > believe it is ready for vote yet. > > > 3rd patch has the conformance section. > > > Rest of the legacy interface semantics are just same as today. > > > We are not fixing the legacy interface itself, so not sure what to tighten > > specifically. > > > > I'll do a proper review after the forum. Generally lots of small things. Went > > looking just to give you a couple of > > examples: > > too many mentions of VFs and PFs. > > text should talk about owner and member. Minimise > > mention of VFs to make it easier to extend to > > different group types. > > > True but most additions are in PCI transport chapter. > But will change to member and owner. > > > another example: > > +The PCI VF device SHOULD NOT expose PCI BAR 0 when it prefers to > > support > > > > VFs don't expose BARs at all. PF exposes VF BARs in SRIOV capability. > > > Yes, it is exposed by PF, the wording of "PCI VF device exposing" is not right. > I will reword it. Note that this will then apply to all VFs of this PF, even those without legacy support. Still not sure why it's SHOULD not a MUST. So that driver actually checks, but it's ok to fail if the rule is not followed maybe? In that case add a driver normative statement too. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4403DC7EE23 for ; Thu, 8 Jun 2023 18:03:11 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 54F502AD4E for ; Thu, 8 Jun 2023 18:03:10 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 30E96986687 for ; Thu, 8 Jun 2023 18:03:10 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 191D398667A; Thu, 8 Jun 2023 18:03:10 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 05E9A98667B for ; Thu, 8 Jun 2023 18:03:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: yEN5xlyVMiWtqKjqzAZkGg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686247386; x=1688839386; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IkzOGhZ5dCW376oaGomicjqWXldPf++3zoj0rPxwfyY=; b=C0Vcd9VENwImUJ480sl/7i5Hyf8+Z2ifKwpuZ9CrTnpFw6cdpGQzqNU19rC/OaoiS1 KJtA7Ez4oBpb3EYgv+hsDBC2KQXIwQA0dED7WdkXHSIu0kaVz7baA8Ge7LTw2tjmBV4M JPiWLsaVR5JXnwW+qe775mCPZjHvZsC9fXODPakJkhphcoBgHNq6Ldm3cSqy3YLjsOu7 BGqszpnSrxpEcpLSbmfSc6fyMfD+Cp+yPPLv8O9cJU97ufV44pu6rWgbC7Jr72zDLqjo W/ylb+ed5G7vg4U9zJF/hTcUldIKbA5wqrHEw0Ht6QP2Z/5YoFv/3ESDIB9THYnPEofE wXig== X-Gm-Message-State: AC+VfDyio3nw0F9R9bzlncxUpBk1KdgtAWekZxXO7uBV6BJ9uHW71AJT zQzgcF41Mlp0DgywDfGUw1jybLvdEI7JstaSiuI1/IQd35qwSrTgpyOsEwlnSAFju6oVNGHErRn 6rnEdWQr/UN6aficMGbPB9q9xHhOR X-Received: by 2002:adf:ce8d:0:b0:307:9194:9a94 with SMTP id r13-20020adfce8d000000b0030791949a94mr7774981wrn.17.1686247385898; Thu, 08 Jun 2023 11:03:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70mcRsXyaQWfXTi8WoOINLAbIKun+S4h4PZQ+LJRJrLZtf7D+ixkXZpUk2fsucQDncqY1rZQ== X-Received: by 2002:adf:ce8d:0:b0:307:9194:9a94 with SMTP id r13-20020adfce8d000000b0030791949a94mr7774966wrn.17.1686247385556; Thu, 08 Jun 2023 11:03:05 -0700 (PDT) Date: Thu, 8 Jun 2023 14:03:01 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Jason Wang , "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "sburla@marvell.com" , Yishai Hadas , Maor Gottlieb , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler Message-ID: <20230608140013-mutt-send-email-mst@kernel.org> References: <20230606073544-mutt-send-email-mst@kernel.org> <20230608104215-mutt-send-email-mst@kernel.org> <20230608105640-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-dev] Re: [PATCH v3 0/3] transport-pci: Introduce legacy registers access using AQ On Thu, Jun 08, 2023 at 03:16:02PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, June 8, 2023 11:04 AM > > > > On Thu, Jun 08, 2023 at 02:53:28PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Thursday, June 8, 2023 10:44 AM > > > > > Since this ABI reflects what we agree on, I would want to raise > > > > > for vote in coming days to be part of 1.3 in few days as we have > > > > > more than 3 > > > > weeks to sort out non-ABI language part. > > > > > > > > I think there's a bunch of work to tighten wording in v4, don't > > > > believe it is ready for vote yet. > > > 3rd patch has the conformance section. > > > Rest of the legacy interface semantics are just same as today. > > > We are not fixing the legacy interface itself, so not sure what to tighten > > specifically. > > > > I'll do a proper review after the forum. Generally lots of small things. Went > > looking just to give you a couple of > > examples: > > too many mentions of VFs and PFs. > > text should talk about owner and member. Minimise > > mention of VFs to make it easier to extend to > > different group types. > > > True but most additions are in PCI transport chapter. > But will change to member and owner. > > > another example: > > +The PCI VF device SHOULD NOT expose PCI BAR 0 when it prefers to > > support > > > > VFs don't expose BARs at all. PF exposes VF BARs in SRIOV capability. > > > Yes, it is exposed by PF, the wording of "PCI VF device exposing" is not right. > I will reword it. Note that this will then apply to all VFs of this PF, even those without legacy support. Still not sure why it's SHOULD not a MUST. So that driver actually checks, but it's ok to fail if the rule is not followed maybe? In that case add a driver normative statement too. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org