From: Lee Jones <lee@kernel.org>
To: Jerome Neanne <jneanne@baylibre.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com, nm@ti.com,
afd@ti.com, msp@baylibre.com
Subject: Re: [RESEND PATCH v3] mfd: tps65219: Add support for soft shutdown via sys-off API
Date: Thu, 8 Jun 2023 16:57:09 +0100 [thread overview]
Message-ID: <20230608155709.GA3572061@google.com> (raw)
In-Reply-To: <20230608071947.3467751-1-jneanne@baylibre.com>
On Thu, 08 Jun 2023, Jerome Neanne wrote:
> Use new API for power-off mode support:
> Link: https://lwn.net/Articles/894511/
> Link: https://lore.kernel.org/all/7hfseqa7l0.fsf@baylibre.com/
>
> sys-off API allows support of shutdown handler and restart handler.
>
> Shutdown was not supported before that enhancement.
> This is required for platform that are not using PSCI.
>
> Test:
> - restart:
> # reboot
> Default is cold reset:
> # cat /sys/kernel/reboot/mode
> Switch boot mode to warm reset:
> # echo warm > /sys/kernel/reboot/mode
> - power-off:
> # halt
>
> Tested on AM62-LP-SK board.
>
> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
> Suggested-by: Andrew Davis <afd@ti.com>
> Reviewed-by: Andrew Davis <afd@ti.com>
> ---
>
> Notes:
> Change-log v3 to v2
> v2: Link: https://lore.kernel.org/lkml/20230511122100.2225417-1-jneanne@baylibre.com/
> Lee Jones Review:
> nits: rm not needed line wraps and restore a cr deleted not related with the patch.
>
> Change-log v2 to v1
> v1: Link: https://lore.kernel.org/all/20230203140150.13071-1-jneanne@baylibre.com/
> Andrew Davis Review:
> - Use new helpers devm_register_restart_handler and devm_register_power_off_handler
> Vignesh Raghavendra:
> - Fix typo on board name in commit message
>
> drivers/mfd/tps65219.c | 38 ++++++++++++++++++++++++++++----------
> 1 file changed, 28 insertions(+), 10 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-08 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:19 [RESEND PATCH v3] mfd: tps65219: Add support for soft shutdown via sys-off API Jerome Neanne
2023-06-08 15:57 ` Lee Jones [this message]
2024-11-15 8:15 ` Sverdlin, Alexander
2024-11-15 10:03 ` Sverdlin, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608155709.GA3572061@google.com \
--to=lee@kernel.org \
--cc=afd@ti.com \
--cc=jneanne@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.