All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Florian Westphal <fw@strlen.de>,
	netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com,
	davem@davemloft.net, pabeni@redhat.com, xiyou.wangcong@gmail.com,
	jiri@resnulli.us
Subject: Re: [PATCH net v2 0/3] net/sched: act_ipt bug fixes
Date: Thu, 8 Jun 2023 20:36:36 +0200	[thread overview]
Message-ID: <20230608183636.GG27126@breakpoint.cc> (raw)
In-Reply-To: <CAM0EoMmcgoTbneB+JYt_oUKwsFMiA7xsuCWA=epr=mZnzhaX6w@mail.gmail.com>

Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On Thu, Jun 8, 2023 at 10:03 AM Florian Westphal <fw@strlen.de> wrote:
> > I think that we should consider removal of this module, while
> > this should take care of all problems, its ipv4 only and I don't
> > think there are any netfilter targets that lack a native tc
> > equivalent, even when ignoring bpf.
> >
> 
> I am all for removing it - but i am worried there are users based on
> past interactions. Will try to ping some users and see if they
> actually were using it.

Thanks Jamal.  I'd also be interested in what xt module(s) are used,
if any.

> I will send a patch to retire it if it looks
> safe.

Thanks.

      reply	other threads:[~2023-06-08 18:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 14:02 [PATCH net v2 0/3] net/sched: act_ipt bug fixes Florian Westphal
2023-06-08 14:02 ` [PATCH net v2 1/3] net/sched: act_ipt: add sanity checks on table name and hook locations Florian Westphal
2023-06-08 16:51   ` Jamal Hadi Salim
2023-06-08 14:02 ` [PATCH net v2 2/3] net/sched: act_ipt: add sanity checks on skb before calling target Florian Westphal
2023-06-08 15:04   ` Davide Caratti
2023-06-08 18:34     ` Florian Westphal
2023-06-09 12:44       ` Davide Caratti
2023-06-08 17:08   ` Jamal Hadi Salim
2023-06-08 14:02 ` [PATCH net v2 3/3] net/sched: act_ipt: zero skb->cb " Florian Westphal
2023-06-08 17:05   ` Jamal Hadi Salim
2023-06-08 18:28     ` Florian Westphal
2023-06-09 11:58       ` Jamal Hadi Salim
2023-06-08 16:50 ` [PATCH net v2 0/3] net/sched: act_ipt bug fixes Jamal Hadi Salim
2023-06-08 18:36   ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608183636.GG27126@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.