From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 352E0C7EE29 for ; Fri, 9 Jun 2023 05:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237922AbjFIF6G (ORCPT ); Fri, 9 Jun 2023 01:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236735AbjFIF5u (ORCPT ); Fri, 9 Jun 2023 01:57:50 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 950033580 for ; Thu, 8 Jun 2023 22:57:44 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-33e4e59da95so6426725ab.2 for ; Thu, 08 Jun 2023 22:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686290263; x=1688882263; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=++2Zj1omCLLppu446gvNENuVYrBxM0BkVm2pcONPHCw=; b=mJEksCrESHsJiex1or4mBAdTqS8mtSQXqx32WSM0EtiLydQdkeHaajbo2P1enf/Cdn edR1ScgCRG7tUAhcANwXFfbPbctS63b2XcPB+5i5urD4A0q6IVqEnEoJOdYZv0+LIz8w FVwJVbvpzk70BJ3yRMy08Y6qNeOIaIcohuVUfi5Yq8YcEJSowC0nOXR7jkGxEsrijIjQ o2tCkl6kM9/vKV3KhABhJPzBLgtFcJCRATEBUkBsirD0Mdj1pPsKywUwKtzNZneAhKaP +8jcAybypAjdMf81gHzS0yfIgS0zCw5TlKomlFBCGXy5lqY1jDgbwNXRHBostzpaTkQe 0jSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686290263; x=1688882263; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=++2Zj1omCLLppu446gvNENuVYrBxM0BkVm2pcONPHCw=; b=I1GEF+Gy9YE/oHeHb+H6ubKZczp46Ub06gP/pHS3KPG+F+r7o5GoNzHppgK48oUWXl 9G5LKtSP4s5qwbrMQDhnD16ri4vq81AMGKvTIb1/+swJTd98KANGwlKEomjz1wictMUm bOmRq30cdBpkAzrtMjI/AVBZ79DOoec2f+F/bhGz8qQhEOIe+Xez9xTFbpNOsikE7EW7 bKVoMzUVwXsaAK49j1VfQaW0jT8T1JQj1cfPFZLYSac3aujOW6XrPjbJ2ZdbvRceRakT 3VkyCGwEGv9wUkEkZTA8JE1FUhGMruId55mOyRaYCvcPaCBz2KinUevgWlJaknygPPTG DVgA== X-Gm-Message-State: AC+VfDzKHply7dznMff9VkYYNOjvqVAB4loSwddWr2MlERHEOofk9Y4r z7r8j/c2IWzHiNNUGgCRhxSd X-Google-Smtp-Source: ACHHUZ6GJJrdYE1QiP/Ozdl2rWOQLC5T3Eor5qKvghiCVz8mJ5Y0d+6D5hPCUlbt+nEN01EpI+suhg== X-Received: by 2002:a92:cbd2:0:b0:338:18f1:db72 with SMTP id s18-20020a92cbd2000000b0033818f1db72mr696567ilq.29.1686290263599; Thu, 08 Jun 2023 22:57:43 -0700 (PDT) Received: from thinkpad ([117.202.186.138]) by smtp.gmail.com with ESMTPSA id e15-20020aa7824f000000b0063b96574b8bsm1888925pfn.220.2023.06.08.22.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 22:57:43 -0700 (PDT) Date: Fri, 9 Jun 2023 11:27:37 +0530 From: Manivannan Sadhasivam To: Siddharth Vadapalli Cc: tjoseph@cadence.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, nadeem@cadence.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com, nm@ti.com Subject: Re: [PATCH v3] PCI: cadence: Fix Gen2 Link Retraining process Message-ID: <20230609055737.GA6847@thinkpad> References: <20230607091427.852473-1-s-vadapalli@ti.com> <20230608154206.GI5672@thinkpad> <67865af6-7ea4-63e3-6c35-4cd038f36af3@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67865af6-7ea4-63e3-6c35-4cd038f36af3@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 09, 2023 at 09:46:20AM +0530, Siddharth Vadapalli wrote: > Hello Mani, > > Thank you for reviewing this patch. > > On 08/06/23 21:12, Manivannan Sadhasivam wrote: > > On Wed, Jun 07, 2023 at 02:44:27PM +0530, Siddharth Vadapalli wrote: > >> The Link Retraining process is initiated to account for the Gen2 defect in > >> the Cadence PCIe controller in J721E SoC. The errata corresponding to this > >> is i2085, documented at: > >> https://www.ti.com/lit/er/sprz455c/sprz455c.pdf > >> > >> The existing workaround implemented for the errata waits for the Data Link > >> initialization to complete and assumes that the link retraining process > >> at the Physical Layer has completed. However, it is possible that the > >> Physical Layer training might be ongoing as indicated by the > >> PCI_EXP_LNKSTA_LT bit in the PCI_EXP_LNKSTA register. > >> > >> Fix the existing workaround, to ensure that the Physical Layer training > >> has also completed, in addition to the Data Link initialization. > >> > > > > cdns_pcie_host_wait_for_link() function is called even for the non-quirky cases > > as well, so does this patch. But if your patch is only targeting the link > > retraining case, you should move the logic to cdns_pcie_retrain(). > > In the v2 version of this patch at: > https://lore.kernel.org/r/20230315070800.1615527-1-s-vadapalli@ti.com/ > I had implemented it as suggested above by you. However, based on the discussion > with Bjorn at: > https://lore.kernel.org/r/20230509182416.GA1259841@bhelgaas/ > it was agreed upon that waiting for two things in succession doesn't seem to be > the best way to implement it. Therefore, the cdns_pcie_host_training_complete() > function in the v2 patch is merged into the cdns_pcie_host_wait_for_link() > function in this patch. > I think Bjorn's point was to make the wait_for_link() behavior same across drivers. While I agree with that, I'd like to know whether adding this wait for all cases (not just during link retraining quirk) adds up any latency or not. Can you measure that? > > > > > >> Fixes: 4740b969aaf5 ("PCI: cadence: Retrain Link to work around Gen2 training defect") > >> Signed-off-by: Siddharth Vadapalli > >> Reviewed-by: Vignesh Raghavendra > >> --- > >> > >> Hello, > >> > >> This patch is based on linux-next tagged next-20230606. > >> > >> v2: > >> https://lore.kernel.org/r/20230315070800.1615527-1-s-vadapalli@ti.com/ > >> Changes since v2: > >> - Merge the cdns_pcie_host_training_complete() function with the > >> cdns_pcie_host_wait_for_link() function, as suggested by Bjorn > >> for the v2 patch. > >> - Add dev_err() to notify when Link Training fails, since this is a > >> fatal error and proceeding from this point will almost always crash > >> the kernel. > >> > >> v1: > >> https://lore.kernel.org/r/20230102075656.260333-1-s-vadapalli@ti.com/ > >> Changes since v1: > >> - Collect Reviewed-by tag from Vignesh Raghavendra. > >> - Rebase on next-20230315. > >> > >> Regards, > >> Siddharth. > >> > >> .../controller/cadence/pcie-cadence-host.c | 20 +++++++++++++++++++ > >> 1 file changed, 20 insertions(+) > >> > >> diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c > >> index 940c7dd701d6..70a5f581ff4f 100644 > >> --- a/drivers/pci/controller/cadence/pcie-cadence-host.c > >> +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c > >> @@ -12,6 +12,8 @@ > >> > >> #include "pcie-cadence.h" > >> > >> +#define LINK_RETRAIN_TIMEOUT HZ > >> + > >> static u64 bar_max_size[] = { > >> [RP_BAR0] = _ULL(128 * SZ_2G), > >> [RP_BAR1] = SZ_2G, > >> @@ -80,8 +82,26 @@ static struct pci_ops cdns_pcie_host_ops = { > >> static int cdns_pcie_host_wait_for_link(struct cdns_pcie *pcie) > >> { > >> struct device *dev = pcie->dev; > >> + unsigned long end_jiffies; > >> + u16 link_status; > >> int retries; > >> > >> + /* Wait for link training to complete */ > >> + end_jiffies = jiffies + LINK_RETRAIN_TIMEOUT; > >> + do { > >> + link_status = cdns_pcie_rp_readw(pcie, CDNS_PCIE_RP_CAP_OFFSET + PCI_EXP_LNKSTA); > >> + if (!(link_status & PCI_EXP_LNKSTA_LT)) > >> + break; > >> + usleep_range(0, 1000); > >> + } while (time_before(jiffies, end_jiffies)); > >> + > >> + if (!(link_status & PCI_EXP_LNKSTA_LT)) { > >> + dev_info(dev, "Link training complete\n"); > > > > This info is not needed. > > Sure. I will drop it in the v4 patch. > > > > >> + } else { > >> + dev_err(dev, "Fatal! Link training incomplete\n"); > > > > This could be, "Link retraining incomplete". > > I added the word "Fatal" since Linux is almost always guaranteed to crash if the > link training doesn't complete before the PCI subsystem attempts to enumerate > the EP devices. Therefore, adding the word "Fatal" will help the users identify > what the cause of the crash is, which would otherwise be overlooked, unless the > critical nature of this error is conveyed to the user. > Ok. - Mani > > > > - Mani > > > >> + return -ETIMEDOUT; > >> + } > >> + > >> /* Check if the link is up or not */ > >> for (retries = 0; retries < LINK_WAIT_MAX_RETRIES; retries++) { > >> if (cdns_pcie_link_up(pcie)) { > >> -- > >> 2.25.1 > >> > > > > -- > Regards, > Siddharth. -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6070EC7EE29 for ; Fri, 9 Jun 2023 05:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PkQhah05nku4GkKaxv8TFmWrgq2atYAe+2MO3UMDIYI=; b=zL831wj4HelQIk THN8Mwjn4WnT3bdfUqyF+rdWd5UUgEEYODBrraH//uS3kjVqrfXzlVMFbWX6uqjD/SKlYpOKGmwfW fZMPUFoUz/ss68tB9mcqf/ck4rC6vQNAcr7KFhVYZ7fmaQwpn57avKV8d8bUJ4ZHn9C3sLy34tLml h4VVFJ2EKynyH+5ljlzWr0XlEHp6hmOpO5MR2LLKxP/Gsit58C8gaOmdQ+99sDcepQO7C/dAkJBwh p9RafWlRaG3F8foF1xU26rmYms7jEWABiuDmt3uYJmLfrYTyNlp+03BnPwBoKsniPP3xCSBf0NsB3 ilA2iilQccCCfs5mInEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7V89-00Bn7T-0Q; Fri, 09 Jun 2023 05:57:49 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7V85-00Bn6D-0E for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 05:57:46 +0000 Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-33b4b70693eso6440155ab.1 for ; Thu, 08 Jun 2023 22:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686290263; x=1688882263; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=++2Zj1omCLLppu446gvNENuVYrBxM0BkVm2pcONPHCw=; b=mJEksCrESHsJiex1or4mBAdTqS8mtSQXqx32WSM0EtiLydQdkeHaajbo2P1enf/Cdn edR1ScgCRG7tUAhcANwXFfbPbctS63b2XcPB+5i5urD4A0q6IVqEnEoJOdYZv0+LIz8w FVwJVbvpzk70BJ3yRMy08Y6qNeOIaIcohuVUfi5Yq8YcEJSowC0nOXR7jkGxEsrijIjQ o2tCkl6kM9/vKV3KhABhJPzBLgtFcJCRATEBUkBsirD0Mdj1pPsKywUwKtzNZneAhKaP +8jcAybypAjdMf81gHzS0yfIgS0zCw5TlKomlFBCGXy5lqY1jDgbwNXRHBostzpaTkQe 0jSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686290263; x=1688882263; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=++2Zj1omCLLppu446gvNENuVYrBxM0BkVm2pcONPHCw=; b=PydF2yNzeyGjEs2I0E1TgIpMgitiBY4Q3BUoOPA9BSiezcqnLWOtRleaYZQ3wAaFI4 WKBWhd7D7zKapafS9nsyasmKfSVWIeQHPjp11PXnfkdMlducTFBskQ97xKrlAKUA6q2l 0+SDLavKiOXQ5wM9pgAbi4Y6epM+kGZ698+IREPaPBKJP20FhBTAajLsZ4TbWNUQ/piw 192FPIZ7i82j8g8ndmlv6Y36UxWZsvVNBOPoEia8VnfjgH2VpEapjDl3Mlw2kRbia+yy 5AWxEJ9Qn9uOO1hn6pM5y6nvOS/zu8V/lKZkztUMkbodSEWh2pj/ATw+gjzACXKoApLN joLA== X-Gm-Message-State: AC+VfDzcesi3QJ7ZgKvgM+0m8+3FOvR1n+CbB2D+m2Nau2JP1Khq+SrC G6Gcec2hziuK3LqdeKibG3AD X-Google-Smtp-Source: ACHHUZ6GJJrdYE1QiP/Ozdl2rWOQLC5T3Eor5qKvghiCVz8mJ5Y0d+6D5hPCUlbt+nEN01EpI+suhg== X-Received: by 2002:a92:cbd2:0:b0:338:18f1:db72 with SMTP id s18-20020a92cbd2000000b0033818f1db72mr696567ilq.29.1686290263599; Thu, 08 Jun 2023 22:57:43 -0700 (PDT) Received: from thinkpad ([117.202.186.138]) by smtp.gmail.com with ESMTPSA id e15-20020aa7824f000000b0063b96574b8bsm1888925pfn.220.2023.06.08.22.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 22:57:43 -0700 (PDT) Date: Fri, 9 Jun 2023 11:27:37 +0530 From: Manivannan Sadhasivam To: Siddharth Vadapalli Cc: tjoseph@cadence.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, nadeem@cadence.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com, nm@ti.com Subject: Re: [PATCH v3] PCI: cadence: Fix Gen2 Link Retraining process Message-ID: <20230609055737.GA6847@thinkpad> References: <20230607091427.852473-1-s-vadapalli@ti.com> <20230608154206.GI5672@thinkpad> <67865af6-7ea4-63e3-6c35-4cd038f36af3@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <67865af6-7ea4-63e3-6c35-4cd038f36af3@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230608_225745_140082_05FA63D0 X-CRM114-Status: GOOD ( 46.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMDksIDIwMjMgYXQgMDk6NDY6MjBBTSArMDUzMCwgU2lkZGhhcnRoIFZhZGFw YWxsaSB3cm90ZToKPiBIZWxsbyBNYW5pLAo+IAo+IFRoYW5rIHlvdSBmb3IgcmV2aWV3aW5nIHRo aXMgcGF0Y2guCj4gCj4gT24gMDgvMDYvMjMgMjE6MTIsIE1hbml2YW5uYW4gU2FkaGFzaXZhbSB3 cm90ZToKPiA+IE9uIFdlZCwgSnVuIDA3LCAyMDIzIGF0IDAyOjQ0OjI3UE0gKzA1MzAsIFNpZGRo YXJ0aCBWYWRhcGFsbGkgd3JvdGU6Cj4gPj4gVGhlIExpbmsgUmV0cmFpbmluZyBwcm9jZXNzIGlz IGluaXRpYXRlZCB0byBhY2NvdW50IGZvciB0aGUgR2VuMiBkZWZlY3QgaW4KPiA+PiB0aGUgQ2Fk ZW5jZSBQQ0llIGNvbnRyb2xsZXIgaW4gSjcyMUUgU29DLiBUaGUgZXJyYXRhIGNvcnJlc3BvbmRp bmcgdG8gdGhpcwo+ID4+IGlzIGkyMDg1LCBkb2N1bWVudGVkIGF0Ogo+ID4+IGh0dHBzOi8vd3d3 LnRpLmNvbS9saXQvZXIvc3ByejQ1NWMvc3ByejQ1NWMucGRmCj4gPj4KPiA+PiBUaGUgZXhpc3Rp bmcgd29ya2Fyb3VuZCBpbXBsZW1lbnRlZCBmb3IgdGhlIGVycmF0YSB3YWl0cyBmb3IgdGhlIERh dGEgTGluawo+ID4+IGluaXRpYWxpemF0aW9uIHRvIGNvbXBsZXRlIGFuZCBhc3N1bWVzIHRoYXQg dGhlIGxpbmsgcmV0cmFpbmluZyBwcm9jZXNzCj4gPj4gYXQgdGhlIFBoeXNpY2FsIExheWVyIGhh cyBjb21wbGV0ZWQuIEhvd2V2ZXIsIGl0IGlzIHBvc3NpYmxlIHRoYXQgdGhlCj4gPj4gUGh5c2lj YWwgTGF5ZXIgdHJhaW5pbmcgbWlnaHQgYmUgb25nb2luZyBhcyBpbmRpY2F0ZWQgYnkgdGhlCj4g Pj4gUENJX0VYUF9MTktTVEFfTFQgYml0IGluIHRoZSBQQ0lfRVhQX0xOS1NUQSByZWdpc3Rlci4K PiA+Pgo+ID4+IEZpeCB0aGUgZXhpc3Rpbmcgd29ya2Fyb3VuZCwgdG8gZW5zdXJlIHRoYXQgdGhl IFBoeXNpY2FsIExheWVyIHRyYWluaW5nCj4gPj4gaGFzIGFsc28gY29tcGxldGVkLCBpbiBhZGRp dGlvbiB0byB0aGUgRGF0YSBMaW5rIGluaXRpYWxpemF0aW9uLgo+ID4+Cj4gPiAKPiA+IGNkbnNf cGNpZV9ob3N0X3dhaXRfZm9yX2xpbmsoKSBmdW5jdGlvbiBpcyBjYWxsZWQgZXZlbiBmb3IgdGhl IG5vbi1xdWlya3kgY2FzZXMKPiA+IGFzIHdlbGwsIHNvIGRvZXMgdGhpcyBwYXRjaC4gQnV0IGlm IHlvdXIgcGF0Y2ggaXMgb25seSB0YXJnZXRpbmcgdGhlIGxpbmsKPiA+IHJldHJhaW5pbmcgY2Fz ZSwgeW91IHNob3VsZCBtb3ZlIHRoZSBsb2dpYyB0byBjZG5zX3BjaWVfcmV0cmFpbigpLgo+IAo+ IEluIHRoZSB2MiB2ZXJzaW9uIG9mIHRoaXMgcGF0Y2ggYXQ6Cj4gaHR0cHM6Ly9sb3JlLmtlcm5l bC5vcmcvci8yMDIzMDMxNTA3MDgwMC4xNjE1NTI3LTEtcy12YWRhcGFsbGlAdGkuY29tLwo+IEkg aGFkIGltcGxlbWVudGVkIGl0IGFzIHN1Z2dlc3RlZCBhYm92ZSBieSB5b3UuIEhvd2V2ZXIsIGJh c2VkIG9uIHRoZSBkaXNjdXNzaW9uCj4gd2l0aCBCam9ybiBhdDoKPiBodHRwczovL2xvcmUua2Vy bmVsLm9yZy9yLzIwMjMwNTA5MTgyNDE2LkdBMTI1OTg0MUBiaGVsZ2Fhcy8KPiBpdCB3YXMgYWdy ZWVkIHVwb24gdGhhdCB3YWl0aW5nIGZvciB0d28gdGhpbmdzIGluIHN1Y2Nlc3Npb24gZG9lc24n dCBzZWVtIHRvIGJlCj4gdGhlIGJlc3Qgd2F5IHRvIGltcGxlbWVudCBpdC4gVGhlcmVmb3JlLCB0 aGUgY2Ruc19wY2llX2hvc3RfdHJhaW5pbmdfY29tcGxldGUoKQo+IGZ1bmN0aW9uIGluIHRoZSB2 MiBwYXRjaCBpcyBtZXJnZWQgaW50byB0aGUgY2Ruc19wY2llX2hvc3Rfd2FpdF9mb3JfbGluaygp Cj4gZnVuY3Rpb24gaW4gdGhpcyBwYXRjaC4KPiAKCkkgdGhpbmsgQmpvcm4ncyBwb2ludCB3YXMg dG8gbWFrZSB0aGUgd2FpdF9mb3JfbGluaygpIGJlaGF2aW9yIHNhbWUgYWNyb3NzCmRyaXZlcnMu IFdoaWxlIEkgYWdyZWUgd2l0aCB0aGF0LCBJJ2QgbGlrZSB0byBrbm93IHdoZXRoZXIgYWRkaW5n IHRoaXMgd2FpdCBmb3IKYWxsIGNhc2VzIChub3QganVzdCBkdXJpbmcgbGluayByZXRyYWluaW5n IHF1aXJrKSBhZGRzIHVwIGFueSBsYXRlbmN5IG9yIG5vdC4KCkNhbiB5b3UgbWVhc3VyZSB0aGF0 PwoKPiA+IAo+ID4gCj4gPj4gRml4ZXM6IDQ3NDBiOTY5YWFmNSAoIlBDSTogY2FkZW5jZTogUmV0 cmFpbiBMaW5rIHRvIHdvcmsgYXJvdW5kIEdlbjIgdHJhaW5pbmcgZGVmZWN0IikKPiA+PiBTaWdu ZWQtb2ZmLWJ5OiBTaWRkaGFydGggVmFkYXBhbGxpIDxzLXZhZGFwYWxsaUB0aS5jb20+Cj4gPj4g UmV2aWV3ZWQtYnk6IFZpZ25lc2ggUmFnaGF2ZW5kcmEgPHZpZ25lc2hyQHRpLmNvbT4KPiA+PiAt LS0KPiA+Pgo+ID4+IEhlbGxvLAo+ID4+Cj4gPj4gVGhpcyBwYXRjaCBpcyBiYXNlZCBvbiBsaW51 eC1uZXh0IHRhZ2dlZCBuZXh0LTIwMjMwNjA2Lgo+ID4+Cj4gPj4gdjI6Cj4gPj4gaHR0cHM6Ly9s b3JlLmtlcm5lbC5vcmcvci8yMDIzMDMxNTA3MDgwMC4xNjE1NTI3LTEtcy12YWRhcGFsbGlAdGku Y29tLwo+ID4+IENoYW5nZXMgc2luY2UgdjI6Cj4gPj4gLSBNZXJnZSB0aGUgY2Ruc19wY2llX2hv c3RfdHJhaW5pbmdfY29tcGxldGUoKSBmdW5jdGlvbiB3aXRoIHRoZQo+ID4+ICAgY2Ruc19wY2ll X2hvc3Rfd2FpdF9mb3JfbGluaygpIGZ1bmN0aW9uLCBhcyBzdWdnZXN0ZWQgYnkgQmpvcm4KPiA+ PiAgIGZvciB0aGUgdjIgcGF0Y2guCj4gPj4gLSBBZGQgZGV2X2VycigpIHRvIG5vdGlmeSB3aGVu IExpbmsgVHJhaW5pbmcgZmFpbHMsIHNpbmNlIHRoaXMgaXMgYQo+ID4+ICAgZmF0YWwgZXJyb3Ig YW5kIHByb2NlZWRpbmcgZnJvbSB0aGlzIHBvaW50IHdpbGwgYWxtb3N0IGFsd2F5cyBjcmFzaAo+ ID4+ICAgdGhlIGtlcm5lbC4KPiA+Pgo+ID4+IHYxOgo+ID4+IGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL3IvMjAyMzAxMDIwNzU2NTYuMjYwMzMzLTEtcy12YWRhcGFsbGlAdGkuY29tLwo+ID4+IENo YW5nZXMgc2luY2UgdjE6Cj4gPj4gLSBDb2xsZWN0IFJldmlld2VkLWJ5IHRhZyBmcm9tIFZpZ25l c2ggUmFnaGF2ZW5kcmEuCj4gPj4gLSBSZWJhc2Ugb24gbmV4dC0yMDIzMDMxNS4KPiA+Pgo+ID4+ IFJlZ2FyZHMsCj4gPj4gU2lkZGhhcnRoLgo+ID4+Cj4gPj4gIC4uLi9jb250cm9sbGVyL2NhZGVu Y2UvcGNpZS1jYWRlbmNlLWhvc3QuYyAgICB8IDIwICsrKysrKysrKysrKysrKysrKysKPiA+PiAg MSBmaWxlIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL3BjaS9jb250cm9sbGVyL2NhZGVuY2UvcGNpZS1jYWRlbmNlLWhvc3QuYyBiL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvY2FkZW5jZS9wY2llLWNhZGVuY2UtaG9zdC5jCj4gPj4gaW5kZXgg OTQwYzdkZDcwMWQ2Li43MGE1ZjU4MWZmNGYgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9wY2kv Y29udHJvbGxlci9jYWRlbmNlL3BjaWUtY2FkZW5jZS1ob3N0LmMKPiA+PiArKysgYi9kcml2ZXJz L3BjaS9jb250cm9sbGVyL2NhZGVuY2UvcGNpZS1jYWRlbmNlLWhvc3QuYwo+ID4+IEBAIC0xMiw2 ICsxMiw4IEBACj4gPj4gIAo+ID4+ICAjaW5jbHVkZSAicGNpZS1jYWRlbmNlLmgiCj4gPj4gIAo+ ID4+ICsjZGVmaW5lIExJTktfUkVUUkFJTl9USU1FT1VUIEhaCj4gPj4gKwo+ID4+ICBzdGF0aWMg dTY0IGJhcl9tYXhfc2l6ZVtdID0gewo+ID4+ICAJW1JQX0JBUjBdID0gX1VMTCgxMjggKiBTWl8y RyksCj4gPj4gIAlbUlBfQkFSMV0gPSBTWl8yRywKPiA+PiBAQCAtODAsOCArODIsMjYgQEAgc3Rh dGljIHN0cnVjdCBwY2lfb3BzIGNkbnNfcGNpZV9ob3N0X29wcyA9IHsKPiA+PiAgc3RhdGljIGlu dCBjZG5zX3BjaWVfaG9zdF93YWl0X2Zvcl9saW5rKHN0cnVjdCBjZG5zX3BjaWUgKnBjaWUpCj4g Pj4gIHsKPiA+PiAgCXN0cnVjdCBkZXZpY2UgKmRldiA9IHBjaWUtPmRldjsKPiA+PiArCXVuc2ln bmVkIGxvbmcgZW5kX2ppZmZpZXM7Cj4gPj4gKwl1MTYgbGlua19zdGF0dXM7Cj4gPj4gIAlpbnQg cmV0cmllczsKPiA+PiAgCj4gPj4gKwkvKiBXYWl0IGZvciBsaW5rIHRyYWluaW5nIHRvIGNvbXBs ZXRlICovCj4gPj4gKwllbmRfamlmZmllcyA9IGppZmZpZXMgKyBMSU5LX1JFVFJBSU5fVElNRU9V VDsKPiA+PiArCWRvIHsKPiA+PiArCQlsaW5rX3N0YXR1cyA9IGNkbnNfcGNpZV9ycF9yZWFkdyhw Y2llLCBDRE5TX1BDSUVfUlBfQ0FQX09GRlNFVCArIFBDSV9FWFBfTE5LU1RBKTsKPiA+PiArCQlp ZiAoIShsaW5rX3N0YXR1cyAmIFBDSV9FWFBfTE5LU1RBX0xUKSkKPiA+PiArCQkJYnJlYWs7Cj4g Pj4gKwkJdXNsZWVwX3JhbmdlKDAsIDEwMDApOwo+ID4+ICsJfSB3aGlsZSAodGltZV9iZWZvcmUo amlmZmllcywgZW5kX2ppZmZpZXMpKTsKPiA+PiArCj4gPj4gKwlpZiAoIShsaW5rX3N0YXR1cyAm IFBDSV9FWFBfTE5LU1RBX0xUKSkgewo+ID4+ICsJCWRldl9pbmZvKGRldiwgIkxpbmsgdHJhaW5p bmcgY29tcGxldGVcbiIpOwo+ID4gCj4gPiBUaGlzIGluZm8gaXMgbm90IG5lZWRlZC4KPiAKPiBT dXJlLiBJIHdpbGwgZHJvcCBpdCBpbiB0aGUgdjQgcGF0Y2guCj4gCj4gPiAKPiA+PiArCX0gZWxz ZSB7Cj4gPj4gKwkJZGV2X2VycihkZXYsICJGYXRhbCEgTGluayB0cmFpbmluZyBpbmNvbXBsZXRl XG4iKTsKPiA+IAo+ID4gVGhpcyBjb3VsZCBiZSwgIkxpbmsgcmV0cmFpbmluZyBpbmNvbXBsZXRl Ii4KPiAKPiBJIGFkZGVkIHRoZSB3b3JkICJGYXRhbCIgc2luY2UgTGludXggaXMgYWxtb3N0IGFs d2F5cyBndWFyYW50ZWVkIHRvIGNyYXNoIGlmIHRoZQo+IGxpbmsgdHJhaW5pbmcgZG9lc24ndCBj b21wbGV0ZSBiZWZvcmUgdGhlIFBDSSBzdWJzeXN0ZW0gYXR0ZW1wdHMgdG8gZW51bWVyYXRlCj4g dGhlIEVQIGRldmljZXMuIFRoZXJlZm9yZSwgYWRkaW5nIHRoZSB3b3JkICJGYXRhbCIgd2lsbCBo ZWxwIHRoZSB1c2VycyBpZGVudGlmeQo+IHdoYXQgdGhlIGNhdXNlIG9mIHRoZSBjcmFzaCBpcywg d2hpY2ggd291bGQgb3RoZXJ3aXNlIGJlIG92ZXJsb29rZWQsIHVubGVzcyB0aGUKPiBjcml0aWNh bCBuYXR1cmUgb2YgdGhpcyBlcnJvciBpcyBjb252ZXllZCB0byB0aGUgdXNlci4KPiAKCk9rLgoK LSBNYW5pCgo+ID4gCj4gPiAtIE1hbmkKPiA+IAo+ID4+ICsJCXJldHVybiAtRVRJTUVET1VUOwo+ ID4+ICsJfQo+ID4+ICsKPiA+PiAgCS8qIENoZWNrIGlmIHRoZSBsaW5rIGlzIHVwIG9yIG5vdCAq Lwo+ID4+ICAJZm9yIChyZXRyaWVzID0gMDsgcmV0cmllcyA8IExJTktfV0FJVF9NQVhfUkVUUklF UzsgcmV0cmllcysrKSB7Cj4gPj4gIAkJaWYgKGNkbnNfcGNpZV9saW5rX3VwKHBjaWUpKSB7Cj4g Pj4gLS0gCj4gPj4gMi4yNS4xCj4gPj4KPiA+IAo+IAo+IC0tIAo+IFJlZ2FyZHMsCj4gU2lkZGhh cnRoLgoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXg rq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK