From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 10/19] cxl/memdev: Indicate probe deferral
Date: Fri, 9 Jun 2023 07:16:41 +0800 [thread overview]
Message-ID: <202306090732.SLD5PmoG-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <168592155270.1948938.11536845108449547920.stgit@dwillia2-xfh.jf.intel.com>
References: <168592155270.1948938.11536845108449547920.stgit@dwillia2-xfh.jf.intel.com>
TO: Dan Williams <dan.j.williams@intel.com>
Hi Dan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 9561de3a55bed6bdd44a12820ba81ec416e705a7]
url: https://github.com/intel-lab-lkp/linux/commits/Dan-Williams/cxl-regs-Clarify-when-a-struct-cxl_register_map-is-input-vs-output/20230605-073402
base: 9561de3a55bed6bdd44a12820ba81ec416e705a7
patch link: https://lore.kernel.org/r/168592155270.1948938.11536845108449547920.stgit%40dwillia2-xfh.jf.intel.com
patch subject: [PATCH 10/19] cxl/memdev: Indicate probe deferral
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: i386-randconfig-m021-20230608 (https://download.01.org/0day-ci/archive/20230609/202306090732.SLD5PmoG-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202306090732.SLD5PmoG-lkp@intel.com/
smatch warnings:
drivers/cxl/core/memdev.c:642 cxl_acquire_endpoint() warn: inconsistent returns '&cxlmd->dev.mutex'.
vim +642 drivers/cxl/core/memdev.c
3d135db510240f Ben Widawsky 2021-08-02 611
126ed1e685e817 Dan Williams 2023-06-04 612 /*
126ed1e685e817 Dan Williams 2023-06-04 613 * Try to get a locked reference on a memdev's CXL port topology
126ed1e685e817 Dan Williams 2023-06-04 614 * connection. Be careful to observe when cxl_mem_probe() has deposited
126ed1e685e817 Dan Williams 2023-06-04 615 * a probe deferral awaiting the arrival of the CXL root driver
126ed1e685e817 Dan Williams 2023-06-04 616 */
126ed1e685e817 Dan Williams 2023-06-04 617 struct cxl_port *cxl_acquire_endpoint(struct cxl_memdev *cxlmd)
126ed1e685e817 Dan Williams 2023-06-04 618 {
126ed1e685e817 Dan Williams 2023-06-04 619 struct cxl_port *endpoint;
126ed1e685e817 Dan Williams 2023-06-04 620 int rc = -ENXIO;
126ed1e685e817 Dan Williams 2023-06-04 621
126ed1e685e817 Dan Williams 2023-06-04 622 device_lock(&cxlmd->dev);
126ed1e685e817 Dan Williams 2023-06-04 623 endpoint = cxlmd->endpoint;
126ed1e685e817 Dan Williams 2023-06-04 624 if (!endpoint)
126ed1e685e817 Dan Williams 2023-06-04 625 goto err;
126ed1e685e817 Dan Williams 2023-06-04 626
126ed1e685e817 Dan Williams 2023-06-04 627 if (IS_ERR(endpoint)) {
126ed1e685e817 Dan Williams 2023-06-04 628 rc = PTR_ERR(endpoint);
126ed1e685e817 Dan Williams 2023-06-04 629 goto err;
126ed1e685e817 Dan Williams 2023-06-04 630 }
126ed1e685e817 Dan Williams 2023-06-04 631
126ed1e685e817 Dan Williams 2023-06-04 632 device_lock(&endpoint->dev);
126ed1e685e817 Dan Williams 2023-06-04 633 if (!endpoint->dev.driver)
126ed1e685e817 Dan Williams 2023-06-04 634 goto err_endpoint;
126ed1e685e817 Dan Williams 2023-06-04 635
126ed1e685e817 Dan Williams 2023-06-04 636 return endpoint;
126ed1e685e817 Dan Williams 2023-06-04 637
126ed1e685e817 Dan Williams 2023-06-04 638 err_endpoint:
126ed1e685e817 Dan Williams 2023-06-04 639 device_unlock(&endpoint->dev);
126ed1e685e817 Dan Williams 2023-06-04 640 err:
126ed1e685e817 Dan Williams 2023-06-04 641 device_unlock(&cxlmd->dev);
126ed1e685e817 Dan Williams 2023-06-04 @642 return ERR_PTR(rc);
126ed1e685e817 Dan Williams 2023-06-04 643 }
126ed1e685e817 Dan Williams 2023-06-04 644 EXPORT_SYMBOL_NS(cxl_acquire_endpoint, CXL);
126ed1e685e817 Dan Williams 2023-06-04 645
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-06-08 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 23:16 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-04 23:31 [PATCH 00/19] cxl: Device memory setup Dan Williams
2023-06-04 23:32 ` [PATCH 10/19] cxl/memdev: Indicate probe deferral Dan Williams
2023-06-06 13:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306090732.SLD5PmoG-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.