All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
	Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Melissa Wen <melissa.srw@gmail.com>
Subject: [RESEND 03/15] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting
Date: Fri,  9 Jun 2023 09:17:06 +0100	[thread overview]
Message-ID: <20230609081732.3842341-4-lee@kernel.org> (raw)
In-Reply-To: <20230609081732.3842341-1-lee@kernel.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or member 'frame_info' not described in 'pre_mul_alpha_blend'
 drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Excess function parameter 'src_frame_info' description in 'pre_mul_alpha_blend'
 drivers/gpu/drm/vkms/vkms_composer.c:72: warning: Cannot understand  * @wb_frame_info: The writeback frame buffer metadata

Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Melissa Wen <melissa.srw@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee@kernel.org>
---
 drivers/gpu/drm/vkms/vkms_composer.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
index 906d3df40cdbe..03fa3eeef678c 100644
--- a/drivers/gpu/drm/vkms/vkms_composer.c
+++ b/drivers/gpu/drm/vkms/vkms_composer.c
@@ -23,7 +23,7 @@ static u16 pre_mul_blend_channel(u16 src, u16 dst, u16 alpha)
 
 /**
  * pre_mul_alpha_blend - alpha blending equation
- * @src_frame_info: source framebuffer's metadata
+ * @frame_info: source framebuffer's metadata
  * @stage_buffer: The line with the pixels from src_plane
  * @output_buffer: A line buffer that receives all the blends output
  *
@@ -90,11 +90,13 @@ static void fill_background(const struct pixel_argb_u16 *background_color,
 }
 
 /**
- * @wb_frame_info: The writeback frame buffer metadata
+ * blend - blend pixels from a given row and calculate CRC
+ * @wb: The writeback frame buffer metadata
  * @crtc_state: The crtc state
  * @crc32: The crc output of the final frame
  * @output_buffer: A buffer of a row that will receive the result of the blend(s)
  * @stage_buffer: The line with the pixels from plane being blend to the output
+ * @row_size: Size of memory taken up by row data (line_width * pixel_size)
  *
  * This function blends the pixels (Using the `pre_mul_alpha_blend`)
  * from all planes, calculates the crc32 of the output from the former step,
-- 
2.41.0.162.gfafddb0af9-goog


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org,
	Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
	Melissa Wen <melissa.srw@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: [RESEND 03/15] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting
Date: Fri,  9 Jun 2023 09:17:06 +0100	[thread overview]
Message-ID: <20230609081732.3842341-4-lee@kernel.org> (raw)
In-Reply-To: <20230609081732.3842341-1-lee@kernel.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or member 'frame_info' not described in 'pre_mul_alpha_blend'
 drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Excess function parameter 'src_frame_info' description in 'pre_mul_alpha_blend'
 drivers/gpu/drm/vkms/vkms_composer.c:72: warning: Cannot understand  * @wb_frame_info: The writeback frame buffer metadata

Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Melissa Wen <melissa.srw@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee@kernel.org>
---
 drivers/gpu/drm/vkms/vkms_composer.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
index 906d3df40cdbe..03fa3eeef678c 100644
--- a/drivers/gpu/drm/vkms/vkms_composer.c
+++ b/drivers/gpu/drm/vkms/vkms_composer.c
@@ -23,7 +23,7 @@ static u16 pre_mul_blend_channel(u16 src, u16 dst, u16 alpha)
 
 /**
  * pre_mul_alpha_blend - alpha blending equation
- * @src_frame_info: source framebuffer's metadata
+ * @frame_info: source framebuffer's metadata
  * @stage_buffer: The line with the pixels from src_plane
  * @output_buffer: A line buffer that receives all the blends output
  *
@@ -90,11 +90,13 @@ static void fill_background(const struct pixel_argb_u16 *background_color,
 }
 
 /**
- * @wb_frame_info: The writeback frame buffer metadata
+ * blend - blend pixels from a given row and calculate CRC
+ * @wb: The writeback frame buffer metadata
  * @crtc_state: The crtc state
  * @crc32: The crc output of the final frame
  * @output_buffer: A buffer of a row that will receive the result of the blend(s)
  * @stage_buffer: The line with the pixels from plane being blend to the output
+ * @row_size: Size of memory taken up by row data (line_width * pixel_size)
  *
  * This function blends the pixels (Using the `pre_mul_alpha_blend`)
  * from all planes, calculates the crc32 of the output from the former step,
-- 
2.41.0.162.gfafddb0af9-goog


  parent reply	other threads:[~2023-06-09  8:18 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  8:17 [RESEND 00/15] Rid W=1 warnings from GPU Lee Jones
2023-06-09  8:17 ` Lee Jones
2023-06-09  8:17 ` Lee Jones
2023-06-09  8:17 ` Lee Jones
2023-06-09  8:17 ` [Nouveau] " Lee Jones
2023-06-09  8:17 ` [RESEND 01/15] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17 ` [RESEND 02/15] drm/xlnx/zynqmp_dp: Fix function name zynqmp_dp_link_train() -> zynqmp_dp_train() Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17 ` Lee Jones [this message]
2023-06-09  8:17   ` [RESEND 03/15] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting Lee Jones
2023-06-09  8:17 ` [RESEND 04/15] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:51   ` AngeloGioacchino Del Regno
2023-06-09  8:51     ` AngeloGioacchino Del Regno
2023-06-09  8:51     ` AngeloGioacchino Del Regno
2023-06-09  8:17 ` [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: " Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:51   ` AngeloGioacchino Del Regno
2023-06-09  8:51     ` AngeloGioacchino Del Regno
2023-06-09  8:51     ` AngeloGioacchino Del Regno
2023-06-09 14:31   ` Matthias Brugger
2023-06-09 14:31     ` Matthias Brugger
2023-06-09 14:31     ` Matthias Brugger
2023-06-12 11:23     ` Lee Jones
2023-06-12 11:23       ` Lee Jones
2023-06-09  8:17 ` [Nouveau] [RESEND 06/15] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 12:08   ` [Nouveau] " Karol Herbst
2023-06-09 12:08     ` Karol Herbst
2023-06-09 12:08     ` Karol Herbst
2023-06-09  8:17 ` [Nouveau] [RESEND 07/15] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 12:07   ` [Nouveau] " Karol Herbst
2023-06-09 12:07     ` Karol Herbst
2023-06-09 12:07     ` Karol Herbst
2023-06-09  8:17 ` [Nouveau] [RESEND 08/15] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 12:08   ` [Nouveau] " Karol Herbst
2023-06-09 12:08     ` Karol Herbst
2023-06-09 12:08     ` Karol Herbst
2023-06-09  8:17 ` [Nouveau] [RESEND 09/15] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 12:09   ` [Nouveau] " Karol Herbst
2023-06-09 12:09     ` Karol Herbst
2023-06-09 12:09     ` Karol Herbst
2023-06-09  8:17 ` [Nouveau] [RESEND 10/15] drm/nouveau/nvkm/engine/gr/tu102: Staticify local function gf100_fifo_nonstall_block() Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 12:09   ` [Nouveau] " Karol Herbst
2023-06-09 12:09     ` Karol Herbst
2023-06-09 12:09     ` Karol Herbst
2023-06-09  8:17 ` [RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 14:54   ` Harry Wentland
2023-06-09 14:54     ` Harry Wentland
2023-06-09 14:54     ` Harry Wentland
2023-06-09 15:07   ` Hamza Mahfooz
2023-06-09 15:07     ` Hamza Mahfooz
2023-06-09 15:07     ` Hamza Mahfooz
2023-06-09  8:17 ` [Nouveau] [RESEND 12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 12:09   ` [Nouveau] " Karol Herbst
2023-06-09 12:09     ` Karol Herbst
2023-06-09 12:09     ` Karol Herbst
2023-06-11  6:59   ` [Nouveau] [RESEND, " Sui Jingfeng
2023-06-11  6:59     ` [RESEND,12/15] " Sui Jingfeng
2023-06-11  6:59     ` [RESEND, 12/15] " Sui Jingfeng
2023-06-09  8:17 ` [Nouveau] [RESEND 13/15] drm/nouveau/nvkm/engine/gr/tu102: Completely remove unused function ‘tu102_gr_load’ Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17 ` [RESEND 14/15] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 19:03   ` Alex Deucher
2023-06-09 19:03     ` Alex Deucher
2023-06-09 19:03     ` Alex Deucher
2023-06-09  8:17 ` [RESEND 15/15] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09  8:17   ` Lee Jones
2023-06-09 19:05   ` Alex Deucher
2023-06-09 19:05     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609081732.3842341-4-lee@kernel.org \
    --to=lee@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=melissa.srw@gmail.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.