From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes
Date: Fri, 9 Jun 2023 16:54:42 -0600 [thread overview]
Message-ID: <20230609225442.GA2588193-robh@kernel.org> (raw)
In-Reply-To: <20230609140745.65046-1-krzysztof.kozlowski@linaro.org>
On Fri, Jun 09, 2023 at 04:07:45PM +0200, Krzysztof Kozlowski wrote:
> Cleanup bindings dropping unneeded quotes. Once all these are fixed,
> checking for this can be enabled in yamllint.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You missed $id and $schema values.
Within drivers/crypto, there's also:
diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bi
ndings/crypto/amlogic,gxl-crypto.yaml
index ecf98a9e72b2..948e11ebe4ee 100644
--- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
+++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
@@ -19,8 +19,8 @@ properties:
interrupts:
items:
- - description: "Interrupt for flow 0"
- - description: "Interrupt for flow 1"
+ - description: Interrupt for flow 0
+ - description: Interrupt for flow 1
clocks:
maxItems: 1
Can you add this in here. No reason to split this up more that 1 patch
per subsystem really.
As I mentioned, I have a WIP tree[1] with yamllint checks enabled and
I scripted many of the changes. It was clean, but there's some new ones
since rebasing to v6.4-rc1:
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:30:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:31:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:42:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml:43:16: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:38:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:39:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:40:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:41:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:42:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-max9808x.yaml:43:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:34:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:35:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:36:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml:37:11: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:65:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:74:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:83:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:93:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
../Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml:117:15: [error] string value is redundantly quoted with any quotes (quoted-strings)
Rob
[1] https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/log/?h=dt/yamllint
next prev parent reply other threads:[~2023-06-09 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 14:07 [PATCH] dt-bindings: crypto: intel,ixp4xx: drop unneeded quotes Krzysztof Kozlowski
2023-06-09 19:10 ` Linus Walleij
2023-06-09 22:54 ` Rob Herring [this message]
2023-06-21 6:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609225442.GA2588193-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.