From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A2DC7EE45 for ; Fri, 9 Jun 2023 23:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbjFIXcK (ORCPT ); Fri, 9 Jun 2023 19:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232557AbjFIXbY (ORCPT ); Fri, 9 Jun 2023 19:31:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 516B93C19 for ; Fri, 9 Jun 2023 16:29:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3155161AE1 for ; Fri, 9 Jun 2023 23:29:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86A4EC433EF; Fri, 9 Jun 2023 23:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686353350; bh=LUXtm20a/ShN37EevJ+eSEMK2szc0ugQN6ujMnju8TQ=; h=Date:To:From:Subject:From; b=ZpP40KIllRgVZTTuAwkeLYCZn1zzg4MndzNf9GmmP1veQ2aNT5xh7pZojKT5s2XF/ 2yoptXhtMy+RoCantOEPmmGW8puLDzCrPf1iS5JTfkoYcCPhG80+aXzh0y+2TAaCz3 V5DzGOxIDV3tNQDslk70JQEna8Tr5lQmHPtHxC1U= Date: Fri, 09 Jun 2023 16:29:09 -0700 To: mm-commits@vger.kernel.org, catalin.marinas@arm.com, jim.cromie@gmail.com, akpm@linux-foundation.org From: Andrew Morton Subject: [merged mm-stable] kmemleak-test-drop-__init-to-get-better-backtrace.patch removed from -mm tree Message-Id: <20230609232910.86A4EC433EF@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The quilt patch titled Subject: kmemleak-test: drop __init to get better backtrace has been removed from the -mm tree. Its filename was kmemleak-test-drop-__init-to-get-better-backtrace.patch This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm ------------------------------------------------------ From: Jim Cromie Subject: kmemleak-test: drop __init to get better backtrace Date: Thu, 25 May 2023 11:43:56 -0600 Drop the __init on kmemleak_test_init(). With it, the storage is reclaimed, but then the symbol isn't available for "%pS" rendering, and the backtrace gets a bare pointer where the actual leak happened. unreferenced object 0xffff88800a2b0800 (size 1024): comm "modprobe", pid 413, jiffies 4294953430 hex dump (first 32 bytes): 73 02 00 00 75 01 00 68 02 00 00 01 00 00 00 04 s...u..h........ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<00000000fabad728>] kmalloc_trace+0x26/0x90 [<00000000ef738764>] 0xffffffffc02350a2 [<00000000004e5795>] do_one_initcall+0x43/0x210 [<00000000d768905e>] do_init_module+0x4a/0x210 [<0000000087135ab5>] __do_sys_finit_module+0x93/0xf0 [<000000004fcb1fa2>] do_syscall_64+0x34/0x80 [<00000000c73c8d9d>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 with __init gone, that trace entry renders like: [<00000000ef738764>] kmemleak_test_init+/ Link: https://lkml.kernel.org/r/20230525174356.69711-1-jim.cromie@gmail.com Signed-off-by: Jim Cromie Acked-by: Catalin Marinas Signed-off-by: Andrew Morton --- samples/kmemleak/kmemleak-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/samples/kmemleak/kmemleak-test.c~kmemleak-test-drop-__init-to-get-better-backtrace +++ a/samples/kmemleak/kmemleak-test.c @@ -32,7 +32,7 @@ static DEFINE_PER_CPU(void *, kmemleak_t * Some very simple testing. This function needs to be extended for * proper testing. */ -static int __init kmemleak_test_init(void) +static int kmemleak_test_init(void) { struct test_node *elem; int i; _ Patches currently in -mm which might be from jim.cromie@gmail.com are