From: Jakub Kicinski <kuba@kernel.org>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: netdev@vger.kernel.org, przemyslaw.kitszel@intel.com,
michal.swiatkowski@linux.intel.com, pmenzel@molgen.mpg.de,
maciej.fijalkowski@intel.com, anthony.l.nguyen@intel.com,
simon.horman@corigine.com, aleksander.lobakin@intel.com
Subject: Re: [PATCH net-next] net: add check for current MAC address in dev_set_mac_address
Date: Fri, 9 Jun 2023 23:44:39 -0700 [thread overview]
Message-ID: <20230609234439.3f415cd0@kernel.org> (raw)
In-Reply-To: <20230609165241.827338-1-piotrx.gardocki@intel.com>
On Fri, 9 Jun 2023 18:52:41 +0200 Piotr Gardocki wrote:
> + if (ether_addr_equal(dev->dev_addr, sa->sa_data))
> + return 0;
not every device is ethernet, you need to use dev->addr_len for
the comparison.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-10 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 16:52 [PATCH net-next] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-09 17:00 ` Maciej Fijalkowski
2023-06-09 17:11 ` Piotr Gardocki
2023-06-10 6:44 ` Jakub Kicinski [this message]
2023-06-12 14:49 ` Piotr Gardocki
2023-06-12 15:37 ` Maciej Fijalkowski
2023-06-12 16:43 ` Piotr Gardocki
2023-06-12 17:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609234439.3f415cd0@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.