From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v3] Input: synaptics-rmi4 - retry reading SMBus version on resume
Date: Sat, 10 Jun 2023 03:47:16 +0800 [thread overview]
Message-ID: <202306100350.ck6PwGko-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230608210404.722123-1-jefferymiller@google.com>
References: <20230608210404.722123-1-jefferymiller@google.com>
TO: Jeffery Miller <jefferymiller@google.com>
TO: Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC: Jonathan Denose <jdenose@chromium.org>
CC: jdenose@google.com
CC: Lyude Paul <lyude@redhat.com>
CC: benjamin.tissoires@redhat.com
CC: Andrew Duggan <andrew@duggan.us>
CC: loic.poulain@linaro.org
CC: Jeffery Miller <jefferymiller@google.com>
CC: Javier Martinez Canillas <javierm@redhat.com>
CC: Jeremy Kerr <jk@codeconstruct.com.au>
CC: Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
CC: linux-input@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Hi Jeffery,
kernel test robot noticed the following build warnings:
[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus linus/master v6.4-rc5 next-20230609]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jeffery-Miller/Input-synaptics-rmi4-retry-reading-SMBus-version-on-resume/20230609-050652
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20230608210404.722123-1-jefferymiller%40google.com
patch subject: [PATCH v3] Input: synaptics-rmi4 - retry reading SMBus version on resume
:::::: branch date: 23 hours ago
:::::: commit date: 23 hours ago
config: arm64-randconfig-m031-20230608 (https://download.01.org/0day-ci/archive/20230610/202306100350.ck6PwGko-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202306100350.ck6PwGko-lkp@intel.com/
smatch warnings:
drivers/input/rmi4/rmi_smbus.c:66 rmi_smb_get_version() error: uninitialized symbol 'retval'.
vim +/retval +66 drivers/input/rmi4/rmi_smbus.c
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 41
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 42 static int rmi_smb_get_version(struct rmi_smb_xport *rmi_smb)
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 43 {
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 44 struct i2c_client *client = rmi_smb->client;
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 45 int retval;
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 46
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 47 /* Check if for SMBus new version device by reading version byte. */
0fe13a588e68ca Jeffery Miller 2023-06-08 48 for (int i = 0; i < 2; i++) {
0fe13a588e68ca Jeffery Miller 2023-06-08 49 if (i > 0) {
0fe13a588e68ca Jeffery Miller 2023-06-08 50 dev_warn(&client->dev, "sleeping to retry getting the SMBus version number\n");
0fe13a588e68ca Jeffery Miller 2023-06-08 51 fsleep(30000);
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 52 }
0fe13a588e68ca Jeffery Miller 2023-06-08 53 retval = i2c_smbus_read_byte_data(client,
0fe13a588e68ca Jeffery Miller 2023-06-08 54 SMB_PROTOCOL_VERSION_ADDRESS);
0fe13a588e68ca Jeffery Miller 2023-06-08 55 if (retval >= 0)
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 56 return retval + 1;
0fe13a588e68ca Jeffery Miller 2023-06-08 57
0fe13a588e68ca Jeffery Miller 2023-06-08 58 dev_err(&client->dev, "failed to get SMBus version number!\n");
0fe13a588e68ca Jeffery Miller 2023-06-08 59 /* There can be a delay on resume where the read returns
0fe13a588e68ca Jeffery Miller 2023-06-08 60 * -ENXIO. Retry to allow additional time for the read
0fe13a588e68ca Jeffery Miller 2023-06-08 61 * to become responsive.
0fe13a588e68ca Jeffery Miller 2023-06-08 62 */
0fe13a588e68ca Jeffery Miller 2023-06-08 63 if (retval != -ENXIO)
0fe13a588e68ca Jeffery Miller 2023-06-08 64 break;
0fe13a588e68ca Jeffery Miller 2023-06-08 65 }
0fe13a588e68ca Jeffery Miller 2023-06-08 @66 return retval;
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 67 }
82264d0cf7aef2 Benjamin Tissoires 2016-11-08 68
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-06-09 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 19:47 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-08 21:04 [PATCH v3] Input: synaptics-rmi4 - retry reading SMBus version on resume Jeffery Miller
2023-07-21 23:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306100350.ck6PwGko-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.