From: "Theodore Ts'o" <tytso@mit.edu>
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Cc: linux-ext4@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [RFCv2 2/5] ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio
Date: Sun, 11 Jun 2023 01:58:31 -0400 [thread overview]
Message-ID: <20230611055831.GF1436857@mit.edu> (raw)
In-Reply-To: <74182f5607ccfc3b1e7f08737fcb3442b42a2124.1684122756.git.ritesh.list@gmail.com>
On Mon, May 15, 2023 at 04:10:41PM +0530, Ritesh Harjani (IBM) wrote:
> mpage_submit_folio() was converted to take folio. Even though
> folio_size() in ext4 as of now is PAGE_SIZE, but it's better to
> remove that assumption which I am assuming is a missed left over from
> patch[1].
>
> [1]: https://lore.kernel.org/linux-ext4/20230324180129.1220691-7-willy@infradead.org/
>
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
I didn't notice this right away, because the failure is not 100%
reliable, but this commit will sometimes cause "kvm-xfstests -c
ext4/encrypt generic/068" to crash. Reverting the patch fixes the
problem, so I plan to drop this patch from my tree.
- Ted
generic/068 42s ... [01:56:09][ 7.014363] run fstests generic/068 at 2023-06-11 01:56:09
[ 7.538841] EXT4-fs (vdc): Test dummy encryption mode enabled
[ 11.407307] traps: PANIC: double fault, error_code: 0x0
[ 11.407313] double fault: 0000 [#1] PREEMPT SMP NOPTI
[ 11.407315] CPU: 1 PID: 3358 Comm: fsstress Not tainted 6.4.0-rc5-xfstests-lockdep-00069-gfc362247e79f #169
[ 11.407316] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ 11.407317] RIP: 0010:__switch_to_asm+0x33/0x80
[ 11.407322] Code: 55 41 56 41 57 48 89 a7 d8 17 00 00 48 8b a6 d8 17 00 00 48 8b 9e 40 04 00 00 65 48 89 1c 25 28 00 00 00 49 c7 c4 10 00 00 00 <e8> 01 00 00 00 cc e8 01 00 00 00 cc 48 83 c4 10 49 ff cc 75 eb 0f
[ 11.407323] RSP: 0018:ffffc90003ec7e18 EFLAGS: 00010046
[ 11.407324] RAX: 0000000000000001 RBX: 961d22f2e2e05800 RCX: 00000002afbf75a9
[ 11.407325] RDX: 0000000000000003 RSI: ffff88800d174080 RDI: ffff88800d0ae200
[ 11.407325] RBP: ffffc90003fd7af0 R08: 0000000000000001 R09: 0000000000000001
[ 11.407326] R10: 00000000000003cc R11: 0000000000000001 R12: 0000000000000010
[ 11.407326] R13: ffffe8ffffc29c50 R14: ffff88807ddee998 R15: ffff88800d174080
[ 11.407327] FS: 00007f144aee4740(0000) GS:ffff88807dc00000(0000) knlGS:0000000000000000
[ 11.407329] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 11.407330] CR2: ffffc90003ec7e08 CR3: 000000000cb3e004 CR4: 0000000000770ee0
[ 11.407330] PKRU: 55555554
[ 11.407330] Call Trace:
[ 11.407331] <#DF>
[ 11.407332] ? die+0x36/0x80
[ 11.407334] ? exc_double_fault+0xf1/0x1b0
[ 11.407336] ? asm_exc_double_fault+0x23/0x30
[ 11.407338] ? __switch_to_asm+0x33/0x80
[ 11.407339] </#DF>
[ 11.413852] ---[ end trace 0000000000000000 ]---
[ 11.413853] RIP: 0010:__switch_to_asm+0x33/0x80
[ 11.413856] Code: 55 41 56 41 57 48 89 a7 d8 17 00 00 48 8b a6 d8 17 00 00 48 8b 9e 40 04 00 00 65 48 89 1c 25 28 00 00 00 49 c7 c4 10 00 00 00 <e8> 01 00 00 00 cc e8 01 00 00 00 cc 48 83 c4 10 49 ff cc 75 eb 0f
[ 11.413857] RSP: 0018:ffffc90003ec7e18 EFLAGS: 00010046
[ 11.413857] RAX: 0000000000000001 RBX: 961d22f2e2e05800 RCX: 00000002afbf75a9
[ 11.413858] RDX: 0000000000000003 RSI: ffff88800d174080 RDI: ffff88800d0ae200
[ 11.413858] RBP: ffffc90003fd7af0 R08: 0000000000000001 R09: 0000000000000001
[ 11.413859] R10: 00000000000003cc R11: 0000000000000001 R12: 0000000000000010
[ 11.413859] R13: ffffe8ffffc29c50 R14: ffff88807ddee998 R15: ffff88800d174080
[ 11.413860] FS: 00007f144aee4740(0000) GS:ffff88807dc00000(0000) knlGS:0000000000000000
[ 11.413861] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 11.413862] CR2: ffffc90003ec7e08 CR3: 000000000cb3e004 CR4: 0000000000770ee0
[ 11.413863] PKRU: 55555554
[ 11.413863] Kernel panic - not syncing: Fatal exception in interrupt
[ 11.413889] BUG: unable to handle page fault for address: ffffc90003ebfe88
[ 11.414112] #PF: supervisor read access in kernel mode
[ 11.414320] #PF: error_code(0x0009) - reserved bit violation
[ 11.415151] PGD 5000067 P4D 5000067 PUD 5219067 PMD d278067 PTE 1e914974aa550b07
[ 11.417015] Oops: 0009 [#2] PREEMPT SMP NOPTI
[ 11.417375] CPU: 0 PID: 29 Comm: kworker/u4:2 Tainted: G D 6.4.0-rc5-xfstests-lockdep-00069-gfc362247e79f #169
[ 11.417641] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
[ 11.417962] Workqueue: writeback wb_workfn (flush-254:32)
[ 11.418683] RIP: 0010:timerqueue_add+0x28/0xb0
[ 11.418916] Code: 90 90 66 0f 1f 00 55 53 48 3b 36 48 89 f3 0f 85 96 00 00 00 48 8b 07 48 85 c0 74 55 48 8b 73 18 bd 01 00 00 00 eb 03 48 89 d0 <48> 3b 70 18 48 8d 48 10 7c 06 48 8d 48 08 31 ed 48 8b 11 48 85 d2
[ 11.419173] RSP: 0018:ffffc90000003f00 EFLAGS: 00010082
[ 11.419710] RAX: ffffc90003ebfe70 RBX: ffff88807dbe0210 RCX: ffff88800d07a3e8
[ 11.420219] RDX: ffffc90003ebfe70 RSI: 00000002a849a0e0 RDI: ffff88807dbdfb58
[ 11.420634] RBP: 0000000000000001 R08: 0000000000000001 R09: 0000000000000000
[ 11.420877] R10: 0000000000000000 R11: 0000000000000659 R12: ffff88807dbdfa40
[ 11.421082] R13: 0000000000000002 R14: ffff888005d3c180 R15: ffff88807dbdfb00
[ 11.421924] FS: 0000000000000000(0000) GS:ffff88807da00000(0000) knlGS:0000000000000000
[ 11.422165] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 11.422487] CR2: ffffc90003ebfe88 CR3: 000000000c81c001 CR4: 0000000000770ef0
[ 11.422810] PKRU: 55555554
[ 11.423133] Call Trace:
[ 11.423451] <IRQ>
[ 11.423778] ? __die+0x23/0x60
[ 11.424139] ? page_fault_oops+0xa4/0x170
[ 11.424399] ? exc_page_fault+0xfa/0x1e0
[ 11.424741] ? asm_exc_page_fault+0x26/0x30
[ 11.424884] ? timerqueue_add+0x28/0xb0
[ 11.425001] enqueue_hrtimer+0x42/0xa0
[ 11.425097] __hrtimer_run_queues+0x304/0x380
[ 11.425241] hrtimer_interrupt+0xf8/0x230
[ 11.425426] __sysvec_apic_timer_interrupt+0x75/0x190
[ 11.425605] sysvec_apic_timer_interrupt+0x65/0x80
[ 11.425794] </IRQ>
[ 11.425966] <TASK>
[ 11.426139] asm_sysvec_apic_timer_interrupt+0x1a/0x20
[ 11.426344] RIP: 0010:aesni_xts_encrypt+0x2d/0x1d0
[ 11.426529] Code: 00 66 0f 6f 3d 24 ff 93 01 41 0f 10 18 44 8b 8f e0 01 00 00 48 83 e9 40 0f 8c f3 00 00 00 66 0f 6f c3 f3 0f 6f 0a 66 0f ef c1 <f3> 0f 7f 1e 66 0f 70 d3 13 66 0f d4 db 66 0f 72 e2 1f 66 0f db d7
[ 11.426757] RSP: 0018:ffffc9000052f558 EFLAGS: 00010206
[ 11.427074] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000fc0
[ 11.427172] RDX: ffff88801281a000 RSI: ffff88800d7c3000 RDI: ffff88800d180220
[ 11.427406] RBP: ffffc9000052f720 R08: ffffc9000052f780 R09: 0000000000000020
[ 11.427624] R10: ffff88800d1800a0 R11: 0000000000000018 R12: ffffc9000052f580
[ 11.428468] R13: ffff88800d180220 R14: 0000000000001000 R15: 0000000000000001
[ 11.428705] ? aesni_enc+0x13/0x20
[ 11.429027] xts_crypt+0x10f/0x340
[ 11.429349] ? lock_release+0x65/0x100
[ 11.429667] ? do_raw_spin_unlock+0x4e/0xa0
[ 11.429987] ? _raw_spin_unlock+0x23/0x40
[ 11.430312] ? lock_is_held_type+0x9d/0x110
[ 11.430471] fscrypt_crypt_block+0x268/0x320
[ 11.430627] ? mempool_alloc+0x94/0x1e0
[ 11.430803] fscrypt_encrypt_pagecache_blocks+0xde/0x150
[ 11.430991] ext4_bio_write_folio+0x371/0x500
[ 11.431172] mpage_submit_folio+0x6f/0x90
[ 11.431363] mpage_map_and_submit_buffers+0xc5/0x180
[ 11.431558] mpage_map_and_submit_extent+0x55/0x300
[ 11.431739] ext4_do_writepages+0x70d/0x810
[ 11.431981] ext4_writepages+0xf1/0x290
[ 11.432182] do_writepages+0xd2/0x1e0
[ 11.432366] ? __lock_release.isra.0+0x15e/0x2a0
[ 11.432595] __writeback_single_inode+0x54/0x300
[ 11.432817] ? do_raw_spin_unlock+0x4e/0xa0
[ 11.433006] writeback_sb_inodes+0x1fc/0x500
[ 11.433183] wb_writeback+0xf2/0x370
[ 11.433352] wb_do_writeback+0x9e/0x2e0
[ 11.433560] ? set_worker_desc+0xc7/0xd0
[ 11.433772] wb_workfn+0x6a/0x2b0
[ 11.433964] ? __lock_release.isra.0+0x15e/0x2a0
[ 11.434157] ? process_one_work+0x21b/0x540
[ 11.434322] process_one_work+0x286/0x540
[ 11.434500] worker_thread+0x53/0x3c0
[ 11.434678] ? __pfx_worker_thread+0x10/0x10
[ 11.434831] kthread+0xf2/0x130
[ 11.435042] ? __pfx_kthread+0x10/0x10
[ 11.435233] ret_from_fork+0x29/0x50
[ 11.435417] </TASK>
[ 11.435584] CR2: ffffc90003ebfe88
[ 11.435931] ---[ end trace 0000000000000000 ]---
[ 11.436101] RIP: 0010:__switch_to_asm+0x33/0x80
[ 11.436265] Code: 55 41 56 41 57 48 89 a7 d8 17 00 00 48 8b a6 d8 17 00 00 48 8b 9e 40 04 00 00 65 48 89 1c 25 28 00 00 00 49 c7 c4 10 00 00 00 <e8> 01 00 00 00 cc e8 01 00 00 00 cc 48 83 c4 10 49 ff cc 75 eb 0f
[ 11.436367] RSP: 0018:ffffc90003ec7e18 EFLAGS: 00010046
[ 11.436727] RAX: 0000000000000001 RBX: 961d22f2e2e05800 RCX: 00000002afbf75a9
[ 11.436938] RDX: 0000000000000003 RSI: ffff88800d174080 RDI: ffff88800d0ae200
[ 11.437766] RBP: ffffc90003fd7af0 R08: 0000000000000001 R09: 0000000000000001
[ 11.438000] R10: 00000000000003cc R11: 0000000000000001 R12: 0000000000000010
[ 11.438322] R13: ffffe8ffffc29c50 R14: ffff88807ddee998 R15: ffff88800d174080
[ 11.438641] FS: 0000000000000000(0000) GS:ffff88807da00000(0000) knlGS:0000000000000000
[ 11.438967] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 11.439285] CR2: ffffc90003ebfe88 CR3: 000000000c81c001 CR4: 0000000000770ef0
[ 11.439604] PKRU: 55555554
[ 12.433529] Shutting down cpus with NMI
[ 12.433728] Kernel Offset: disabled
QEMU: Terminated
next prev parent reply other threads:[~2023-06-11 5:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 10:40 [RFCv2 0/5] ext4: misc left over folio changes Ritesh Harjani (IBM)
2023-05-15 10:40 ` [RFCv2 1/5] ext4: kill unused function ext4_journalled_write_inline_data Ritesh Harjani (IBM)
2023-05-15 10:40 ` [RFCv2 2/5] ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio Ritesh Harjani (IBM)
2023-05-16 19:14 ` Matthew Wilcox
2023-06-11 5:58 ` Theodore Ts'o [this message]
2023-06-11 14:15 ` Matthew Wilcox
2023-06-11 14:25 ` Ritesh Harjani
2023-06-12 17:25 ` Ritesh Harjani
2023-06-12 17:43 ` Matthew Wilcox
2023-06-12 18:25 ` Ritesh Harjani
2023-06-12 19:16 ` Matthew Wilcox
2023-06-13 3:57 ` Ritesh Harjani
2023-06-13 9:59 ` Jan Kara
2023-06-13 19:39 ` Ritesh Harjani
2023-06-13 19:45 ` Matthew Wilcox
2023-06-13 20:43 ` Ritesh Harjani
2023-05-15 10:40 ` [RFCv2 3/5] ext4: Change remaining tracepoints to use folio Ritesh Harjani (IBM)
2023-05-15 10:40 ` [RFCv2 4/5] ext4: Make mpage_journal_page_buffers " Ritesh Harjani (IBM)
2023-05-16 19:16 ` Matthew Wilcox
2023-05-15 10:40 ` [RFCv2 5/5] ext4: Make ext4_write_inline_data_end() " Ritesh Harjani (IBM)
2023-05-16 19:27 ` [PATCH 6/5] ext4: Call fsverity_verify_folio() Matthew Wilcox (Oracle)
2023-05-17 6:45 ` Ritesh Harjani
2023-05-20 1:06 ` Eric Biggers
2023-06-09 3:14 ` [RFCv2 0/5] ext4: misc left over folio changes Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230611055831.GF1436857@mit.edu \
--to=tytso@mit.edu \
--cc=disgoel@linux.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.