All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf 1/6] netfilter: nf_tables: fix chain binding transaction logic
Date: Mon, 12 Jun 2023 10:05:41 +0200	[thread overview]
Message-ID: <20230612080541.GA2186@breakpoint.cc> (raw)
In-Reply-To: <20230611212203.1127-1-pablo@netfilter.org>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> -
> -			if (!nft_chain_is_bound(chain))
> -				break;
> -
> -			chain->table->use++;
> -			list_for_each_entry(rule, &chain->rules, list)
> -				chain->use++;
> -

Thanks for removing this, I could not find a reason why
the use count increment is required.

      parent reply	other threads:[~2023-06-12  8:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-11 21:21 [PATCH nf 1/6] netfilter: nf_tables: fix chain binding transaction logic Pablo Neira Ayuso
2023-06-11 21:21 ` [PATCH nf 2/6] netfilter: nf_tables: disallow element updates of bound anonymous sets Pablo Neira Ayuso
2023-06-11 21:22 ` [PATCH nf 3/6] netfilter: nf_tables: reject unbound anonymous set before commit phase Pablo Neira Ayuso
2023-06-11 21:22 ` [PATCH nf 4/6] netfilter: nf_tables: reject unbound chain " Pablo Neira Ayuso
2023-06-11 21:22 ` [PATCH nf 5/6] netfilter: nf_tables: disallow updates of anonymous sets Pablo Neira Ayuso
2023-06-11 21:22 ` [PATCH nf 6/6] netfilter: nf_tables: disallow timeout for " Pablo Neira Ayuso
2023-06-12  8:05 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612080541.GA2186@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.