From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1q8lD3-0001be-RW for mharc-grub-devel@gnu.org; Mon, 12 Jun 2023 13:20:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8lD2-0001bU-Cx for grub-devel@gnu.org; Mon, 12 Jun 2023 13:20:04 -0400 Received: from mx.mylinuxtime.de ([2a01:4f8:13a:16c2::25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8lD0-0005zc-H5 for grub-devel@gnu.org; Mon, 12 Jun 2023 13:20:04 -0400 Received: from leda.eworm.net (p200300CF2f201C0043C74B2bF16FC45d.dip0.t-ipconnect.de [IPv6:2003:cf:2f20:1c00:43c7:4b2b:f16f:c45d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx.mylinuxtime.de (Postfix) with ESMTPSA id 7FC7B236644; Mon, 12 Jun 2023 19:19:54 +0200 (CEST) Date: Mon, 12 Jun 2023 19:19:53 +0200 From: Christian Hesse To: Ard Biesheuvel Cc: The development of GNU GRUB , Daniel Kiper , Glenn Washburn , Robin Candau Subject: Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers Message-ID: <20230612191953.740546c8@leda.eworm.net> In-Reply-To: <20230523153145.822782-4-ardb@kernel.org> References: <20230523153145.822782-1-ardb@kernel.org> <20230523153145.822782-4-ardb@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) X-Face: %O:rCSkHSKf7^4uF|FD$9$I0}g$nbnS1{DYPvs#:,~e`).mzj\$P9]V!WCveE/XdbL,L!{)6v%x4\Bt!b#{; dS&h"7l=ow'^({02!2%XOugod|u*mYBVm-OS:VpZ"ZrRA4[Q&zye,^j; ftj!Hxx\1@; LM)Pz)|B%1#sfF; s; ,N?*K*^) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUZFRFENy6KVTKEd23CiGHeqofJvrX4+vdHgItOAAAACXBIWXMAAA3XAAAN1wFCKJt4AAACUklEQVQ4y2VUTZeqMAxNxXG2Io5uGd64L35unbF9ax0b3OLxgFs4PcLff0lBHeb1QIq5uelNCEJNq/TIFGyeC+iugH0WJr+B1MvzWASpuP4CYHOB0VfoDdddwA7OIFQIEHjXDiCtV5e9QX0WMu8AG0mB7g7WP4GqeqVdsi4vv/5kFBvaF/zD7zDquL4DxbrDGDyAsgNYOsJOYzth4Q9ZF6iLV+6TLAT1pi2kuvgAtZxSjoG8cL+8vIn251uoe1OOEWwbIPU04gHsmMsoxyyhYsD2FdIigF1yxaVbBuSOCAlCoX324I7wNMhrO1bhOLsRoA6DC6wQ5eQiSG5BiWQfM4gN+uItQTRDMaJUhVbGyKWCuaaUGSVFVKpl4PdoDn3yY8J+YxQxyhlHfoYOyPgyDcO+cSQK6Bvabjcy2nwRo3pxgA8jslnCuYw23ESOzHAPYwo4ITNQMaOO+RGPEGhSlPEZBh2jmBEjQ5cKbxmr0ruAe/WCriUxW76I8T3h7vqY5VR5wXLdERodg2rHEzdxxk5KpXTL4FwnarvndKM5/MWDY5CuBBdQ+3/0ivsUJHicuHd+Xh3jOdBL+FjSGq4SPCwco+orpWlERRTNo7BHCvbNXFVSIQMp+P5QsIL9upmr8kMTUOfxEHoanwzKRcNAe76WbjBwex/RkdHu48xT5YqP70DaMOhBcTHmAVDxLaBdle93oJy1QKFUh2GXT4am+YH/GGel1CeI98GdMXsytjCKIq/9cMrlgxFCROv+3/BU1fijNpcVD6DxE8VfLBaxUGr1D5usgDYdjwiPAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/rZZ=OAD3DRiC5W73ain2QXV"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=2a01:4f8:13a:16c2::25; envelope-from=list@eworm.de; helo=mx.mylinuxtime.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2023 17:20:05 -0000 --Sig_/rZZ=OAD3DRiC5W73ain2QXV Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Ard Biesheuvel on Tue, 2023/05/23 17:31: > Now that GCC can generate function calls using the correct calling > convention for us, we can stop using the efi_call_XX () wrappers, and > just dereference the function pointers directly. >=20 > This avoids the untyped variadic wrapper routines, which means better > type checking for the method calls. Building an Arch package from current git master makes the system unbootable with just a black screen. We did biscect this and found this commit (bb4aa6e06ee3877110a1dc0eb0d766ffac978993 in master) to be the first bad on= e. As gcc is mentioned in the commit message... We are building with gcc 13.1.1-1. Any idea what is going on here? --=20 main(a){char*c=3D/* Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/* Best regards my address: */=3D0;b=3Dc[a+= +];) putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);} --Sig_/rZZ=OAD3DRiC5W73ain2QXV Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEXHmveYAHrRp+prOviUUh18yA9HYFAmSHU7kACgkQiUUh18yA 9HaAnggA6g5vehrjDjTIHqBgZCqEOJsKpWPDeOVlV2t3m+sPhNFmYXGnIUIr2hhg H9p1SXi7RUHBYx1wQmYLlyjcZTjhf088yp28AKU6GOdQPF6eNeIEtC3F2QQVp+QO pd2dGliz1ve/0KlevY86+jwZsa5LVhlZ50yGs3xAeiSslWuiaH9rEcSSS2Hn4wTY FEOZkacqXC33r6pwmlRTHQqFIJoiwSNtoetVYu9kMSTPCd13nOn4bn4rPrG3eiEA NSziCDeZ4igxgx5uAt4tiK7neQbTWxMsBjPO6rYBi50m9kkNCeVoOh6950UgcgWf 7vP/6FIq1tSt/x0fAxyvr+FxZKRweg== =9ECZ -----END PGP SIGNATURE----- --Sig_/rZZ=OAD3DRiC5W73ain2QXV--