From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0666C7EE2E for ; Mon, 12 Jun 2023 17:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2GzMH104FtVJDqVjMGneU4GME4j7zNyZQ6ofd+QcXJ4=; b=UMuNGTcBHgjKfT RLJZh+gV7c4P6RkvzYT73+WGWSVwfYXXCzPcP28rHMFvsqmqChWnXNB4J3LECXcgb6DCr5jH6e0rU Jy5rvRraDuGCycN1l3S6jKOO4tX1vOlRIX891axIKw1hri6hVVE2Q2pOTRnku6nygMEB13xfKXj9d e9xlf9VgNmkyApuebM6sVBL0t8I94bAFuyg3+vcEGhtfY193z9AgQDe+bxC44kvr3QNOhhLHwBNnh 8aUMHlLxiBIVBYHUyWTNxG8NSvtSI+9GO9MuxAWlYQ2O4C7DfRfUsg+98gz8y25ClygmmUA4xknqz aA4HWwhM8Tq7VR/VBaLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8la4-004oqU-1r; Mon, 12 Jun 2023 17:43:52 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8la1-004op3-0b for linux-mtd@lists.infradead.org; Mon, 12 Jun 2023 17:43:51 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686591826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3yPOTXCRxjiq83JhCf8TF77n1ddicw+WEeLTca96Y34=; b=a88fHfmFvyyzdoMee7LdEDcKNqERY2G4x61EefQR8oJZ8sOq5Fx54AJjIjpkVeIFZvCy4W RibDP8Dy6qYMdYgwl3/8szxKc1tU0vNAkJbv3ddc5v2OLPdsuVCTlom+nGL8l5zNQdhCpH pjhfBugeY0katXlwaGMl73LeHj6GN12OokUlqddQz0jj00gLMAzBAn5S7SVFaDg3xLoeih +g4dAMVlyO0aoBI6q2eFlkIxHr5jG/e59JQLsbrcrHznX4QX8TjQMmUKNRhbdSn89MhVs7 0b7qs08SCanIcbUusFFFvpO58b/zuHxw+bssuXhi+hWWVPMIUDBAcR1x9ofspQ== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 286A7FF806; Mon, 12 Jun 2023 17:43:43 +0000 (UTC) Date: Mon, 12 Jun 2023 19:43:41 +0200 From: Miquel Raynal To: William Zhang Cc: Broadcom Kernel List , Linux MTD List , f.fainelli@gmail.com, rafal@milecki.pl, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, computersforpeace@gmail.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Vignesh Raghavendra , Richard Weinberger , Kamal Dasu , Rob Herring Subject: Re: [PATCH 05/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs Message-ID: <20230612194341.33820376@xps-13> In-Reply-To: References: <20230606231252.94838-1-william.zhang@broadcom.com> <20230606231252.94838-6-william.zhang@broadcom.com> <20230607101452.4c265d7e@xps-13> <84e97108-29d4-5103-14f4-03e3c0eba165@broadcom.com> <20230609105857.7256c02f@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_104349_486491_7E92D6BD X-CRM114-Status: GOOD ( 46.76 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgV2lsbGlhbSwKCndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tIHdyb3RlIG9uIEZyaSwgOSBK dW4gMjAyMyAxMjowNToxOSAtMDcwMDoKCj4gSGkgTWlxdWVsLAo+IAo+IE9uIDA2LzA5LzIwMjMg MDE6NTggQU0sIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBIaSBXaWxsaWFtLAo+ID4gCj4gPiB3 aWxsaWFtLnpoYW5nQGJyb2FkY29tLmNvbSB3cm90ZSBvbiBXZWQsIDcgSnVuIDIwMjMgMTM6MDE6 NTYgLTA3MDA6Cj4gPiAgIAo+ID4+IEhpIE1pcXVlbCwKPiA+Pgo+ID4+IE9uIDA2LzA3LzIwMjMg MDE6MTQgQU0sIE1pcXVlbCBSYXluYWwgd3JvdGU6ICAKPiA+Pj4gSGkgV2lsbGlhbSwKPiA+Pj4K PiA+Pj4gd2lsbGlhbS56aGFuZ0Bicm9hZGNvbS5jb20gd3JvdGUgb24gVHVlLCAgNiBKdW4gMjAy MyAxNjoxMjo0NSAtMDcwMDogIAo+ID4+PiAgICA+Pj4+IFVzZSBuZXcgY29tcGF0aWFibGUgYnJj bSxuYW5kLWJjbWJjYSB0byBzdXBwb3J0IEJDTUJDQSBicm9hZGJhbmQgIAo+ID4+Pj4gcHJvZHVj dC4gVGhlIG9sZCBjb21wYXRpYmxlIHN0cmluZyBpcyBzdGlsbCBrZXB0IGluIHRoZSBkcml2ZXIg c28gb2xkCj4gPj4+PiBkdGIgY2FuIHN0aWxsIHdvcmsuCj4gPj4+Pgo+ID4+Pj4gQWRkIGJyY20s bmFuZC11c2Utd3AgcHJvcGVydHkgdG8gaGF2ZSBhbiBvcHRpb24gZm9yIGRpc2FibGluZyB0aGlz Cj4gPj4+PiBmZWF0dXJlIG9uIGJyb2FkYmFuZCBib2FyZCBkZXNpZ24gdGhhdCBkb2VzIG5vdCB1 c2Ugd3JpdGUgcHJvdGVjdGlvbi4KPiA+Pj4+IEFkZCBicmNtLG5hbmQtZWNjLXVzZS1zdHJhcCB0 byBnZXQgZWNjIHNldHRpbmcgZnJvbSBib2FyZCBzdHJhcCBmb3IKPiA+Pj4+IGJyb2FkYmFuZCBi b2FyZCBkZXNpZ25zIGJlY2F1c2UgdGhleSBkbyBub3Qgc3BlY2lmeSBlY2Mgc2V0dGluZyBpbiBk dHMKPiA+Pj4+IGJ1dCByYXRoZXIgdXNpbmcgdGhlIHN0cmFwIHNldHRpbmcuCj4gPj4+Pgo+ID4+ Pj4gUmVtb3ZlIHRoZSByZXF1aXJlbWVudCBvZiBpbnRlcnJ1cHRzIGFuZCBpbnRlcnJ1cHQtbmFt ZXMgcHJvcGVydGllcyB0bwo+ID4+Pj4gcmVmbGVjdCB0aGUgZHJpdmVyIGNvZGUuCj4gPj4+Pgo+ ID4+Pj4gVGhpcyBwYXRjaCBhbHNvIGluY2x1ZGVzIGEgZmV3IG1pbm9yIGZpeGVzIHRvIHRoZSBC Q002M3h4IGNvbXBhdGlibGVzCj4gPj4+PiBhbmQgYWRkIG15c2VsZiB0byB0aGUgbGlzdCBvZiBt YWludGFpbmVycy4KPiA+Pj4+Cj4gPj4+PiBTaWduZWQtb2ZmLWJ5OiBXaWxsaWFtIFpoYW5nIDx3 aWxsaWFtLnpoYW5nQGJyb2FkY29tLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4KPiA+Pj4+ICAgIC4u Li9iaW5kaW5ncy9tdGQvYnJjbSxicmNtbmFuZC55YW1sICAgICAgICAgICB8IDY0ICsrKysrKysr KysrKystLS0tLS0KPiA+Pj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAy MSBkZWxldGlvbnMoLSkKPiA+Pj4+Cj4gPj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9icmNtLGJyY21uYW5kLnlhbWwgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvbXRkL2JyY20sYnJjbW5hbmQueWFtbAo+ID4+Pj4gaW5kZXgg MTU3MTAyNGFhMTE5Li4xZmUxYzE2NmE5ZGIgMTAwNjQ0Cj4gPj4+PiAtLS0gYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL2JyY20sYnJjbW5hbmQueWFtbAo+ID4+Pj4gKysr IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9icmNtLGJyY21uYW5kLnlh bWwKPiA+Pj4+IEBAIC05LDYgKzksNyBAQCB0aXRsZTogQnJvYWRjb20gU1RCIE5BTkQgQ29udHJv bGxlcgo+ID4+Pj4gICAgbWFpbnRhaW5lcnM6Cj4gPj4+PiAgICAgIC0gQnJpYW4gTm9ycmlzIDxj b21wdXRlcnNmb3JwZWFjZUBnbWFpbC5jb20+Cj4gPj4+PiAgICAgIC0gS2FtYWwgRGFzdSA8a2Rh c3Uua2RldkBnbWFpbC5jb20+Cj4gPj4+PiArICAtIFdpbGxpYW0gWmhhbmcgPHdpbGxpYW0uemhh bmdAYnJvYWRjb20uY29tPiAgCj4gPj4+PiAgICA+PiAgIGRlc2NyaXB0aW9uOiB8ICAKPiA+Pj4+ ICAgICAgVGhlIEJyb2FkY29tIFNldC1Ub3AgQm94IE5BTkQgY29udHJvbGxlciBzdXBwb3J0cyBs b3ctbGV2ZWwgYWNjZXNzIHRvIHJhdyBOQU5ECj4gPj4+PiBAQCAtMTgsOSArMTksMTAgQEAgZGVz Y3JpcHRpb246IHwKPiA+Pj4+ICAgICAgc3VwcG9ydHMgYmFzaWMgUFJPR1JBTSBhbmQgUkVBRCBm dW5jdGlvbnMsIGFtb25nIG90aGVyIGZlYXR1cmVzLiAgCj4gPj4+PiAgICA+PiAgICAgVGhpcyBj b250cm9sbGVyIHdhcyBvcmlnaW5hbGx5IGRlc2lnbmVkIGZvciBTVEIgU29DcyAoQkNNN3h4eCkg YnV0IGlzIG5vdyAgCj4gPj4+PiAtICBhdmFpbGFibGUgb24gYSB2YXJpZXR5IG9mIEJyb2FkY29t IFNvQ3MsIGluY2x1ZGluZyBzb21lIEJDTTN4eHgsIEJDTTYzeHgsIGFuZAo+ID4+Pj4gLSAgaVBy b2MvQ3lnbnVzLiBJdHMgaGlzdG9yeSBpbmNsdWRlcyBzZXZlcmFsIHNpbWlsYXIgKGJ1dCBub3Qg ZnVsbHkgcmVnaXN0ZXIKPiA+Pj4+IC0gIGNvbXBhdGlibGUpIHZlcnNpb25zLgo+ID4+Pj4gKyAg YXZhaWxhYmxlIG9uIGEgdmFyaWV0eSBvZiBCcm9hZGNvbSBTb0NzLCBpbmNsdWRpbmcgc29tZSBC Q00zeHh4LCBNSVBTIGJhc2VkCj4gPj4+PiArICBCcm9hZGJhbmQgU29DIChCQ002M3h4KSwgQVJN IGJhc2VkIEJyb2FkYmFuZCBTb0MgKEJDTUJDQSkgYW5kIGlQcm9jL0N5Z251cy4KPiA+Pj4+ICsg IEl0cyBoaXN0b3J5IGluY2x1ZGVzIHNldmVyYWwgc2ltaWxhciAoYnV0IG5vdCBmdWxseSByZWdp c3RlciBjb21wYXRpYmxlKQo+ID4+Pj4gKyAgdmVyc2lvbnMuICAKPiA+Pj4+ICAgID4+ICAgICAt LSBBZGRpdGlvbmFsIFNvQy1zcGVjaWZpYyBOQU5EIGNvbnRyb2xsZXIgcHJvcGVydGllcyAtLQo+ ID4+Pj4gICAgPj4gQEAgLTUzLDkgKzU1LDkgQEAgcHJvcGVydGllczogIAo+ID4+Pj4gICAgICAg ICAgICAgICAgICAtIGJyY20sYnJjbW5hbmQtdjcuMgo+ID4+Pj4gICAgICAgICAgICAgICAgICAt IGJyY20sYnJjbW5hbmQtdjcuMwo+ID4+Pj4gICAgICAgICAgICAgIC0gY29uc3Q6IGJyY20sYnJj bW5hbmQKPiA+Pj4+IC0gICAgICAtIGRlc2NyaXB0aW9uOiBCQ002MzEzOCBTb0Mtc3BlY2lmaWMg TkFORCBjb250cm9sbGVyCj4gPj4+PiArICAgICAgLSBkZXNjcmlwdGlvbjogQkNNQkNBIFNvQy1z cGVjaWZpYyBOQU5EIGNvbnRyb2xsZXIKPiA+Pj4+ICAgICAgICAgICAgaXRlbXM6Cj4gPj4+PiAt ICAgICAgICAgIC0gY29uc3Q6IGJyY20sbmFuZC1iY202MzEzOAo+ID4+Pj4gKyAgICAgICAgICAt IGNvbnN0OiBicmNtLG5hbmQtYmNtYmNhCj4gPj4+PiAgICAgICAgICAgICAgLSBlbnVtOgo+ID4+ Pj4gICAgICAgICAgICAgICAgICAtIGJyY20sYnJjbW5hbmQtdjcuMAo+ID4+Pj4gICAgICAgICAg ICAgICAgICAtIGJyY20sYnJjbW5hbmQtdjcuMQo+ID4+Pj4gQEAgLTY1LDExICs2NywxNSBAQCBw cm9wZXJ0aWVzOgo+ID4+Pj4gICAgICAgICAgICAgIC0gY29uc3Q6IGJyY20sbmFuZC1pcHJvYwo+ ID4+Pj4gICAgICAgICAgICAgIC0gY29uc3Q6IGJyY20sYnJjbW5hbmQtdjYuMQo+ID4+Pj4gICAg ICAgICAgICAgIC0gY29uc3Q6IGJyY20sYnJjbW5hbmQKPiA+Pj4+IC0gICAgICAtIGRlc2NyaXB0 aW9uOiBCQ002MzE2OCBTb0Mtc3BlY2lmaWMgTkFORCBjb250cm9sbGVyCj4gPj4+PiArICAgICAg LSBkZXNjcmlwdGlvbjogQkNNNjN4eCBTb0Mtc3BlY2lmaWMgTkFORCBjb250cm9sbGVyCj4gPj4+ PiAgICAgICAgICAgIGl0ZW1zOgo+ID4+Pj4gLSAgICAgICAgICAtIGNvbnN0OiBicmNtLG5hbmQt YmNtNjMxNjgKPiA+Pj4+IC0gICAgICAgICAgLSBjb25zdDogYnJjbSxuYW5kLWJjbTYzNjgKPiA+ Pj4+IC0gICAgICAgICAgLSBjb25zdDogYnJjbSxicmNtbmFuZC12NC4wCj4gPj4+PiArICAgICAg ICAgIC0gZW51bToKPiA+Pj4+ICsgICAgICAgICAgICAgIC0gYnJjbSxuYW5kLWJjbTYzMTY4Cj4g Pj4+PiArICAgICAgICAgICAgICAtIGJyY20sbmFuZC1iY202MzY4Cj4gPj4+PiArICAgICAgICAg IC0gZW51bToKPiA+Pj4+ICsgICAgICAgICAgICAgIC0gYnJjbSxicmNtbmFuZC12Mi4xCj4gPj4+ PiArICAgICAgICAgICAgICAtIGJyY20sYnJjbW5hbmQtdjIuMgo+ID4+Pj4gKyAgICAgICAgICAg ICAgLSBicmNtLGJyY21uYW5kLXY0LjAKPiA+Pj4+ICAgICAgICAgICAgICAtIGNvbnN0OiBicmNt LGJyY21uYW5kICAKPiA+Pj4+ICAgID4+ICAgICByZWc6ICAKPiA+Pj4+IEBAIC0xMTEsNiArMTE3 LDE5IEBAIHByb3BlcnRpZXM6Cj4gPj4+PiAgICAgICAgICBlYXJsaWVyIHZlcnNpb25zIG9mIHRo aXMgY29yZSB0aGF0IGluY2x1ZGUgV1AKPiA+Pj4+ICAgICAgICB0eXBlOiBib29sZWFuICAKPiA+ Pj4+ICAgID4+ICsgIGJyY20sbmFuZC11c2Utd3A6ICAKPiA+Pj4+ICsgICAgZGVzY3JpcHRpb246 Cj4gPj4+PiArICAgICAgVXNlIHRoaXMgaW50ZWdlciB0byBpbmRpY2F0ZSBpZiBib2FyZCBkZXNp Z24gdXNlcwo+ID4+Pj4gKyAgICAgIGNvbnRyb2xsZXIncyB3cml0ZSBwcm90ZWN0aW9uIGZlYXR1 cmUgYW5kIGNvbm5lY3RzIGl0cwo+ID4+Pj4gKyAgICAgIE5BTkRfV1BiIHBpbiB0byBuYW5kIGNo aXAncyBXUF9MIHBpbi4gRHJpdmVyIGRlZmF1bHRzIHRvCj4gPj4+PiArICAgICAgdXNlIHRoaXMg ZmVhdHVyZSB3aGVuIHRoaXMgcHJvcGVydHkgZG9lcyBub3QgZXhpc3QuCj4gPj4+PiArICAgICAg U2V0IHRvIDAgaWYgV1AgcGlucyBhcmUgbm90IGNvbm5lY3RlZCBhbmQgZmVhdHVyZSBpcyBub3QK PiA+Pj4+ICsgICAgICB1c2VkLiBTZXQgdG8gMSBpZiBXUCBwaW5zIGFyZSBjb25uZWN0ZWQgYW5k IGZlYXR1cmUgaXMgdXNlZC4KPiA+Pj4+ICsgICAgICBTZXQgdG8gMiBpZiBXUCBwaW5zIGFyZSBj b25uZWN0ZWQgYnV0IGRpc2FibGUgdGhpcyBmZWF0dXJlCj4gPj4+PiArICAgICAgdGhyb3VnaCBk cml2ZXIgdGhhdCBzZXRzIGNvbnRyb2xsZXIgdG8gb3V0cHV0IGhpZ2ggb24gTkFORF9XUGIuCj4g Pj4+PiArICAgICRyZWY6IC9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRpb25zL3VpbnQzMgo+ ID4+Pj4gKyAgICBlbnVtOiBbMCwgMSwgMl0gIAo+ID4+Pgo+ID4+PiBQZXJoYXBzIHN0cmluZ3Mg d291bGQgYmUgd2VsY29tZS4gSSdsbCBsZXQgYmluZGluZyBtYWludGFpbmVycyBzYXkgd2hhdAo+ ID4+PiB0aGV5IHRoaW5rIG9mIGl0LiAgCj4gPj4+ICAgID4+IFByYWN0aWNhbGx5IHRoZXJlIGlz IHJlYWxseSBqdXN0IHVzZSBjYXNlcyBvZiAwIGFuZCAxLiBJIGNvdWxkIHVzZSBhIGJvb2wgZmxh ZyBidXQgdG8ga2VlcCBjb25zaXN0ZW50IHdpdGggdGhlIGRyaXZlciBjb2RlIGFuZCBpbiBjYXNl IHRoZXJlIGlzIGFueSBleGlzdGluZyB1c2FnZSBvZiAyLiAgCj4gPj4gIAo+ID4+Pj4gKwo+ID4+ Pj4gICAgcGF0dGVyblByb3BlcnRpZXM6Cj4gPj4+PiAgICAgICJebmFuZEBbYS1mMC05XSQiOgo+ ID4+Pj4gICAgICAgIHR5cGU6IG9iamVjdAo+ID4+Pj4gQEAgLTEzNiwxMyArMTU1LDIzIEBAIHBh dHRlcm5Qcm9wZXJ0aWVzOgo+ID4+Pj4gICAgICAgICAgICAgIGxheW91dC4KPiA+Pj4+ICAgICAg ICAgICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvdWludDMyICAKPiA+ Pj4+ICAgID4+ICsgICAgICBicmNtLG5hbmQtZWNjLXVzZS1zdHJhcDogIAo+ID4+Pj4gKyAgICAg ICAgZGVzY3JpcHRpb246Cj4gPj4+PiArICAgICAgICAgIFRoaXMgZmxhZyBpcyB1c2VkIGJ5IHRo ZSBkcml2ZXIgdG8gZ2V0IHRoZSBlY2Mgc3RyZW5ndGggYW5kCj4gPj4+PiArICAgICAgICAgIHNw YXJlIGFyZWEgc2l6ZSBmcm9tIHRoZSBTb0MgTkFORCBib290IHN0cmFwIHNldHRpbmcuIFRoaXMK PiA+Pj4+ICsgICAgICAgICAgaXMgY29tbW9ubHkgdXNlZCBieSB0aGUgQkNNQkNBIFNvQyBib2Fy ZCBkZXNpZ24uIElmIGVjYwo+ID4+Pj4gKyAgICAgICAgICBzdHJlbmd0aCBhbmQgc3BhcmUgYXJl YSBzaXplIGFyZSBzZXQgYnkgbmFuZC1lY2Mtc3RyZW5ndGgKPiA+Pj4+ICsgICAgICAgICAgYW5k IGJyY20sbmFuZC1vb2Itc2VjdG9yLXNpemUgaW4gdGhlIGR0cywgdGhlc2Ugc2V0dGluZ3MKPiA+ Pj4+ICsgICAgICAgICAgaGF2ZSBwcmVjZWRlbmNlIGFuZCBvdmVycmlkZSB0aGlzIGZsYWcuCj4g Pj4+PiArICAgICAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy9mbGFn ICAKPiA+Pj4KPiA+Pj4gSG93IGluIHByYWN0aWNlIGRvIHlvdSBhY2Nlc3MgdGhlIHN0cmFwIHZh bHVlPyBEb24ndCB5b3UgbmVlZCBhIHBoYW5kbGUKPiA+Pj4gb3ZlciBhIHNwZWNpZmljIGFyZWEg aW4gdGhlIFNvQz8gIAo+ID4+PiAgICA+PiBUaGUgc3RyYXAgdmFsdWUgaXMgbGF0Y2hlZCBhbmQg c3RvcmVkIGluIHRoZSBOQU5EIGNvbnRyb2xsZXIgcmVnaXN0ZXIgc28gdGhlcmUgaXMgbm8gZXh0 cmEgcGhhbmRsZSBuZWVkZWQuICAKPiA+IAo+ID4gT2suCj4gPiAgIAo+ID4+ICAKPiA+Pj4+ICsK PiA+Pj4+ICAgIGFsbE9mOgo+ID4+Pj4gICAgICAtICRyZWY6IG5hbmQtY29udHJvbGxlci55YW1s Iwo+ID4+Pj4gICAgICAtIGlmOgo+ID4+Pj4gICAgICAgICAgcHJvcGVydGllczoKPiA+Pj4+ICAg ICAgICAgICAgY29tcGF0aWJsZToKPiA+Pj4+ICAgICAgICAgICAgICBjb250YWluczoKPiA+Pj4+ IC0gICAgICAgICAgICBjb25zdDogYnJjbSxuYW5kLWJjbTYzMTM4Cj4gPj4+PiArICAgICAgICAg ICAgY29uc3Q6IGJyY20sbmFuZC1iY21iY2EKPiA+Pj4+ICAgICAgICB0aGVuOgo+ID4+Pj4gICAg ICAgICAgcHJvcGVydGllczoKPiA+Pj4+ICAgICAgICAgICAgcmVnLW5hbWVzOgo+ID4+Pj4gQEAg LTE1Myw3ICsxODIsOSBAQCBhbGxPZjoKPiA+Pj4+ICAgICAgICAgIHByb3BlcnRpZXM6Cj4gPj4+ PiAgICAgICAgICAgIGNvbXBhdGlibGU6Cj4gPj4+PiAgICAgICAgICAgICAgY29udGFpbnM6Cj4g Pj4+PiAtICAgICAgICAgICAgY29uc3Q6IGJyY20sbmFuZC1iY202MzY4Cj4gPj4+PiArICAgICAg ICAgICAgZW51bToKPiA+Pj4+ICsgICAgICAgICAgICAgIC0gYnJjbSxuYW5kLWJjbTYzMTY4Cj4g Pj4+PiArICAgICAgICAgICAgICAtIGJyY20sbmFuZC1iY202MzY4Cj4gPj4+PiAgICAgICAgdGhl bjoKPiA+Pj4+ICAgICAgICAgIHByb3BlcnRpZXM6Cj4gPj4+PiAgICAgICAgICAgIHJlZy1uYW1l czoKPiA+Pj4+IEBAIC0xNzMsMjAgKzIwNCwxMiBAQCBhbGxPZjoKPiA+Pj4+ICAgICAgICAgICAg ICAgIC0gY29uc3Q6IG5hbmQKPiA+Pj4+ICAgICAgICAgICAgICAgIC0gY29uc3Q6IGlwcm9jLWlk bQo+ID4+Pj4gICAgICAgICAgICAgICAgLSBjb25zdDogaXByb2MtZXh0Cj4gPj4+PiAtICAtIGlm Ogo+ID4+Pj4gLSAgICAgIHByb3BlcnRpZXM6Cj4gPj4+PiAtICAgICAgICBpbnRlcnJ1cHRzOgo+ ID4+Pj4gLSAgICAgICAgICBtaW5JdGVtczogMgo+ID4+Pj4gLSAgICB0aGVuOgo+ID4+Pj4gLSAg ICAgIHJlcXVpcmVkOgo+ID4+Pj4gLSAgICAgICAgLSBpbnRlcnJ1cHQtbmFtZXMgIAo+ID4+Pgo+ ID4+PiBXaHkgZG8geW91IHJlbW92ZSB0aGlzPyBSZW1vdmluZyAiaW50ZXJydXB0cyIgZnJvbSB0 aGUgcmVxdWlyZWQKPiA+Pj4gcHJvcGVydGllcyBpcyBmaW5lLCBidXQgY29uc3RyYWluaW5nIHRo ZSBpbnRlcnJ1cHRzIHByb3BlcnR5IHdoZW4gaXQgaXMKPiA+Pj4gcmVsZXZhbnQgaXMgc3RpbGwg ZXhwZWN0ZWQuICAKPiA+Pj4gICAgPj4gVGhlcmUgaXMgbm8gcmVxdWlyZW1lbnQgZm9yIGludGVy cnVwdCBuYW1lIGV2ZW4gaWYgaXQgaGF2ZSB0d28gaW50ZXJydXB0cy4gRHJpdmVyIGNvZGUgZG9l cyBub3QgdXNlIGludGVycnVwdCBuYW1lIGJ1dCB0aGUgaW50ZXJydXB0IGluZGV4IGluc3RlYWQu ICAKPiA+IAo+ID4gSXQgZG9lcyBub3QgbWF0dGVyIGluIHRoaXMgY2FzZSBob3cgdGhlIGRyaXZl ciB1c2VzIHRoZSBpbnRlcnJ1cHRzLiBJZgo+ID4gbmFtZXMgaGF2ZSBiZWVuIHByb3ZpZGVkIG9u Y2UgaW4gdGhlIGJpbmRpbmdzLCB5b3UgY291bGQgZXhwZWN0IGFub3RoZXIKPiA+IHByb2plY3Qg dXNpbmcgdGhlIHNhbWUgYmluZGluZ3MgdG8gdXNlIHRoZSBpbnRlcnJ1cHQgbmFtZXMgaW5zdGVh ZCBvZgo+ID4gdGhlIG9yZGVyLiBTbyB5b3UgbXVzdCBrZWVwIHRoZSBuYW1lcy4gSnVzdCBkb24n dCBtYXJrIHRoZW0gcmVxdWlyZWQgaXQKPiA+IHRoZXkgYXJlLgo+ID4gICAKPiBDZXJ0YWlubHkg YW55IGR0cyBmaWxlIGNhbiBzdGlsbCBoYXZlIGludGVycnVwdHMgbmFtZXMgd2l0aCBvbmUgb3Ig dHdvIGludGVycnVwdHMgYnV0IHRvIG15IHVuZGVyc3RhbmQgaXQgaXMgbm90IHJlcXVpcmVkIHRv IGhhdmUgdGhlIG5hbWUgd2hlbiB0aGVyZSBhcmUgdHdvIGludGVycnVwdHMuIEFueXdheSBJIHdp bGwgYWRkIHRoaXMgYmFjayBzbyB0aGlzIGNvbnN0cmFpbiByZW1haW5zLgoKVGhhdCBpcyB0cnVl LCB1bnRpbCB5b3UgZW5mb3JjZSBzcGVjaWZpYyBuYW1lcy4gVGhlbiB5b3UgYXJlIHRpZWQgdG8K dGhlc2UgbmFtZXMsIG90aGVyd2lzZSB5b3UgbWF5IGJyZWFrIHRoZSBiaW5kaW5ncy4gSXQgaXQg aXMgbm90Cl9yZWFsbHlfIHVzZWZ1bCwgdGhlbiBkb24ndCBkbyBpdC4KCj4gCj4gPj4gIAo+ID4+ Pj4gICAgPj4gICB1bmV2YWx1YXRlZFByb3BlcnRpZXM6IGZhbHNlCj4gPj4+PiAgICA+PiAgIHJl cXVpcmVkOiAgCj4gPj4+PiAgICAgIC0gcmVnCj4gPj4+PiAgICAgIC0gcmVnLW5hbWVzCj4gPj4+ PiAtICAtIGludGVycnVwdHMgIAo+ID4+Pgo+ID4+PiBUaGlzIHNob3VsZCBiZSBkb25lIGluIGEg c2VwYXJhdGUgcGF0Y2guICAKPiA+Pj4gICAgPj4gSSB0aG91Z2h0IHRoaXMgaXMgYWxzbyByZWxh dGVkIHRvIG15IHVwZGF0ZSBmb3IgYmNtYmNhIGNoaXBzIGJlY2F1c2UgdGhleSBkb24ndCBuZWVk IHRvIGludGVycnVwdCBhbmQgaW50ZXJydXB0IG5hbWUuICAKPiA+IAo+ID4gVGhlIGZhY3QgdGhh dCB0aGUgZHJpdmVyIGRvZXMgbm90IHVzZSB0aGUgaW50ZXJydXB0cyBkb2VzIG5vdCBtZWFuIHRo ZXkKPiA+IHNob3VsZCBub3QgYmUgZGVzY3JpYmVkLgo+ID4gICAKPiA+PiAgCj4gPj4+PiAgICA+ PiAgIGV4YW1wbGVzOiAgCj4gPj4+PiAgICAgIC0gfAo+ID4+Pj4gQEAgLTIxNSw4ICsyMzgsNyBA QCBleGFtcGxlczoKPiA+Pj4+ICAgICAgICB9Owo+ID4+Pj4gICAgICAtIHwKPiA+Pj4+ICAgICAg ICBuYW5kLWNvbnRyb2xsZXJAMTAwMDAyMDAgewo+ID4+Pj4gLSAgICAgICAgY29tcGF0aWJsZSA9 ICJicmNtLG5hbmQtYmNtNjMxNjgiLCAiYnJjbSxuYW5kLWJjbTYzNjgiLAo+ID4+Pj4gLSAgICAg ICAgICAgICAgICAgICAgICJicmNtLGJyY21uYW5kLXY0LjAiLCAiYnJjbSxicmNtbmFuZCI7Cj4g Pj4+PiArICAgICAgICBjb21wYXRpYmxlID0gImJyY20sbmFuZC1iY202MzY4IiwgImJyY20sYnJj bW5hbmQtdjIuMSIsICJicmNtLGJyY21uYW5kIjsKPiA+Pj4+ICAgICAgICAgICAgcmVnID0gPDB4 MTAwMDAyMDAgMHgxODA+LAo+ID4+Pj4gICAgICAgICAgICAgICAgICA8MHgxMDAwMDBiMCAweDEw PiwKPiA+Pj4+ICAgICAgICAgICAgICAgICAgPDB4MTAwMDA2MDAgMHgyMDA+OyAgCj4gPj4+Cj4g Pj4+Cj4gPj4+IFRoYW5rcywKPiA+Pj4gTWlxdcOobCAgCj4gPj4+ICAgID4gPiAgIAo+ID4gVGhh bmtzLAo+ID4gTWlxdcOobAo+ID4gICAKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vz c2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 884FAC88CB4 for ; Mon, 12 Jun 2023 17:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234475AbjFLRnx (ORCPT ); Mon, 12 Jun 2023 13:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234490AbjFLRnv (ORCPT ); Mon, 12 Jun 2023 13:43:51 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B88281A5; Mon, 12 Jun 2023 10:43:47 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686591826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3yPOTXCRxjiq83JhCf8TF77n1ddicw+WEeLTca96Y34=; b=a88fHfmFvyyzdoMee7LdEDcKNqERY2G4x61EefQR8oJZ8sOq5Fx54AJjIjpkVeIFZvCy4W RibDP8Dy6qYMdYgwl3/8szxKc1tU0vNAkJbv3ddc5v2OLPdsuVCTlom+nGL8l5zNQdhCpH pjhfBugeY0katXlwaGMl73LeHj6GN12OokUlqddQz0jj00gLMAzBAn5S7SVFaDg3xLoeih +g4dAMVlyO0aoBI6q2eFlkIxHr5jG/e59JQLsbrcrHznX4QX8TjQMmUKNRhbdSn89MhVs7 0b7qs08SCanIcbUusFFFvpO58b/zuHxw+bssuXhi+hWWVPMIUDBAcR1x9ofspQ== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 286A7FF806; Mon, 12 Jun 2023 17:43:43 +0000 (UTC) Date: Mon, 12 Jun 2023 19:43:41 +0200 From: Miquel Raynal To: William Zhang Cc: Broadcom Kernel List , Linux MTD List , f.fainelli@gmail.com, rafal@milecki.pl, kursad.oney@broadcom.com, joel.peshkin@broadcom.com, computersforpeace@gmail.com, anand.gore@broadcom.com, dregan@mail.com, kamal.dasu@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Vignesh Raghavendra , Richard Weinberger , Kamal Dasu , Rob Herring Subject: Re: [PATCH 05/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs Message-ID: <20230612194341.33820376@xps-13> In-Reply-To: References: <20230606231252.94838-1-william.zhang@broadcom.com> <20230606231252.94838-6-william.zhang@broadcom.com> <20230607101452.4c265d7e@xps-13> <84e97108-29d4-5103-14f4-03e3c0eba165@broadcom.com> <20230609105857.7256c02f@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi William, william.zhang@broadcom.com wrote on Fri, 9 Jun 2023 12:05:19 -0700: > Hi Miquel, >=20 > On 06/09/2023 01:58 AM, Miquel Raynal wrote: > > Hi William, > >=20 > > william.zhang@broadcom.com wrote on Wed, 7 Jun 2023 13:01:56 -0700: > > =20 > >> Hi Miquel, > >> > >> On 06/07/2023 01:14 AM, Miquel Raynal wrote: =20 > >>> Hi William, > >>> > >>> william.zhang@broadcom.com wrote on Tue, 6 Jun 2023 16:12:45 -0700: = =20 > >>> >>>> Use new compatiable brcm,nand-bcmbca to support BCMBCA broadb= and =20 > >>>> product. The old compatible string is still kept in the driver so old > >>>> dtb can still work. > >>>> > >>>> Add brcm,nand-use-wp property to have an option for disabling this > >>>> feature on broadband board design that does not use write protection. > >>>> Add brcm,nand-ecc-use-strap to get ecc setting from board strap for > >>>> broadband board designs because they do not specify ecc setting in d= ts > >>>> but rather using the strap setting. > >>>> > >>>> Remove the requirement of interrupts and interrupt-names properties = to > >>>> reflect the driver code. > >>>> > >>>> This patch also includes a few minor fixes to the BCM63xx compatibles > >>>> and add myself to the list of maintainers. > >>>> > >>>> Signed-off-by: William Zhang > >>>> --- > >>>> > >>>> .../bindings/mtd/brcm,brcmnand.yaml | 64 +++++++++++++-= ----- > >>>> 1 file changed, 43 insertions(+), 21 deletions(-) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yam= l b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > >>>> index 1571024aa119..1fe1c166a9db 100644 > >>>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > >>>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > >>>> @@ -9,6 +9,7 @@ title: Broadcom STB NAND Controller > >>>> maintainers: > >>>> - Brian Norris > >>>> - Kamal Dasu > >>>> + - William Zhang =20 > >>>> >> description: | =20 > >>>> The Broadcom Set-Top Box NAND controller supports low-level acc= ess to raw NAND > >>>> @@ -18,9 +19,10 @@ description: | > >>>> supports basic PROGRAM and READ functions, among other features= . =20 > >>>> >> This controller was originally designed for STB SoCs (BCM7= xxx) but is now =20 > >>>> - available on a variety of Broadcom SoCs, including some BCM3xxx, = BCM63xx, and > >>>> - iProc/Cygnus. Its history includes several similar (but not fully= register > >>>> - compatible) versions. > >>>> + available on a variety of Broadcom SoCs, including some BCM3xxx, = MIPS based > >>>> + Broadband SoC (BCM63xx), ARM based Broadband SoC (BCMBCA) and iPr= oc/Cygnus. > >>>> + Its history includes several similar (but not fully register comp= atible) > >>>> + versions. =20 > >>>> >> -- Additional SoC-specific NAND controller properties -- > >>>> >> @@ -53,9 +55,9 @@ properties: =20 > >>>> - brcm,brcmnand-v7.2 > >>>> - brcm,brcmnand-v7.3 > >>>> - const: brcm,brcmnand > >>>> - - description: BCM63138 SoC-specific NAND controller > >>>> + - description: BCMBCA SoC-specific NAND controller > >>>> items: > >>>> - - const: brcm,nand-bcm63138 > >>>> + - const: brcm,nand-bcmbca > >>>> - enum: > >>>> - brcm,brcmnand-v7.0 > >>>> - brcm,brcmnand-v7.1 > >>>> @@ -65,11 +67,15 @@ properties: > >>>> - const: brcm,nand-iproc > >>>> - const: brcm,brcmnand-v6.1 > >>>> - const: brcm,brcmnand > >>>> - - description: BCM63168 SoC-specific NAND controller > >>>> + - description: BCM63xx SoC-specific NAND controller > >>>> items: > >>>> - - const: brcm,nand-bcm63168 > >>>> - - const: brcm,nand-bcm6368 > >>>> - - const: brcm,brcmnand-v4.0 > >>>> + - enum: > >>>> + - brcm,nand-bcm63168 > >>>> + - brcm,nand-bcm6368 > >>>> + - enum: > >>>> + - brcm,brcmnand-v2.1 > >>>> + - brcm,brcmnand-v2.2 > >>>> + - brcm,brcmnand-v4.0 > >>>> - const: brcm,brcmnand =20 > >>>> >> reg: =20 > >>>> @@ -111,6 +117,19 @@ properties: > >>>> earlier versions of this core that include WP > >>>> type: boolean =20 > >>>> >> + brcm,nand-use-wp: =20 > >>>> + description: > >>>> + Use this integer to indicate if board design uses > >>>> + controller's write protection feature and connects its > >>>> + NAND_WPb pin to nand chip's WP_L pin. Driver defaults to > >>>> + use this feature when this property does not exist. > >>>> + Set to 0 if WP pins are not connected and feature is not > >>>> + used. Set to 1 if WP pins are connected and feature is used. > >>>> + Set to 2 if WP pins are connected but disable this feature > >>>> + through driver that sets controller to output high on NAND_WP= b. > >>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>> + enum: [0, 1, 2] =20 > >>> > >>> Perhaps strings would be welcome. I'll let binding maintainers say wh= at > >>> they think of it. =20 > >>> >> Practically there is really just use cases of 0 and 1. I could = use a bool flag but to keep consistent with the driver code and in case the= re is any existing usage of 2. =20 > >> =20 > >>>> + > >>>> patternProperties: > >>>> "^nand@[a-f0-9]$": > >>>> type: object > >>>> @@ -136,13 +155,23 @@ patternProperties: > >>>> layout. > >>>> $ref: /schemas/types.yaml#/definitions/uint32 =20 > >>>> >> + brcm,nand-ecc-use-strap: =20 > >>>> + description: > >>>> + This flag is used by the driver to get the ecc strength a= nd > >>>> + spare area size from the SoC NAND boot strap setting. This > >>>> + is commonly used by the BCMBCA SoC board design. If ecc > >>>> + strength and spare area size are set by nand-ecc-strength > >>>> + and brcm,nand-oob-sector-size in the dts, these settings > >>>> + have precedence and override this flag. > >>>> + $ref: /schemas/types.yaml#/definitions/flag =20 > >>> > >>> How in practice do you access the strap value? Don't you need a phand= le > >>> over a specific area in the SoC? =20 > >>> >> The strap value is latched and stored in the NAND controller re= gister so there is no extra phandle needed. =20 > >=20 > > Ok. > > =20 > >> =20 > >>>> + > >>>> allOf: > >>>> - $ref: nand-controller.yaml# > >>>> - if: > >>>> properties: > >>>> compatible: > >>>> contains: > >>>> - const: brcm,nand-bcm63138 > >>>> + const: brcm,nand-bcmbca > >>>> then: > >>>> properties: > >>>> reg-names: > >>>> @@ -153,7 +182,9 @@ allOf: > >>>> properties: > >>>> compatible: > >>>> contains: > >>>> - const: brcm,nand-bcm6368 > >>>> + enum: > >>>> + - brcm,nand-bcm63168 > >>>> + - brcm,nand-bcm6368 > >>>> then: > >>>> properties: > >>>> reg-names: > >>>> @@ -173,20 +204,12 @@ allOf: > >>>> - const: nand > >>>> - const: iproc-idm > >>>> - const: iproc-ext > >>>> - - if: > >>>> - properties: > >>>> - interrupts: > >>>> - minItems: 2 > >>>> - then: > >>>> - required: > >>>> - - interrupt-names =20 > >>> > >>> Why do you remove this? Removing "interrupts" from the required > >>> properties is fine, but constraining the interrupts property when it = is > >>> relevant is still expected. =20 > >>> >> There is no requirement for interrupt name even if it have two = interrupts. Driver code does not use interrupt name but the interrupt index= instead. =20 > >=20 > > It does not matter in this case how the driver uses the interrupts. If > > names have been provided once in the bindings, you could expect another > > project using the same bindings to use the interrupt names instead of > > the order. So you must keep the names. Just don't mark them required it > > they are. > > =20 > Certainly any dts file can still have interrupts names with one or two in= terrupts but to my understand it is not required to have the name when ther= e are two interrupts. Anyway I will add this back so this constrain remains. That is true, until you enforce specific names. Then you are tied to these names, otherwise you may break the bindings. It it is not _really_ useful, then don't do it. >=20 > >> =20 > >>>> >> unevaluatedProperties: false > >>>> >> required: =20 > >>>> - reg > >>>> - reg-names > >>>> - - interrupts =20 > >>> > >>> This should be done in a separate patch. =20 > >>> >> I thought this is also related to my update for bcmbca chips be= cause they don't need to interrupt and interrupt name. =20 > >=20 > > The fact that the driver does not use the interrupts does not mean they > > should not be described. > > =20 > >> =20 > >>>> >> examples: =20 > >>>> - | > >>>> @@ -215,8 +238,7 @@ examples: > >>>> }; > >>>> - | > >>>> nand-controller@10000200 { > >>>> - compatible =3D "brcm,nand-bcm63168", "brcm,nand-bcm6368", > >>>> - "brcm,brcmnand-v4.0", "brcm,brcmnand"; > >>>> + compatible =3D "brcm,nand-bcm6368", "brcm,brcmnand-v2.1", "= brcm,brcmnand"; > >>>> reg =3D <0x10000200 0x180>, > >>>> <0x100000b0 0x10>, > >>>> <0x10000600 0x200>; =20 > >>> > >>> > >>> Thanks, > >>> Miqu=C3=A8l =20 > >>> > > =20 > > Thanks, > > Miqu=C3=A8l > > =20 Thanks, Miqu=C3=A8l