From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D938C7EE2E for ; Mon, 12 Jun 2023 20:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232633AbjFLUSD (ORCPT ); Mon, 12 Jun 2023 16:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjFLUR5 (ORCPT ); Mon, 12 Jun 2023 16:17:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B656EDB for ; Mon, 12 Jun 2023 13:17:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C40262554 for ; Mon, 12 Jun 2023 20:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E79BC433EF; Mon, 12 Jun 2023 20:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686601075; bh=FcuQpZv0UEta4X+Bjsy81UtPnBwbFb8SzDr1J7Zz1NY=; h=Date:To:From:Subject:From; b=NbvBpCgjIZZYfTmtaxW7mZAGD1VxMqnCLGayOP2LyLqhPSIyXL4XwJzev9H670ETx r71hDYuKAnyicYaTeH5DPK36k0RY8vCzgwLNrSSC6V3a/P8tydWvPuTvk0KrcQkJ85 q02UMuJcktt+1zDzEhH54l7jVs0VA2ILgWImvcLw= Date: Mon, 12 Jun 2023 13:17:54 -0700 To: mm-commits@vger.kernel.org, yuzhao@google.com, willy@infradead.org, viro@zeniv.linux.org.uk, vincenzo.frascino@arm.com, urezki@gmail.com, sj@kernel.org, shakeelb@google.com, ryabinin.a.a@gmail.com, rppt@kernel.org, roman.gushchin@linux.dev, pasha.tatashin@soleen.com, oleksandr_tyshchenko@epam.com, naoya.horiguchi@nec.com, namhyung@kernel.org, muchun.song@linux.dev, mike.kravetz@oracle.com, mhocko@kernel.org, mark.rutland@arm.com, lstoakes@gmail.com, lkp@intel.com, linmiaohe@huawei.com, kirill.shutemov@linux.intel.com, jolsa@kernel.org, jglisse@redhat.com, jgg@ziepe.ca, irogers@google.com, hch@infradead.org, hannes@cmpxchg.org, glider@google.com, dvyukov@google.com, dimitri.sivanich@hpe.com, daniel@ffwll.ch, brauner@kernel.org, andreyknvl@gmail.com, alex.williamson@redhat.com, alexander.shishkin@linux.intel.com, airlied@gmail.com, adrian.hunter@intel.com, ryan.roberts@arm.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-move-ptep_get-and-pmdp_get-helpers.patch added to mm-unstable branch Message-Id: <20230612201755.8E79BC433EF@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm: move ptep_get() and pmdp_get() helpers has been added to the -mm mm-unstable branch. Its filename is mm-move-ptep_get-and-pmdp_get-helpers.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-move-ptep_get-and-pmdp_get-helpers.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Ryan Roberts Subject: mm: move ptep_get() and pmdp_get() helpers Date: Mon, 12 Jun 2023 16:15:44 +0100 There are many call sites that directly dereference a pte_t pointer. This makes it very difficult to properly encapsulate a page table in the arch code without having to allocate shadow page tables. We will shortly solve this by replacing all the call sites with ptep_get() calls. But there are call sites above the function definition in the header file, so let's move ptep_get() to an earlier location to solve that problem. And move pmdp_get() at the same time to keep it close to ptep_get(). Link: https://lkml.kernel.org/r/20230612151545.3317766-3-ryan.roberts@arm.com Signed-off-by: Ryan Roberts Cc: Adrian Hunter Cc: Alexander Potapenko Cc: Alexander Shishkin Cc: Alex Williamson Cc: Al Viro Cc: Andrey Konovalov Cc: Andrey Ryabinin Cc: Christian Brauner Cc: Christoph Hellwig Cc: Daniel Vetter Cc: Dave Airlie Cc: Dimitri Sivanich Cc: Dmitry Vyukov Cc: Ian Rogers Cc: Jason Gunthorpe Cc: Jérôme Glisse Cc: Jiri Olsa Cc: Johannes Weiner Cc: kernel test robot Cc: Kirill A. Shutemov Cc: Lorenzo Stoakes Cc: Mark Rutland Cc: Matthew Wilcox Cc: Miaohe Lin Cc: Michal Hocko Cc: Mike Kravetz Cc: Mike Rapoport (IBM) Cc: Muchun Song Cc: Namhyung Kim Cc: Naoya Horiguchi Cc: Oleksandr Tyshchenko Cc: Pavel Tatashin Cc: Roman Gushchin Cc: SeongJae Park Cc: Shakeel Butt Cc: Uladzislau Rezki (Sony) Cc: Vincenzo Frascino Cc: Yu Zhao Signed-off-by: Andrew Morton --- include/linux/pgtable.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) --- a/include/linux/pgtable.h~mm-move-ptep_get-and-pmdp_get-helpers +++ a/include/linux/pgtable.h @@ -212,6 +212,20 @@ static inline int pudp_set_access_flags( #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif +#ifndef ptep_get +static inline pte_t ptep_get(pte_t *ptep) +{ + return READ_ONCE(*ptep); +} +#endif + +#ifndef pmdp_get +static inline pmd_t pmdp_get(pmd_t *pmdp) +{ + return READ_ONCE(*pmdp); +} +#endif + #ifndef __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG static inline int ptep_test_and_clear_young(struct vm_area_struct *vma, unsigned long address, @@ -317,20 +331,6 @@ static inline void ptep_clear(struct mm_ ptep_get_and_clear(mm, addr, ptep); } -#ifndef ptep_get -static inline pte_t ptep_get(pte_t *ptep) -{ - return READ_ONCE(*ptep); -} -#endif - -#ifndef pmdp_get -static inline pmd_t pmdp_get(pmd_t *pmdp) -{ - return READ_ONCE(*pmdp); -} -#endif - #ifdef CONFIG_GUP_GET_PXX_LOW_HIGH /* * For walking the pagetables without holding any locks. Some architectures _ Patches currently in -mm which might be from ryan.roberts@arm.com are mm-ptdump-should-use-ptep_get_lockless.patch mm-move-ptep_get-and-pmdp_get-helpers.patch mm-ptep_get-conversion.patch