From: Christoph Hellwig <hch@lst.de>
To: mwilck@suse.com
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
James Bottomley <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
Karan Tilak Kumar <kartilak@cisco.com>,
Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH v5 6/7] scsi: replace scsi_target_block() by scsi_block_targets()
Date: Tue, 13 Jun 2023 06:36:01 +0200 [thread overview]
Message-ID: <20230613043601.GC13400@lst.de> (raw)
In-Reply-To: <20230612165049.29440-7-mwilck@suse.com>
> +scsi_block_targets(struct device *dev, struct Scsi_Host *shost)
I think the logical argument order would be to pass the shost first.
> -extern void scsi_target_block(struct device *);
> +extern void scsi_block_targets(struct device *dev, struct Scsi_Host *shost);
And please drop the pointless extern here.
With that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-13 4:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 16:50 [PATCH v5 0/7] scsi: fixes for targets with many LUNs, and scsi_target_block rework mwilck
2023-06-12 16:50 ` [PATCH v5 1/7] bsg: increase number of devices mwilck
2023-06-12 16:50 ` [PATCH v5 2/7] scsi: sg: " mwilck
2023-06-12 16:50 ` [PATCH v5 3/7] scsi: merge scsi_internal_device_block() and device_block() mwilck
2023-06-12 18:00 ` Bart Van Assche
2023-06-13 10:42 ` Martin Wilck
2023-06-12 16:50 ` [PATCH v5 4/7] scsi: don't wait for quiesce in scsi_stop_queue() mwilck
2023-06-12 18:02 ` Bart Van Assche
2023-06-13 10:57 ` Martin Wilck
2023-06-13 4:33 ` Christoph Hellwig
2023-06-12 16:50 ` [PATCH v5 5/7] scsi: don't wait for quiesce in scsi_device_block() mwilck
2023-06-12 18:03 ` Bart Van Assche
2023-06-13 4:34 ` Christoph Hellwig
2023-06-12 16:50 ` [PATCH v5 6/7] scsi: replace scsi_target_block() by scsi_block_targets() mwilck
2023-06-12 18:09 ` Bart Van Assche
2023-06-13 4:36 ` Christoph Hellwig [this message]
2023-06-12 16:50 ` [PATCH v5 7/7] scsi: improve warning message in scsi_device_block() mwilck
2023-06-12 18:11 ` Bart Van Assche
2023-06-13 4:36 ` Christoph Hellwig
2023-06-13 6:10 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613043601.GC13400@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mwilck@suse.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.