From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 630B3C88CB4 for ; Tue, 13 Jun 2023 12:29:00 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 8D41271C86 for ; Tue, 13 Jun 2023 12:28:59 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 7977898656B for ; Tue, 13 Jun 2023 12:28:59 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 698FF9842EA; Tue, 13 Jun 2023 12:28:59 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 571A198653E for ; Tue, 13 Jun 2023 12:28:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: TkEZT-F2Py2SCsuSCnRfWg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686659336; x=1689251336; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BiC77W5gyOBCkJoRmSdi/XUYsC6FD/kKSJstFmghc34=; b=hx7dP4ale93HnFEaiL+oJpDf3VZYO0+bn6Xtfdx8sJIXX0Ppa4U1+mPJD/nVyFWfZi hmbrZfzOL09fYyzfJ8NJpjlguo19JdpE+mzCsMB5HHVaoqpOi3Hy8x4xuSCWUnsWDAVZ tZESm/PzTJBcYljh5pLtuDEyg5EEsDqENGws+ueEr/dils/nox6iwy+iX/ZglUITEohO 7H6O3cwtcJ+UM5VRtyG262OwfoosphcfMSpfVg/HKaBlAJDjmDtHZSwR4DNV7Qo35Lov jxBZk5gYXP9/bDJoPtLdXnvkZCSvuGp4fWExKB0mYxuRFqt2pPvavCnyqFM1AHpDyhJd epIw== X-Gm-Message-State: AC+VfDwhDneXn5NXtdtHWBYGE8ku1i3r/CfR/1TLeD1yrV73IgRaUiGf CdUs8sylpeHGNOFNJdejxayDOl4A+RTCWGHD5vV0l9R8B6KpKUW6gQz3azkkB8+ELHJej+1BzJX LxZFbwXPrFlocGOkJ6LVJN7jdo81Hw+BcGQ== X-Received: by 2002:a05:6a20:8405:b0:10d:f812:e4b5 with SMTP id c5-20020a056a20840500b0010df812e4b5mr12734185pzd.35.1686659336226; Tue, 13 Jun 2023 05:28:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7zh3aTrzBFhzojSOrwCPdh1Lb7NK3Z9pqJt4A+uuDgQwi65bRxwJpNbR2S2mrckj9XpyvB9w== X-Received: by 2002:a05:6a20:8405:b0:10d:f812:e4b5 with SMTP id c5-20020a056a20840500b0010df812e4b5mr12734165pzd.35.1686659335889; Tue, 13 Jun 2023 05:28:55 -0700 (PDT) Date: Tue, 13 Jun 2023 08:28:38 -0400 From: "Michael S. Tsirkin" To: Eugenio Perez Martin Cc: Jason Wang , Xuan Zhuo , virtio-comment@lists.oasis-open.org, Laurent Vivier , Cindy Lu , cohuck@redhat.com, alvaro.karsz@solid-run.com, Liuxiangdong , Gautam Dawar , longpeng2@huawei.com, Dragos Tatulea , parav@nvidia.com, stefanha@redhat.com, Harpreet Singh Anand , Stefano Garzarella , Heng Qi , Zhu Lingshan , Shannon Nelson , mgurtovoy@nvidia.com, si-wei.liu@oracle.com Message-ID: <20230613082755-mutt-send-email-mst@kernel.org> References: <20230608031325-mutt-send-email-mst@kernel.org> <20230608180617-mutt-send-email-mst@kernel.org> <20230609115250-mutt-send-email-mst@kernel.org> <20230613034216-mutt-send-email-mst@kernel.org> <20230613035132-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Subject: Re: [virtio-comment] Re: [PATCH 0/2] Selective queue enabling On Tue, Jun 13, 2023 at 12:12:43PM +0200, Eugenio Perez Martin wrote: > On Tue, Jun 13, 2023 at 9:53 AM Michael S. Tsirkin wrote: > > > > On Tue, Jun 13, 2023 at 03:46:35AM -0400, Michael S. Tsirkin wrote: > > > On Mon, Jun 12, 2023 at 09:56:57AM +0200, Eugenio Perez Martin wrote: > > > > > > Another drawback of that is the long time a device can spend to > > > > > > reconfigure its memory maps. > > > > > > > > > > The map is already used for cvq though, I don't see why it would take > > > > > much more with this. > > > > > > > > > > > > > In the case of vDPA HW, CVQ maps may not need to reach the device's or > > > > platform IOMMU, so the modification of that mapping is way cheaper. > > > > > > Oh, I get it. It's setup time, but you are right. > > > > > > > > > taking that into account, does it make > > > > > > sense to send a new version with the bit 1 on enable? > > > > > > > > > > > > Thanks! > > > > > > > > > > Current hardware won't support the extra bit though. > > > > > > Thinking more about this, I think the following works: > > > > - enable all queues before DRIVER_OK > > - reset all data queues before DRIVER_OK > > - DRIVER_OK > > - CVQ commands > > - re-enable data queues > > > > > > No? > > > > If it is valid to write to queue_reset before DRIVER_OK, then sure. I > asked for that in the past at > https://lists.oasis-open.org/archives/virtio-dev/202305/msg00329.html > . Well then Jason said: we should make svq work without RING_RESET but now apparently we went full circle and propose a feature bit after all? > > > > > > > -- > > > MST > > > > > > This publicly archived list offers a means to provide input to the > > OASIS Virtual I/O Device (VIRTIO) TC. > > > > In order to verify user consent to the Feedback License terms and > > to minimize spam in the list archive, subscription is required > > before posting. > > > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > > List help: virtio-comment-help@lists.oasis-open.org > > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > > Committee: https://www.oasis-open.org/committees/virtio/ > > Join OASIS: https://www.oasis-open.org/join/ > > This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/