All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [hverkuil-media-tree:staging 1/3] drivers/media/cec/core/cec-adap.c:389:17: sparse: sparse: incompatible types in conditional expression (different base types):
Date: Tue, 13 Jun 2023 10:09:45 +0800	[thread overview]
Message-ID: <202306131057.2gnoG6VC-lkp@intel.com> (raw)

tree:   git://linuxtv.org/hverkuil/media_tree.git staging
head:   32c8db22932c23fa3e43fca02ae0d8cfa92c2f35
commit: b835badd915436d1d43910d16c1807587117ad0c [1/3] [PATCH] media: cec: core: add adap_transmit_canceled() callback
config: riscv-randconfig-s031-20230612 (https://download.01.org/0day-ci/archive/20230613/202306131057.2gnoG6VC-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce:
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        git remote add hverkuil-media-tree git://linuxtv.org/hverkuil/media_tree.git
        git fetch --no-tags hverkuil-media-tree staging
        git checkout b835badd915436d1d43910d16c1807587117ad0c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash drivers/media/cec/core/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306131057.2gnoG6VC-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   WARNING: invalid argument to '-march': '_zihintpause'
>> drivers/media/cec/core/cec-adap.c:389:17: sparse: sparse: incompatible types in conditional expression (different base types):
>> drivers/media/cec/core/cec-adap.c:389:17: sparse:    void
>> drivers/media/cec/core/cec-adap.c:389:17: sparse:    int

vim +389 drivers/media/cec/core/cec-adap.c

   344	
   345	/*
   346	 * A pending CEC transmit needs to be cancelled, either because the CEC
   347	 * adapter is disabled or the transmit takes an impossibly long time to
   348	 * finish, or the reply timed out.
   349	 *
   350	 * This function is called with adap->lock held.
   351	 */
   352	static void cec_data_cancel(struct cec_data *data, u8 tx_status, u8 rx_status)
   353	{
   354		struct cec_adapter *adap = data->adap;
   355	
   356		/*
   357		 * It's either the current transmit, or it is a pending
   358		 * transmit. Take the appropriate action to clear it.
   359		 */
   360		if (adap->transmitting == data) {
   361			adap->transmitting = NULL;
   362		} else {
   363			list_del_init(&data->list);
   364			if (!(data->msg.tx_status & CEC_TX_STATUS_OK))
   365				if (!WARN_ON(!adap->transmit_queue_sz))
   366					adap->transmit_queue_sz--;
   367		}
   368	
   369		if (data->msg.tx_status & CEC_TX_STATUS_OK) {
   370			data->msg.rx_ts = ktime_get_ns();
   371			data->msg.rx_status = rx_status;
   372			if (!data->blocking)
   373				data->msg.tx_status = 0;
   374		} else {
   375			data->msg.tx_ts = ktime_get_ns();
   376			data->msg.tx_status |= tx_status |
   377					       CEC_TX_STATUS_MAX_RETRIES;
   378			data->msg.tx_error_cnt++;
   379			data->attempts = 0;
   380			if (!data->blocking)
   381				data->msg.rx_status = 0;
   382		}
   383	
   384		/* Queue transmitted message for monitoring purposes */
   385		cec_queue_msg_monitor(adap, &data->msg, 1);
   386	
   387		if (!data->blocking && data->msg.sequence)
   388			/* Allow drivers to react to a canceled transmit */
 > 389			call_op(adap, adap_transmit_canceled, &data->msg);
   390	
   391		cec_data_completed(data);
   392	}
   393	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-06-13  2:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202306131057.2gnoG6VC-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.