From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBFFCC7EE2E for ; Tue, 13 Jun 2023 09:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=if+pCOma6HDPicmb2KVCC26XjnW8sjwMxFKy2rcdJKU=; b=tjnOsgLLQqOrBX JHqENigKq2sCGZvYf1+M1q8IMEtje+Gk1//++1QQy544fnTKPqrxpnRPgZmXeuGuOaqtidJ+egC3N h/RcjIewrsiYwQYkr1JDj0Q0Eu1/K4UCIvKrlSETEkEm5nDfVf8GSefMIgIcKKStnyugheoY4ScpG deo9dJsWtr+vkjHtGSjebSBeU5IYVCoDSm0oeRsswhbBmfUYaN98uWAL17FwfBQn6gsRl9ljQ4kUH QCV84rsHAlBKR16LHdKYN+IItbOWbY9VMR8UtK/51kEIsApPGuczeWNMkxK266iOLv1a2e+olslNz hsc8KmD8MVZuu3UTQ+sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q90AD-007Ukb-2P; Tue, 13 Jun 2023 09:18:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q90AB-007Ujf-2W; Tue, 13 Jun 2023 09:18:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C41962923; Tue, 13 Jun 2023 09:18:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61408C433D2; Tue, 13 Jun 2023 09:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686647886; bh=gp+4Z1m750oiZIRymOwmqEvUZvz41fNPY9krBfP1984=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVGh3QOpVrxSHP9UZtItr+ntdS6qUPKsngq/pP32GnjqCUmJVvftIcD55a/PdaRWr qrss9Pxw5CMb3Vh8yF09ougsSYqgBQOkc/4gRjjhVqhecQxMn2qHeGhmTEX4PSoGY/ qVGd70/5mhXvXVBRwld68AXTpT+ThEFuuPHz19z8= Date: Tue, 13 Jun 2023 11:18:04 +0200 From: "gregkh@linuxfoundation.org" To: Wei-chin Tsai =?utf-8?B?KOiUoee2reaZiSk=?= Cc: "linux-kernel@vger.kernel.org" , Mel Lee =?utf-8?B?KOadjuWlh+mMmik=?= , "linux-mediatek@lists.infradead.org" , wsd_upstream , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "arnd@arndb.de" , Ivan Tseng =?utf-8?B?KOabvuW/l+i7kik=?= , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions Message-ID: <2023061331-stipulate-crumpled-97cb@gregkh> References: <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com> <2023061226-repugnant-upstate-a2b4@gregkh> <8fa623a77edd2d8b6ade77903d40b4c4c5992965.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8fa623a77edd2d8b6ade77903d40b4c4c5992965.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_021807_862208_74893040 X-CRM114-Status: GOOD ( 20.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMTMsIDIwMjMgYXQgMDk6MTI6MzhBTSArMDAwMCwgV2VpLWNoaW4gVHNhaSAo 6JSh57at5pmJKSB3cm90ZToKPiBPbiBNb24sIDIwMjMtMDYtMTIgYXQgMTg6MzcgKzAyMDAsIEdy ZWcgS3JvYWgtSGFydG1hbiB3cm90ZToKPiA+ICAJIAo+ID4gRXh0ZXJuYWwgZW1haWwgOiBQbGVh c2UgZG8gbm90IGNsaWNrIGxpbmtzIG9yIG9wZW4gYXR0YWNobWVudHMgdW50aWwKPiA+IHlvdSBo YXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgb3IgdGhlIGNvbnRlbnQuCj4gPiAgT24gTW9uLCBKdW4g MTIsIDIwMjMgYXQgMTE6MTU6NDFQTSArMDgwMCwgamltLnRzYWkgd3JvdGU6Cj4gPiA+ICtzdGF0 aWMgdm9pZCBjbGFzc19jcmVhdGVfcmVsZWFzZShzdHJ1Y3QgY2xhc3MgKmNscykKPiA+ID4gK3sK PiA+ID4gKy8qZG8gbm90aGluZyBiZWNhdXNlIHRoZSBtYnJhaW5rIGNsYXNzIGlzIG5vdCBmcm9t IG1hbGxvYyovCj4gPiA+ICt9Cj4gPiAKPiA+IFRoZW4gdGhlIGNvZGUgaXMgdG90YWxseSBicm9r ZW4gYW5kIHdyb25nIDooCj4gPiAKPiA+IFBsZWFzZSBqdXN0IHVzZSB0aGUgbWlzYyBkZXZpY2Ug YXBpIGluc3RlYWQsIGl0IGlzIG11Y2ggc2ltcGxlciBhbmQKPiA+IGRvZXNuJ3QgaGF2ZSB0aGVz ZSB0eXBlcyBvZiBlcnJvcnMuCj4gPiAKPiA+IHRoYW5rcywKPiA+IAo+ID4gZ3JlZyBrLWgKPiAK PiAKPiBTb3JyeSwgSSBkaWQgbm90IHJlYWxseSBnZXQgdGhlIHBvaW50IGZyb20gYWJvdmUgY29t bWVudHMgYmVjYXVzZSBJdAo+IHdvcmtzIHdlbGwgZm9yIG1lIGZvciB0aGUgbWJyYWlua19tYWlu LmMgYW5kIG5vIGNvbXBpbGVyIGVycm9ycyBvcgo+IHJ1bnRpbWUgZXJyb3JzPwoKVGhpbmsgYWJv dXQgd2h5IHRoZSBrZXJuZWwgaXMgdHJ5aW5nIHRvIGNoZWNrIGlmIHlvdSBoYXZlIGEgcmVsZWFz ZQpmdW5jdGlvbiBvciBub3QuICBXb3VsZCBhbiAiZW1wdHkiIGZ1bmN0aW9uIGJlIHRoZSBzYW1l IHRoaW5nPwoKVGhhdCBjaGVjayB3YXMgYWRkZWQgdG8gdGVsbCB5b3UgdGhhdCB5b3VyIGRlc2ln biBpcyB3cm9uZyBhbmQgbmVlZHMgdG8KYmUgZml4ZWQsIGRvIE5PVCBqdXN0IHRyeSB0byBwYXBl ciBvdmVyIHdhcm5pbmdzIGZyb20gdGhlIGtlcm5lbCBhcwpzb21lb25lIHNwZW50IHRoZSB0aW1l IHRvIHRyeSB0byBiZSBuaWNlIGFuZCB0ZWxsIHlvdSB0aGF0IHRoZSBjb2RlIGlzCmluY29ycmVj dCA6KQoKQW55d2F5LCBhbG1vc3QgYWxsIG9mIHRoZXNlIChpZiBub3QgYWxsKSwgY2FuIGp1c3Qg Z28gYXdheSBpZiB5b3UgbW92ZQp0byAgdXNlIHRoZSBtaXNjZGV2aWNlIGFwaSBpbnN0ZWFkLgoK QWxzbywgcGxlYXNlIGRvbid0IHNlbmQgSFRNTCBlbWFpbCwgdGhlIG1haWxpbmcgbGlzdHMgcmVq ZWN0IGl0IDooCgp0aGFua3MsCgpncmVnIGstaAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C986C7EE2E for ; Tue, 13 Jun 2023 09:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241883AbjFMJS0 (ORCPT ); Tue, 13 Jun 2023 05:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241920AbjFMJSO (ORCPT ); Tue, 13 Jun 2023 05:18:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD65AE73 for ; Tue, 13 Jun 2023 02:18:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5205F62926 for ; Tue, 13 Jun 2023 09:18:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61408C433D2; Tue, 13 Jun 2023 09:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686647886; bh=gp+4Z1m750oiZIRymOwmqEvUZvz41fNPY9krBfP1984=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVGh3QOpVrxSHP9UZtItr+ntdS6qUPKsngq/pP32GnjqCUmJVvftIcD55a/PdaRWr qrss9Pxw5CMb3Vh8yF09ougsSYqgBQOkc/4gRjjhVqhecQxMn2qHeGhmTEX4PSoGY/ qVGd70/5mhXvXVBRwld68AXTpT+ThEFuuPHz19z8= Date: Tue, 13 Jun 2023 11:18:04 +0200 From: "gregkh@linuxfoundation.org" To: Wei-chin Tsai =?utf-8?B?KOiUoee2reaZiSk=?= Cc: "linux-kernel@vger.kernel.org" , Mel Lee =?utf-8?B?KOadjuWlh+mMmik=?= , "linux-mediatek@lists.infradead.org" , wsd_upstream , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "arnd@arndb.de" , Ivan Tseng =?utf-8?B?KOabvuW/l+i7kik=?= , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions Message-ID: <2023061331-stipulate-crumpled-97cb@gregkh> References: <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com> <2023061226-repugnant-upstate-a2b4@gregkh> <8fa623a77edd2d8b6ade77903d40b4c4c5992965.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8fa623a77edd2d8b6ade77903d40b4c4c5992965.camel@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 09:12:38AM +0000, Wei-chin Tsai (蔡維晉) wrote: > On Mon, 2023-06-12 at 18:37 +0200, Greg Kroah-Hartman wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote: > > > +static void class_create_release(struct class *cls) > > > +{ > > > +/*do nothing because the mbraink class is not from malloc*/ > > > +} > > > > Then the code is totally broken and wrong :( > > > > Please just use the misc device api instead, it is much simpler and > > doesn't have these types of errors. > > > > thanks, > > > > greg k-h > > > Sorry, I did not really get the point from above comments because It > works well for me for the mbraink_main.c and no compiler errors or > runtime errors? Think about why the kernel is trying to check if you have a release function or not. Would an "empty" function be the same thing? That check was added to tell you that your design is wrong and needs to be fixed, do NOT just try to paper over warnings from the kernel as someone spent the time to try to be nice and tell you that the code is incorrect :) Anyway, almost all of these (if not all), can just go away if you move to use the miscdevice api instead. Also, please don't send HTML email, the mailing lists reject it :( thanks, greg k-h