From: Hannes Reinecke <hare@suse.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 3/7] brd: abstract page_size conventions
Date: Wed, 14 Jun 2023 13:46:33 +0200 [thread overview]
Message-ID: <20230614114637.89759-4-hare@suse.de> (raw)
In-Reply-To: <20230614114637.89759-1-hare@suse.de>
In preparation for changing the block sizes abstract away references
to PAGE_SIZE and friends.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/block/brd.c | 39 ++++++++++++++++++++++++++++++---------
1 file changed, 30 insertions(+), 9 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 24769d010fee..71d3d8af8b0d 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -45,6 +45,23 @@ struct brd_device {
u64 brd_nr_folios;
};
+#define BRD_SECTOR_SHIFT(b) (PAGE_SHIFT - SECTOR_SHIFT)
+
+static pgoff_t brd_sector_index(struct brd_device *brd, sector_t sector)
+{
+ pgoff_t idx;
+
+ idx = sector >> BRD_SECTOR_SHIFT(brd);
+ return idx;
+}
+
+static int brd_sector_offset(struct brd_device *brd, sector_t sector)
+{
+ unsigned int rd_sector_mask = (1 << BRD_SECTOR_SHIFT(brd)) - 1;
+
+ return ((unsigned int)sector & rd_sector_mask) << SECTOR_SHIFT;
+}
+
/*
* Look up and return a brd's folio for a given sector.
*/
@@ -53,7 +70,7 @@ static struct folio *brd_lookup_folio(struct brd_device *brd, sector_t sector)
pgoff_t idx;
struct folio *folio;
- idx = sector >> PAGE_SECTORS_SHIFT; /* sector to folio index */
+ idx = brd_sector_index(brd, sector); /* sector to folio index */
folio = xa_load(&brd->brd_folios, idx);
BUG_ON(folio && folio->index != idx);
@@ -68,19 +85,20 @@ static int brd_insert_folio(struct brd_device *brd, sector_t sector, gfp_t gfp)
{
pgoff_t idx;
struct folio *folio, *cur;
+ unsigned int rd_sector_order = get_order(PAGE_SIZE);
int ret = 0;
folio = brd_lookup_folio(brd, sector);
if (folio)
return 0;
- folio = folio_alloc(gfp | __GFP_ZERO | __GFP_HIGHMEM, 0);
+ folio = folio_alloc(gfp | __GFP_ZERO | __GFP_HIGHMEM, rd_sector_order);
if (!folio)
return -ENOMEM;
xa_lock(&brd->brd_folios);
- idx = sector >> PAGE_SECTORS_SHIFT;
+ idx = brd_sector_index(brd, sector);
folio->index = idx;
cur = __xa_cmpxchg(&brd->brd_folios, idx, NULL, folio, gfp);
@@ -122,11 +140,12 @@ static void brd_free_folios(struct brd_device *brd)
static int copy_to_brd_setup(struct brd_device *brd, sector_t sector, size_t n,
gfp_t gfp)
{
- unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
+ unsigned int rd_sector_size = PAGE_SIZE;
+ unsigned int offset = brd_sector_offset(brd, sector);
size_t copy;
int ret;
- copy = min_t(size_t, n, PAGE_SIZE - offset);
+ copy = min_t(size_t, n, rd_sector_size - offset);
ret = brd_insert_folio(brd, sector, gfp);
if (ret)
return ret;
@@ -145,10 +164,11 @@ static void copy_to_brd(struct brd_device *brd, const void *src,
{
struct folio *folio;
void *dst;
- unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
+ unsigned int rd_sector_size = PAGE_SIZE;
+ unsigned int offset = brd_sector_offset(brd, sector);
size_t copy;
- copy = min_t(size_t, n, PAGE_SIZE - offset);
+ copy = min_t(size_t, n, rd_sector_size - offset);
folio = brd_lookup_folio(brd, sector);
BUG_ON(!folio);
@@ -177,10 +197,11 @@ static void copy_from_brd(void *dst, struct brd_device *brd,
{
struct folio *folio;
void *src;
- unsigned int offset = (sector & (PAGE_SECTORS-1)) << SECTOR_SHIFT;
+ unsigned int rd_sector_size = PAGE_SIZE;
+ unsigned int offset = brd_sector_offset(brd, sector);
size_t copy;
- copy = min_t(size_t, n, PAGE_SIZE - offset);
+ copy = min_t(size_t, n, rd_sector_size - offset);
folio = brd_lookup_folio(brd, sector);
if (folio) {
src = kmap_local_folio(folio, offset);
--
2.35.3
next prev parent reply other threads:[~2023-06-14 11:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:46 [PATCH 0/7] RFC: high-order folio support for I/O Hannes Reinecke
2023-06-14 11:46 ` [PATCH 1/7] brd: use XArray instead of radix-tree to index backing pages Hannes Reinecke
2023-06-14 12:45 ` Matthew Wilcox
2023-06-14 12:50 ` Pankaj Raghav
2023-06-14 13:03 ` Hannes Reinecke
2023-06-14 11:46 ` [PATCH 2/7] brd: convert to folios Hannes Reinecke
2023-06-14 13:45 ` Matthew Wilcox
2023-06-14 13:50 ` Hannes Reinecke
2023-06-14 11:46 ` Hannes Reinecke [this message]
2023-06-14 11:46 ` [PATCH 4/7] brd: make sector size configurable Hannes Reinecke
2023-06-14 12:55 ` Matthew Wilcox
2023-06-14 13:02 ` Hannes Reinecke
2023-06-15 2:17 ` Dave Chinner
2023-06-15 5:55 ` Christoph Hellwig
2023-06-15 6:33 ` Hannes Reinecke
2023-06-15 6:23 ` Hannes Reinecke
2023-06-14 11:46 ` [PATCH 5/7] brd: make logical " Hannes Reinecke
2023-06-14 11:46 ` [PATCH 6/7] mm/filemap: allocate folios with mapping blocksize Hannes Reinecke
2023-06-19 8:08 ` Pankaj Raghav
2023-06-19 8:42 ` Hannes Reinecke
2023-06-19 22:57 ` Dave Chinner
2023-06-20 0:00 ` Matthew Wilcox
2023-06-20 5:57 ` Hannes Reinecke
2023-06-14 11:46 ` [PATCH 7/7] mm/readahead: align readahead down to " Hannes Reinecke
2023-06-14 13:17 ` [PATCH 0/7] RFC: high-order folio support for I/O Hannes Reinecke
2023-06-14 13:53 ` Matthew Wilcox
2023-06-14 15:06 ` Hannes Reinecke
2023-06-14 15:35 ` Hannes Reinecke
2023-06-14 17:46 ` Matthew Wilcox
2023-06-14 23:53 ` Dave Chinner
2023-06-15 6:21 ` Hannes Reinecke
2023-06-15 8:51 ` Dave Chinner
2023-06-16 16:06 ` Kent Overstreet
2023-06-15 3:44 ` Dave Chinner
2023-06-14 13:48 ` [PATCH 1/2] highmem: Add memcpy_to_folio() Matthew Wilcox (Oracle)
2023-06-14 18:38 ` kernel test robot
2023-06-14 19:30 ` kernel test robot
2023-06-15 5:58 ` Christoph Hellwig
2023-06-15 12:16 ` Matthew Wilcox
2023-06-14 13:48 ` [PATCH 2/2] highmem: Add memcpy_from_folio() Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614114637.89759-4-hare@suse.de \
--to=hare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.