From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, bluca@debian.org, david.marchand@redhat.com,
ian.stokes@intel.com, Ilya Maximets <i.maximets@ovn.org>,
Jerin Jacob <jerinj@marvell.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag
Date: Wed, 14 Jun 2023 12:33:10 -0700 [thread overview]
Message-ID: <20230614123310.710fa9e0@hermes.local> (raw)
In-Reply-To: <20201211155111.145279-1-bruce.richardson@intel.com>
On Fri, 11 Dec 2020 15:51:11 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> Traditionally any apps built using DPDK had to support the same
> instruction sets as supported when the DPDK SDK itself was built, since
> that was "leaked" through to the end-app and DPDK headers via
> RTE_MACHINE_CPUFLAG_* values. Therefore, when converting over to meson
> for app build correctness the "-march=" flag was included in the
> pkg-config cflags output.
>
> However, since the DPDK-specific CPU flags are now obsolete, and we
> instead check directly for compiler-defined flags, we should no longer
> need to force the exact same architecture match in all cases. To
> faciliate such flexibility, a new pkg_config_machine_args array - which
> defaults to the existing machine_args array has been defined. The
> individual architectures - x86, arm and ppc - can choose if and how to
> override this value themselves.
>
> For x86, since SSE4.2 is the minimum instruction-set level needed to run
> DPDK, and since some header files assume that minimum level of
> instruction set support, we override the "-march=" value with "-msse4"
> for the pkg-config file. This allows end applications to set their own
> "march" value while still ensuring valid DPDK compilation.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
This looks fine, and can see no negatives in the comments.
Could you rebase and resubmit a new version if still relevant?
next prev parent reply other threads:[~2023-06-14 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 15:51 [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag Bruce Richardson
2020-12-16 18:45 ` David Christensen
2021-09-15 16:28 ` Bruce Richardson
2021-09-15 21:23 ` David Christensen
2021-09-16 3:43 ` Jerin Jacob
2021-09-16 10:16 ` Ruifeng Wang
2021-09-16 14:11 ` Ruifeng Wang
2023-06-14 19:33 ` Stephen Hemminger [this message]
2023-06-15 8:44 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614123310.710fa9e0@hermes.local \
--to=stephen@networkplumber.org \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=i.maximets@ovn.org \
--cc=ian.stokes@intel.com \
--cc=jerinj@marvell.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.