From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4C45EB64D8 for ; Wed, 14 Jun 2023 16:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+aUILuOc1F4sXBs18so8lGh4OIzi9BWzmbOm+anMguc=; b=kLENbgxu9k47UG lliX0+AdONp1Qeqe+T1E6gt3y3zYkWCLAQVzXhiIBys0RwggxlsCDd69lXKpnvYbBWS3u4MeSrAhP qu0pVevYOryKH6bAecbDa8pHZfhVIORmlYgH6S7jchnyfhPX4dItzs37p8JK+fnalrZ+XZX7wHuCB RuX++SAPGdhvpCopGnWXnKq1KL3KVsd/JmE0m9X8L37h8wLy0kxjzOT219mkelqNPDAXsNPHw9TAG vN/cMTqTHxngsilYO3DxbVl6wYeT1OJdxEXNSca75ApaQ7HuvOLps6kUHLHcB7RKG0rpPM6eARvB/ NQ6dZziIdixmxsdjg1hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9Svv-00C9MM-1l; Wed, 14 Jun 2023 16:01:19 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9Svq-00C9LN-1h; Wed, 14 Jun 2023 16:01:17 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686758470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOV8LTn0vFlBeWdljLVATJ2Xq6J3HagcK9Y6oImy8+I=; b=fRGb2XnKJ8tgpUp/9ld7byMjVBjI+NtTqmuPLCJQswKll3RH+qfto8GuosQiirtT9+NZnS HF+mc5EJGkvXfdHHjlKJ8ZuZnEtq5zK/sgepxyCDk12T4bhqrAZQGtKSi5qE/SEmCJkn82 vQ0e7s8aN9BLy3BMzSx79JEqpFVwFDxT94IZk7b/K7ZaAilMKpcHGGfLvEbqvAe8JLVf2R DW9Rgvf76DtSFQfStU8xfDwSg122Orq2k67dvdqEf89xf/UVICkA8wQOnzsN+8stD11FEz KVzgEbOSrFTejmgPrjkMyob9lZRTD77L3J3qFTQgxAxja/cH71wSruox1JRCtg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B83E20004; Wed, 14 Jun 2023 16:01:09 +0000 (UTC) Date: Wed, 14 Jun 2023 18:01:08 +0200 From: Miquel Raynal To: Johan Jonker Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com Subject: Re: [PATCH v2 3/5] mtd: nand: raw: rockchip-nand-controller: fix oobfree offset and description Message-ID: <20230614180108.5b202077@xps-13> In-Reply-To: <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> References: <11e16c3b-6f7b-a6a9-b0ed-b7ac0cd703e3@gmail.com> <20230612192640.63baf3e8@xps-13> <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_090114_884625_29B6D65E X-CRM114-Status: GOOD ( 48.90 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgSm9oYW4sCgpqYng2MjQ0QGdtYWlsLmNvbSB3cm90ZSBvbiBXZWQsIDE0IEp1biAyMDIzIDEx OjIzOjQ0ICswMjAwOgoKPiBPbiA2LzEyLzIzIDE5OjI2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ ID4gSGkgSm9oYW4sCj4gPiAKPiA+IGpieDYyNDRAZ21haWwuY29tIHdyb3RlIG9uIE1vbiwgMTIg SnVuIDIwMjMgMTc6MDM6MTggKzAyMDA6Cj4gPiAgIAo+ID4+IFRoZSBNVEQgZnJhbWV3b3JrIHJl c2VydmVzIDEgb3IgMiBieXRlcyBmb3IgdGhlIGJhZCBibG9jayBtYXJrZXIKPiA+PiBkZXBlbmRp bmcgb24gdGhlIGJ1cyBzaXplLiBUaGUgcm9ja2NoaXAtbmFuZC1jb250cm9sbGVyIGRyaXZlcgo+ ID4+IGN1cnJlbnRseSBvbmx5IHN1cHBvcnRzIGEgOCBiaXQgYnVzLCBidXQgcmVzZXJ2ZXMgc3Rh bmRhcmQgMiBieXRlcwo+ID4+IGZvciB0aGUgQkJNLiAgCj4gPiAKPiA+IFdlIGFsd2F5cyByZXNl cnZlIDIgYnl0ZXMsIG5vPyAgCj4gCj4gTm90IGFsd2F5cyB1c2VkLCBidXQgZm9yIGNvbnNpc3Rl bmN5L3NpbXBsaWNpdHkgdGhlIGF1dGhvciBhc3N1bWVzL3Jlc2VydmVzIDIgYnl0ZXMuIAoKSXQn cyBraW5kIG9mIGFuIGltcGxpY2l0IHJ1bGUgaW4gdGhlIHJhdyBOQU5EIHN1YnN5c3RlbS4gSXQn cyBub3QgYW4KYXV0aG9yIGNob2ljZS4KCj4gPj4gVGhlIGZpcnN0IGZyZWUgT09CIGJ5dGUgaXMg dGhlcmVmb3JlIE9PQjIgYXQgb2Zmc2V0IDIuCj4gPj4gUGFnZSBhZGRyZXNzKFBBKSBieXRlcyBh cmUgbW92ZWQgdG8gdGhlIGxhc3QgNCBwb3NpdGlvbnMgYmVmb3JlCj4gPj4gRUNDLiBVcGRhdGUg dGhlIGRlc2NyaXB0aW9uIGZvciBMaW51eC4gIAo+ID4gCj4gPiBUaGUgZGVzY3JpcHRpb24gc2hv dWxkIGp1c3QgYmU6Cj4gPiAgIAo+IAo+ID4gTW92ZSBQYWdlIEFkZHJlc3MgKFBBKSBieXRlcyB0 byB0aGUgbGFzdCA0IHBvc2l0aW9ucyBiZWZvcmUgRUNDLiAgCj4gCj4gU3BhY2UgaXMgYWxyZWFk eSByZXNlcnZlZCwgYnV0IG92ZXJ3cml0dGVuLgoKV2VsbCwgSSBkb24ndCBrbm93LCBidXQgSSdt IHF1b3RpbmcgeW91ciBjb21taXQgbG9nICJQYWdlIGFkZHJlc3MoUEEpCmJ5dGVzIGFyZSBtb3Zl ZCB0byB0aGUgbGFzdCA0IHBvc2l0aW9ucyBiZWZvcmUgRUNDIiBhbmQgaWYgdGhpcwpzZW50ZW5j ZSBpcyByaWdodCwgSSBhbSBwcm9wb3NpbmcgYW5vdGhlciB3YXkgdG8gc2F5IHRoaXMgd2hpY2gg c291bmRzCm1vcmUgZGVjbGFyYXRpdmUuCgo+IAo+ID4gCj4gPiBBbmQgdGhlbiB5b3Ugc2hvdWxk IGp1c3RpZnkgd2h5IHRoaXMgaXMgbmVlZGVkLiBBbHNvLCB0aGlzIHdvdWxkCj4gPiBicmVhayBh bGwgZXhpc3RpbmcgamZmczIgdXNlcnMsIHJpZ2h0PyAgCj4gCj4gSGkgTWlxdWVsLAo+IAo+IEZy b20geW91ciBjb21tZW50cyBpdCBzZWVtcyB0aGF0IHRoZSBjaGlwLT5vb2JfcG9pIGJ1ZmZlciBs YXlvdXQgaXMKPiBzdGlsbCBub3QgY2xlYXIgdG8geW91LiBIb3BlIHRoYXQgdGhpcyB0ZXh0IGJl bG93IGhlbHBzLgo+IElmIGV4aXN0aW5nIGpmZnMyIHVzZXJzIG9mIGZyZWUgT09CIGFyZSB3cml0 aW5nCgpUaGV5IGFyZSwgaXQncyB0aGUgZmlyc3QgdGhpbmcgdGhhdCBqamZzMiBkb2VzOiB3cml0 aW5nIGNsZWFubWFya2VycyBpbgp0aGUgZnJlZSBhcmVhLgoKPiB0aGV5IGFyZSBjb3JydXB0aW5n Cj4gb3VyIFBBIGRhdGEgaW4gUkFXIG1vZGUuIFNvIHRoYXQgbXVzdCBiZSBmaXhlZC4gCgpJIGRp ZCBub3QgeWV0IHVuZGVyc3RhbmQgd2hldGhlciBjb3JydXB0aW5nIHRoZSBQQSBkYXRhIHdhcyBh biBhYnNvbHV0ZQptaXN0YWtlIG9yIGlmIGl0IHdhcyBzcGVjaWZpYyB0byBhIGdpdmVuIHJhbmdl IG9mIFJPTSBjb2Rlcy4gQnV0IGxldCdzCmFzc3VtZSBpdCBtdXN0IGJlIGZpeGVkLgoKPiBQbGVh c2UgYWR2aXNlIGhvdyB3ZQo+IHNwbGl0IHByZSBhbmQgcG9zdCBjaGFuZ2UgdXNlcnMuCgpJZiB5 b3UgY2hhbmdlIHRoZSBsYXlvdXQsIHlvdSBicmVhayB1c2Vycy4gVGhlcmUgaXMgbm8gcXVlc3Rp b24gaGVyZS4KQnV0IGlmIHlvdSBkbyB0aGF0LCB3ZSBuZWVkOgotIGEgY3J5c3RhbCBjbGVhciBl eHBsYW5hdGlvbiBvZiB3aHkgdGhpcyBpcyBuZWVkZWQKLSB0byBzYXkgaXQgY2xlYXJseTogdGhp cyBjaGFuZ2UgYnJlYWtzIGV4aXN0aW5nIGpmZnMyIHVzZXJzCgo+IChXaXRoIGEgTW9kdWxlIHBh cmFtZXRlciBsaWtlCj4gc2tpcGJidCByZW5hbWVkIHRvICJ1c2VyX21vZGUiID0gMCBvZmZzZXQg NiwgInVzZXJfbW9kZSIgPSAxIG9mZnNldAoKSSBrbm93IHRoZSBjYWZlIGRyaXZlciBkb2VzIHRo YXQsIGl0IGlzIGF3ZnVsIElNSE8uCgo+IDIpIENvcHlpbmcgUEEgZGF0YSBpbiBib3RoIFJBVyBh bmQgSFcgbW9kZSBoYXMgYWxyZWFkeSByZXNlcnZlZCBzcGFjZQo+IGluIHRoZSBsYXlvdXQuIExl dCBtZSBrbm93IGlmIEkgY2FuIGhlbHAgdG8gZ2V0IGZvcndhcmQgaGVyZS4KPiAKPiBKb2hhbgo+ IAo+ID09PQo+IAo+IEdpdmVuOgo+IAo+IFJvY2tjaGlwIHJrMzA2NiBNSzgwOCB3aXRoIE5BTkQ6 Cj4gbmFuZDogSHluaXggSDI3VUNHOFQyQVRSLUJDIDY0RyAzLjNWIDgtYml0Cj4gbmFuZDogODE5 MiBNaUIsIE1MQywgZXJhc2Ugc2l6ZTogMjA0OCBLaUIsIHBhZ2Ugc2l6ZTogODE5MiwgT09CIHNp emU6Cj4gNjQwCj4gCj4gPT09Cj4gCj4gQ2FsdWxhdGlvbnM6Cj4gCj4gI2RlZmluZSBORkNfU1lT X0RBVEFfU0laRQkJKDQpIC8qIDQgYnl0ZXMgc3lzIGRhdGEgaW4KPiBvb2IgcHJlIDEwMjQgZGF0 YS4qLwo+IAo+IFNvIHBlciBzdGVwIG9ubHkgNCBieXRlcyBvZiBPT0IgY2FuIGJlIHJlYWQuCgpJ IHRoaW5rIEkgZ2V0IHdoYXQgeW91IG1lYW4gYnV0IHRoZSBhYm92ZSBzZW50ZW5jZSBpcyB3cm9u Zy4gWW91IGNhbgphbHdheXMgcmVhZCB0aGUgZnVsbCBPT0IgaW4gcmF3IG1vZGUuIEFuZCBpbiBn ZW5lcmFsIHlvdSBjYW4gYXMgd2VsbCBpbgpob3N0IEVDQyBtb2RlLiBUaGVuIHdoYXQgdXNlcnMg ZG8gd2l0aCB0aGUgT09CIGluZm9ybWF0aW9uIGlzCm9ydGhvZ29uYWwuIEhvd2V2ZXIsIGlmIHRo ZXkgZG9uJ3Qgd2FudCB0aGVpciBkYXRhIHRvIGJlIHNtYXNoZWQsIHRoZXkKY2FuIHJlcXVlc3Qg dGhlIGluZm9ybWF0aW9uIGFib3V0IHdoaWNoIGJ5dGVzIGFyZSBmcmVlIHRvIGJlIHVzZWQKKHR5 cGljYWxseSB3aGF0IGpmZnMyIGRvZXMsIHdoaWxlIHViaSBkb2VzIG5vdCBjYXJlIGFib3V0IE9P QikuIFRoZSBvb2IKbGF5b3V0IGhlbHBlcnMgY2FuIHRoZW4gcmVzdHJhaW4gdGhlIGFkdmVydGlz ZWQgZnJlZSBhcmVhIHRvIG9ubHkgc2hhcmUKYnl0ZXMgd2hpY2ggYXJlIG5vdCB1c2VkIGJ5IHRo ZSBQQS4KCj4gCj4gPT09Cj4gCj4gVGhlIE5GQyBjYW4gcmVhZC93cml0ZSBpbiAxMDI0IGRhdGEg Ynl0ZXMgcGVyIHN0ZXAuCj4gVG8gcmVhZC93cml0ZSBhIGZ1bGwgcGFnZSBpdCBuZWVkcyA4IHN0 ZXBzLgo+IAo+IGNoaXAtPmVjYy5zaXplID0gMTAyNDsKPiBjaGlwLT5lY2Muc3RlcHMgPSBtdGQt PndyaXRlc2l6ZSAvIGNoaXAtPmVjYy5zaXplOwo+ICAgICAgICAgICAgICAgICA9IDgxOTIgLyAx MDI0Cj4gICAgICAgICAgICAgICAgID0gOCBzdGVwcwo+ID09PQo+IAo+IFRoZSB0b3RhbCBzaXpl IG9mIHVzZWZ1bGwgT09CIGJlZm9yZSBFQ0M6Cj4gCj4gcmtuYW5kLT5tZXRhZGF0YV9zaXplID0g TkZDX1NZU19EQVRBX1NJWkUgKiBlY2MtPnN0ZXBzOwo+ICAgICAgICAgICAgICAgICAgICAgICA9 IDQgKiA4Cj4gICAgICAgICAgICAgICAgICAgICAgID0gMzIKPiA9PT0KPiAKPiBXcm9uZyBmcmVl IE9PQiBvZmZzZXQgc3RhcnRzIGF0IE9PQjY6Cj4gb29iX3JlZ2lvbi0+b2Zmc2V0ID0gTkZDX1NZ U19EQVRBX1NJWkUgKyAyOwo+ICAgICAgICAgICAgICAgICAgICA9IDQgKyAyCj4gICAgICAgICAg ICAgICAgICAgID0gNgo+IAo+IFdpdGggYSBmcmVlIE9PQiBvZmZzZXQgb2YgNiBhbmQgYSBsZW5n dGggb2YgMjYgPT0+IDYgKyAyNiA9IDMyIHdlCj4gY29ycnVwdCB0aGUgUEEgYWRkcmVzcyBzdGFy dGluZyBhdCBvZmZzZXQgMjguCj4gCj4gTmV3IG9mZnNldCBPT0IyOgo+IG9vYl9yZWdpb24tPm9m ZnNldCA9IDI7Cj4gCj4gVGhlIGZ1bGwgcmFuZ2Ugb2YgZnJlZSBydW5zIGZyb20gT09CMiB0aWxs L2luY2x1ZGluZyBPT0IyNy4KPiA9PT0KPiAKPiBUaGUgbGFzdCA0IGJ5dGVzIG9mIG1ldGFkYXRh IGFyZSByZXNlcnZlZCBmb3IgdGhpcyBQYWdlIEFkZHJlc3MoUEEpCj4gZm9yIHRoZSBib290cm9t LiBDdXJyZW50bHkgb25seSBpbiB1c2UgaW4gUkFXIG1vZGUuCgpJJ20gbm90IHN1cmUgdG8gdW5k ZXJzdGFuZCB3aGF0ICJjdXJyZW50bHkgb24gbHkgaW4gdXNlIGluIHJhdyBtb2RlIi4KCkluIHJh dyBtb2RlLCB0aGUgdXNlciBjYW4gb3ZlcndyaXRlIHRoZSB3aG9sZSBPT0IgYXJlYSwgaXQgaXMg dGhlIHVzZXIKaW5wdXQgd2hhdCBzaG91bGQgYmUgd3JpdHRlbiBpbiBlYWNoIGFuZCBldmVyeSBi eXRlLgoKSW4gRUNDIG1vZGUgdGhlIEVDQyBlbmdpbmUgd2lsbCBzbWFzaCBzb21lIG9mIHRoaXMg ZGF0YSB0byB3cml0ZSBpdHMKb3duIEVDQyBieXRlcy4KCj4gVGhlIGN1cnJlbnQgUEEgY2FsY3Vs YXRpb24gbmVlZGVkIHRvIHdyaXRlIGJvb3QgYmxvY2tzIGZvciBhbGwKPiBSb2NrY2hpcCBTb0Nz IGlzIGhvd2V2ZXIgdXNlbGVzcy4gVGhlIHBhdHRlcm4gb2Ygd2hlcmUgdGhlIG5leHQgcGFnZQo+ IGlzIHdyaXR0ZW4gZGVwZW5kcyBvbiB0aGUgY2hpcCBJRC4gQXMgdGhlIE1URCBmcmFtZXdvcmsg ZG9lc24ndCBwYXNzCj4gdGhpcyBjaGlwIElEIGluIGl0J3MgZGF0YSBzdHJ1Y3R1cmVzLCB3ZSBt dXN0IGNhbGN1bGF0ZSB0aGF0IGluCj4gdXNlcnNwYWNlLgoKeWVzLCBJIGFncmVlIHRoZSByaWdo dCBhcHByb2FjaCBpZiB5b3UgbmVlZCB0byB3cml0ZSB0aGVzZSBpcyB0bwpwZXJmb3JtIHJhdyBP T0Igd3JpdGVzIHdpdGggdmFsdWVzIGNhbGN1bGF0ZWQgbWFudWFsbHkuCgo+IFRoZXJlZm9yZSBi b3RoIFJBVyBhbmQgSFcgbW9kZSBtdXN0IHBhc3MgdGhlIFBBIGJ5dGVzLgoKWWVzLCBubyBwcm9i bGVtIHdpdGggdGhhdC4KCj4gPT09Cj4gCj4gVGhlIE5GQyBoYXJkd2FyZSBpcyBjYXBhYmxlIGZv ciBhIDE2IGJpdCBidXMsIGJ1dCBub3QgaW1wbGVtZW50ZWQgeWV0Lgo+IFJlc2VydmVkIGFyZSBz dGFuZGFyZCAyIGJpdHMgZm9yIHRoZSBCQk0gZm9yIGEgY29uc2lzdGFudGVuY3kgYnkgdGhlCj4g b3JpZ2luYWwgYXV0aG9yLgo+IAo+ID09PQo+IAo+IGNoaXAtPm9vYl9wb2kgYnVmZmVyIGxheW91 dCBmb3IgOCBzdGVwczoKPiAKPiBCQk0wICAgQkJNMSAgT09CMiAgT09CMyAgfCBPT0I0ICBPT0I1 ICBPT0I2ICBPT0I3Cj4gCj4gT09COCAgIE9PQjkgIE9PQjEwIE9PQjExIHwgT09CMTIgT09CMTMg T09CMTUgT09CMTUKPiBPT0IxNiAgT09CMTcgT09CMTggT09CMTkgfCBPT0IyMCBPT0IyMSBPT0Iy MiBPT0IyMwo+IAo+IE9PQjI0ICBPT0IyNSBPT0IyNiBPT0IyNyB8IFBBMCAgIFBBMSAgIFBBMiAg IFBBMwo+IAo+IEVDQzAgICBFQ0MxICBFQ0MyICBFQ0MzICB8IC4uLiAgIC4uLiAgIC4uLiAgIC4u LgoKWWVzLgoKPiAKPiA9PT0KPiAKPiBya19uZmNfb29ibGF5b3V0X2ZyZWU6Cj4gb29iX3JlZ2lv bi0+bGVuZ3RoID0gcmtuYW5kLT5tZXRhZGF0YV9zaXplIC0gTkZDX1NZU19EQVRBX1NJWkUgLSAy Owo+ICAgICAgICAgICAgICAgICAgICA9IDMyIC0gNCAtIDIKPiAgICAgICAgICAgICAgICAgICAg PSAyNgo+IAo+IG9vYl9yZWdpb24tPm9mZnNldCA9IDI7Cj4gCj4gRnJlZSBPT0Igc2hvdWxkIHN0 YXJ0IGF0IE9PQjIgdG8gbm90IG92ZXJ3cml0ZSBQQSBkYXRhLgoKWWVzLgoKPiAKPiA9PT0KPiAK PiBya19uZmNfb29ibGF5b3V0X2VjYzoKPiAJb29iX3JlZ2lvbi0+bGVuZ3RoID0gbXRkLT5vb2Jz aXplIC0gcmtuYW5kLT5tZXRhZGF0YV9zaXplOwo+IAkgICAgICAgICAgICAgICAgICAgPSA2NDAg LSAzMgo+IAkgICAgICAgICAgICAgICAgICAgPSA2MDgKPiAJb29iX3JlZ2lvbi0+b2Zmc2V0ID0g cmtuYW5kLT5tZXRhZGF0YV9zaXplOwo+IAkgICAgICAgICAgICAgICAgICAgPSAzMgo+IAo+IEVD QyBkYXRhIHN0YXJ0cyBhdCBvZmZzZXQgMzIuCgpZZXMuCgo+IAo+ID09PQo+IAo+IAo+ID4gICAK PiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEpvaGFuIEpvbmtlciA8amJ4NjI0NEBnbWFpbC5jb20+ Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3JvY2tjaGlwLW5hbmQtY29udHJv bGxlci5jIHwgMTEgKysrKy0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9yb2NrY2hpcC1uYW5kLWNvbnRyb2xsZXIuYwo+ID4+IGIvZHJpdmVycy9tdGQvbmFu ZC9yYXcvcm9ja2NoaXAtbmFuZC1jb250cm9sbGVyLmMgaW5kZXgKPiA+PiAzMWQ4YzdhODcuLmZj ZGE0Yzc2MCAxMDA2NDQgLS0tCj4gPj4gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9yb2NrY2hpcC1u YW5kLWNvbnRyb2xsZXIuYyArKysKPiA+PiBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3JvY2tjaGlw LW5hbmQtY29udHJvbGxlci5jIEBAIC01NjYsOQo+ID4+ICs1NjYsMTAgQEAgc3RhdGljIGludCBy a19uZmNfd3JpdGVfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcAo+ID4+ICpjaGlwLCBjb25zdCB1 OCAqYnVmLAo+ID4+ICAJCSAqICAgIEJCTSAgT09CMSBPT0IyIE9PQjMgfC4uLi4uLnwgIFBBMCAg UEExICBQQTIKPiA+PiAgUEEzICoKPiA+PiAgCQkgKiBUaGUgcmtfbmZjX29vYmxheW91dF9mcmVl KCkgZnVuY3Rpb24gYWxyZWFkeQo+ID4+IGhhcyByZXNlcnZlZAo+ID4+IC0JCSAqIHRoZXNlIDQg Ynl0ZXMgd2l0aDoKPiA+PiArCQkgKiB0aGVzZSA0IGJ5dGVzIHRvZ2V0aGVyIHdpdGggMiBieXRl cyBmb3IgQkJNCj4gPj4gKwkJICogYnkgcmVkdWNpbmcgaXQncyBsZW5ndGg6Cj4gPj4gIAkJICoK PiA+PiAtCQkgKiBvb2JfcmVnaW9uLT5vZmZzZXQgPSBORkNfU1lTX0RBVEFfU0laRSArIDI7Cj4g Pj4gKwkJICogb29iX3JlZ2lvbi0+bGVuZ3RoID0gcmtuYW5kLT5tZXRhZGF0YV9zaXplIC0KPiA+ PiBORkNfU1lTX0RBVEFfU0laRSAtIDI7ICovCj4gPj4gIAkJaWYgKCFpKQo+ID4+ICAJCQltZW1j cHkocmtfbmZjX29vYl9wdHIoY2hpcCwgaSksCj4gPj4gQEAgLTk0NSwxMiArOTQ2LDggQEAgc3Rh dGljIGludCBya19uZmNfb29ibGF5b3V0X2ZyZWUoc3RydWN0Cj4gPj4gbXRkX2luZm8gKm10ZCwg aW50IHNlY3Rpb24sIGlmIChzZWN0aW9uKQo+ID4+ICAJCXJldHVybiAtRVJBTkdFOwo+ID4+Cj4g Pj4gLQkvKgo+ID4+IC0JICogVGhlIGJlZ2lubmluZyBvZiB0aGUgT09CIGFyZWEgc3RvcmVzIHRo ZSByZXNlcnZlZCBkYXRhCj4gPj4gZm9yIHRoZSBORkMsCj4gPj4gLQkgKiB0aGUgc2l6ZSBvZiB0 aGUgcmVzZXJ2ZWQgZGF0YSBpcyBORkNfU1lTX0RBVEFfU0laRQo+ID4+IGJ5dGVzLgo+ID4+IC0J ICovCj4gPj4gIAlvb2JfcmVnaW9uLT5sZW5ndGggPSBya25hbmQtPm1ldGFkYXRhX3NpemUgLQo+ ID4+IE5GQ19TWVNfREFUQV9TSVpFIC0gMjsKPiA+PiAtCW9vYl9yZWdpb24tPm9mZnNldCA9IE5G Q19TWVNfREFUQV9TSVpFICsgMjsKPiA+PiArCW9vYl9yZWdpb24tPm9mZnNldCA9IDI7Cj4gPj4K PiA+PiAgCXJldHVybiAwOwo+ID4+ICB9Cj4gPj4gLS0KPiA+PiAyLjMwLjIKPiA+PiAgCj4gPiAK PiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobCAgCgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVRE IGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81DC0EB64D8 for ; Wed, 14 Jun 2023 16:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+vLx+o0J2qrEoo2Px6hkVU0XiOjJLzdM829D9dRLfg8=; b=XKIiCmVmJFq3YB LtZKJb8nPm18S1ERmeHxCK5PqekHdOjhBaoD3XsUtiMsL3c+mV2hh9O+t6ufZ/5tSaPL61Cj2GGKm /aEagsjjQRDbT7cThTfPZeM7Vd+fozizvi8bK8bJgdu9tyYzedJsXfFkEvIOl7mjutixz3qUwh6wI yoUOHAy3Axypu2APhxRWUMNr693FyCPtD3qBZyYL+2MWiSaW/vmj0Nao7b7fGBrGVanwjJddQ8e6J yiYQDPPDZg75SO2qU2sHX4wmqZ80ly4HnfgJnhMuP5mPHk+Ol2xgl2YV7IO4EKdciChyDAk+c08D9 9ZGiZYOoGH5KhutwUKCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9Svw-00C9Mc-0C; Wed, 14 Jun 2023 16:01:20 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9Svq-00C9LN-1h; Wed, 14 Jun 2023 16:01:17 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686758470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOV8LTn0vFlBeWdljLVATJ2Xq6J3HagcK9Y6oImy8+I=; b=fRGb2XnKJ8tgpUp/9ld7byMjVBjI+NtTqmuPLCJQswKll3RH+qfto8GuosQiirtT9+NZnS HF+mc5EJGkvXfdHHjlKJ8ZuZnEtq5zK/sgepxyCDk12T4bhqrAZQGtKSi5qE/SEmCJkn82 vQ0e7s8aN9BLy3BMzSx79JEqpFVwFDxT94IZk7b/K7ZaAilMKpcHGGfLvEbqvAe8JLVf2R DW9Rgvf76DtSFQfStU8xfDwSg122Orq2k67dvdqEf89xf/UVICkA8wQOnzsN+8stD11FEz KVzgEbOSrFTejmgPrjkMyob9lZRTD77L3J3qFTQgxAxja/cH71wSruox1JRCtg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B83E20004; Wed, 14 Jun 2023 16:01:09 +0000 (UTC) Date: Wed, 14 Jun 2023 18:01:08 +0200 From: Miquel Raynal To: Johan Jonker Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com Subject: Re: [PATCH v2 3/5] mtd: nand: raw: rockchip-nand-controller: fix oobfree offset and description Message-ID: <20230614180108.5b202077@xps-13> In-Reply-To: <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> References: <11e16c3b-6f7b-a6a9-b0ed-b7ac0cd703e3@gmail.com> <20230612192640.63baf3e8@xps-13> <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_090114_884625_29B6D65E X-CRM114-Status: GOOD ( 48.90 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgSm9oYW4sCgpqYng2MjQ0QGdtYWlsLmNvbSB3cm90ZSBvbiBXZWQsIDE0IEp1biAyMDIzIDEx OjIzOjQ0ICswMjAwOgoKPiBPbiA2LzEyLzIzIDE5OjI2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ ID4gSGkgSm9oYW4sCj4gPiAKPiA+IGpieDYyNDRAZ21haWwuY29tIHdyb3RlIG9uIE1vbiwgMTIg SnVuIDIwMjMgMTc6MDM6MTggKzAyMDA6Cj4gPiAgIAo+ID4+IFRoZSBNVEQgZnJhbWV3b3JrIHJl c2VydmVzIDEgb3IgMiBieXRlcyBmb3IgdGhlIGJhZCBibG9jayBtYXJrZXIKPiA+PiBkZXBlbmRp bmcgb24gdGhlIGJ1cyBzaXplLiBUaGUgcm9ja2NoaXAtbmFuZC1jb250cm9sbGVyIGRyaXZlcgo+ ID4+IGN1cnJlbnRseSBvbmx5IHN1cHBvcnRzIGEgOCBiaXQgYnVzLCBidXQgcmVzZXJ2ZXMgc3Rh bmRhcmQgMiBieXRlcwo+ID4+IGZvciB0aGUgQkJNLiAgCj4gPiAKPiA+IFdlIGFsd2F5cyByZXNl cnZlIDIgYnl0ZXMsIG5vPyAgCj4gCj4gTm90IGFsd2F5cyB1c2VkLCBidXQgZm9yIGNvbnNpc3Rl bmN5L3NpbXBsaWNpdHkgdGhlIGF1dGhvciBhc3N1bWVzL3Jlc2VydmVzIDIgYnl0ZXMuIAoKSXQn cyBraW5kIG9mIGFuIGltcGxpY2l0IHJ1bGUgaW4gdGhlIHJhdyBOQU5EIHN1YnN5c3RlbS4gSXQn cyBub3QgYW4KYXV0aG9yIGNob2ljZS4KCj4gPj4gVGhlIGZpcnN0IGZyZWUgT09CIGJ5dGUgaXMg dGhlcmVmb3JlIE9PQjIgYXQgb2Zmc2V0IDIuCj4gPj4gUGFnZSBhZGRyZXNzKFBBKSBieXRlcyBh cmUgbW92ZWQgdG8gdGhlIGxhc3QgNCBwb3NpdGlvbnMgYmVmb3JlCj4gPj4gRUNDLiBVcGRhdGUg dGhlIGRlc2NyaXB0aW9uIGZvciBMaW51eC4gIAo+ID4gCj4gPiBUaGUgZGVzY3JpcHRpb24gc2hv dWxkIGp1c3QgYmU6Cj4gPiAgIAo+IAo+ID4gTW92ZSBQYWdlIEFkZHJlc3MgKFBBKSBieXRlcyB0 byB0aGUgbGFzdCA0IHBvc2l0aW9ucyBiZWZvcmUgRUNDLiAgCj4gCj4gU3BhY2UgaXMgYWxyZWFk eSByZXNlcnZlZCwgYnV0IG92ZXJ3cml0dGVuLgoKV2VsbCwgSSBkb24ndCBrbm93LCBidXQgSSdt IHF1b3RpbmcgeW91ciBjb21taXQgbG9nICJQYWdlIGFkZHJlc3MoUEEpCmJ5dGVzIGFyZSBtb3Zl ZCB0byB0aGUgbGFzdCA0IHBvc2l0aW9ucyBiZWZvcmUgRUNDIiBhbmQgaWYgdGhpcwpzZW50ZW5j ZSBpcyByaWdodCwgSSBhbSBwcm9wb3NpbmcgYW5vdGhlciB3YXkgdG8gc2F5IHRoaXMgd2hpY2gg c291bmRzCm1vcmUgZGVjbGFyYXRpdmUuCgo+IAo+ID4gCj4gPiBBbmQgdGhlbiB5b3Ugc2hvdWxk IGp1c3RpZnkgd2h5IHRoaXMgaXMgbmVlZGVkLiBBbHNvLCB0aGlzIHdvdWxkCj4gPiBicmVhayBh bGwgZXhpc3RpbmcgamZmczIgdXNlcnMsIHJpZ2h0PyAgCj4gCj4gSGkgTWlxdWVsLAo+IAo+IEZy b20geW91ciBjb21tZW50cyBpdCBzZWVtcyB0aGF0IHRoZSBjaGlwLT5vb2JfcG9pIGJ1ZmZlciBs YXlvdXQgaXMKPiBzdGlsbCBub3QgY2xlYXIgdG8geW91LiBIb3BlIHRoYXQgdGhpcyB0ZXh0IGJl bG93IGhlbHBzLgo+IElmIGV4aXN0aW5nIGpmZnMyIHVzZXJzIG9mIGZyZWUgT09CIGFyZSB3cml0 aW5nCgpUaGV5IGFyZSwgaXQncyB0aGUgZmlyc3QgdGhpbmcgdGhhdCBqamZzMiBkb2VzOiB3cml0 aW5nIGNsZWFubWFya2VycyBpbgp0aGUgZnJlZSBhcmVhLgoKPiB0aGV5IGFyZSBjb3JydXB0aW5n Cj4gb3VyIFBBIGRhdGEgaW4gUkFXIG1vZGUuIFNvIHRoYXQgbXVzdCBiZSBmaXhlZC4gCgpJIGRp ZCBub3QgeWV0IHVuZGVyc3RhbmQgd2hldGhlciBjb3JydXB0aW5nIHRoZSBQQSBkYXRhIHdhcyBh biBhYnNvbHV0ZQptaXN0YWtlIG9yIGlmIGl0IHdhcyBzcGVjaWZpYyB0byBhIGdpdmVuIHJhbmdl IG9mIFJPTSBjb2Rlcy4gQnV0IGxldCdzCmFzc3VtZSBpdCBtdXN0IGJlIGZpeGVkLgoKPiBQbGVh c2UgYWR2aXNlIGhvdyB3ZQo+IHNwbGl0IHByZSBhbmQgcG9zdCBjaGFuZ2UgdXNlcnMuCgpJZiB5 b3UgY2hhbmdlIHRoZSBsYXlvdXQsIHlvdSBicmVhayB1c2Vycy4gVGhlcmUgaXMgbm8gcXVlc3Rp b24gaGVyZS4KQnV0IGlmIHlvdSBkbyB0aGF0LCB3ZSBuZWVkOgotIGEgY3J5c3RhbCBjbGVhciBl eHBsYW5hdGlvbiBvZiB3aHkgdGhpcyBpcyBuZWVkZWQKLSB0byBzYXkgaXQgY2xlYXJseTogdGhp cyBjaGFuZ2UgYnJlYWtzIGV4aXN0aW5nIGpmZnMyIHVzZXJzCgo+IChXaXRoIGEgTW9kdWxlIHBh cmFtZXRlciBsaWtlCj4gc2tpcGJidCByZW5hbWVkIHRvICJ1c2VyX21vZGUiID0gMCBvZmZzZXQg NiwgInVzZXJfbW9kZSIgPSAxIG9mZnNldAoKSSBrbm93IHRoZSBjYWZlIGRyaXZlciBkb2VzIHRo YXQsIGl0IGlzIGF3ZnVsIElNSE8uCgo+IDIpIENvcHlpbmcgUEEgZGF0YSBpbiBib3RoIFJBVyBh bmQgSFcgbW9kZSBoYXMgYWxyZWFkeSByZXNlcnZlZCBzcGFjZQo+IGluIHRoZSBsYXlvdXQuIExl dCBtZSBrbm93IGlmIEkgY2FuIGhlbHAgdG8gZ2V0IGZvcndhcmQgaGVyZS4KPiAKPiBKb2hhbgo+ IAo+ID09PQo+IAo+IEdpdmVuOgo+IAo+IFJvY2tjaGlwIHJrMzA2NiBNSzgwOCB3aXRoIE5BTkQ6 Cj4gbmFuZDogSHluaXggSDI3VUNHOFQyQVRSLUJDIDY0RyAzLjNWIDgtYml0Cj4gbmFuZDogODE5 MiBNaUIsIE1MQywgZXJhc2Ugc2l6ZTogMjA0OCBLaUIsIHBhZ2Ugc2l6ZTogODE5MiwgT09CIHNp emU6Cj4gNjQwCj4gCj4gPT09Cj4gCj4gQ2FsdWxhdGlvbnM6Cj4gCj4gI2RlZmluZSBORkNfU1lT X0RBVEFfU0laRQkJKDQpIC8qIDQgYnl0ZXMgc3lzIGRhdGEgaW4KPiBvb2IgcHJlIDEwMjQgZGF0 YS4qLwo+IAo+IFNvIHBlciBzdGVwIG9ubHkgNCBieXRlcyBvZiBPT0IgY2FuIGJlIHJlYWQuCgpJ IHRoaW5rIEkgZ2V0IHdoYXQgeW91IG1lYW4gYnV0IHRoZSBhYm92ZSBzZW50ZW5jZSBpcyB3cm9u Zy4gWW91IGNhbgphbHdheXMgcmVhZCB0aGUgZnVsbCBPT0IgaW4gcmF3IG1vZGUuIEFuZCBpbiBn ZW5lcmFsIHlvdSBjYW4gYXMgd2VsbCBpbgpob3N0IEVDQyBtb2RlLiBUaGVuIHdoYXQgdXNlcnMg ZG8gd2l0aCB0aGUgT09CIGluZm9ybWF0aW9uIGlzCm9ydGhvZ29uYWwuIEhvd2V2ZXIsIGlmIHRo ZXkgZG9uJ3Qgd2FudCB0aGVpciBkYXRhIHRvIGJlIHNtYXNoZWQsIHRoZXkKY2FuIHJlcXVlc3Qg dGhlIGluZm9ybWF0aW9uIGFib3V0IHdoaWNoIGJ5dGVzIGFyZSBmcmVlIHRvIGJlIHVzZWQKKHR5 cGljYWxseSB3aGF0IGpmZnMyIGRvZXMsIHdoaWxlIHViaSBkb2VzIG5vdCBjYXJlIGFib3V0IE9P QikuIFRoZSBvb2IKbGF5b3V0IGhlbHBlcnMgY2FuIHRoZW4gcmVzdHJhaW4gdGhlIGFkdmVydGlz ZWQgZnJlZSBhcmVhIHRvIG9ubHkgc2hhcmUKYnl0ZXMgd2hpY2ggYXJlIG5vdCB1c2VkIGJ5IHRo ZSBQQS4KCj4gCj4gPT09Cj4gCj4gVGhlIE5GQyBjYW4gcmVhZC93cml0ZSBpbiAxMDI0IGRhdGEg Ynl0ZXMgcGVyIHN0ZXAuCj4gVG8gcmVhZC93cml0ZSBhIGZ1bGwgcGFnZSBpdCBuZWVkcyA4IHN0 ZXBzLgo+IAo+IGNoaXAtPmVjYy5zaXplID0gMTAyNDsKPiBjaGlwLT5lY2Muc3RlcHMgPSBtdGQt PndyaXRlc2l6ZSAvIGNoaXAtPmVjYy5zaXplOwo+ICAgICAgICAgICAgICAgICA9IDgxOTIgLyAx MDI0Cj4gICAgICAgICAgICAgICAgID0gOCBzdGVwcwo+ID09PQo+IAo+IFRoZSB0b3RhbCBzaXpl IG9mIHVzZWZ1bGwgT09CIGJlZm9yZSBFQ0M6Cj4gCj4gcmtuYW5kLT5tZXRhZGF0YV9zaXplID0g TkZDX1NZU19EQVRBX1NJWkUgKiBlY2MtPnN0ZXBzOwo+ICAgICAgICAgICAgICAgICAgICAgICA9 IDQgKiA4Cj4gICAgICAgICAgICAgICAgICAgICAgID0gMzIKPiA9PT0KPiAKPiBXcm9uZyBmcmVl IE9PQiBvZmZzZXQgc3RhcnRzIGF0IE9PQjY6Cj4gb29iX3JlZ2lvbi0+b2Zmc2V0ID0gTkZDX1NZ U19EQVRBX1NJWkUgKyAyOwo+ICAgICAgICAgICAgICAgICAgICA9IDQgKyAyCj4gICAgICAgICAg ICAgICAgICAgID0gNgo+IAo+IFdpdGggYSBmcmVlIE9PQiBvZmZzZXQgb2YgNiBhbmQgYSBsZW5n dGggb2YgMjYgPT0+IDYgKyAyNiA9IDMyIHdlCj4gY29ycnVwdCB0aGUgUEEgYWRkcmVzcyBzdGFy dGluZyBhdCBvZmZzZXQgMjguCj4gCj4gTmV3IG9mZnNldCBPT0IyOgo+IG9vYl9yZWdpb24tPm9m ZnNldCA9IDI7Cj4gCj4gVGhlIGZ1bGwgcmFuZ2Ugb2YgZnJlZSBydW5zIGZyb20gT09CMiB0aWxs L2luY2x1ZGluZyBPT0IyNy4KPiA9PT0KPiAKPiBUaGUgbGFzdCA0IGJ5dGVzIG9mIG1ldGFkYXRh IGFyZSByZXNlcnZlZCBmb3IgdGhpcyBQYWdlIEFkZHJlc3MoUEEpCj4gZm9yIHRoZSBib290cm9t LiBDdXJyZW50bHkgb25seSBpbiB1c2UgaW4gUkFXIG1vZGUuCgpJJ20gbm90IHN1cmUgdG8gdW5k ZXJzdGFuZCB3aGF0ICJjdXJyZW50bHkgb24gbHkgaW4gdXNlIGluIHJhdyBtb2RlIi4KCkluIHJh dyBtb2RlLCB0aGUgdXNlciBjYW4gb3ZlcndyaXRlIHRoZSB3aG9sZSBPT0IgYXJlYSwgaXQgaXMg dGhlIHVzZXIKaW5wdXQgd2hhdCBzaG91bGQgYmUgd3JpdHRlbiBpbiBlYWNoIGFuZCBldmVyeSBi eXRlLgoKSW4gRUNDIG1vZGUgdGhlIEVDQyBlbmdpbmUgd2lsbCBzbWFzaCBzb21lIG9mIHRoaXMg ZGF0YSB0byB3cml0ZSBpdHMKb3duIEVDQyBieXRlcy4KCj4gVGhlIGN1cnJlbnQgUEEgY2FsY3Vs YXRpb24gbmVlZGVkIHRvIHdyaXRlIGJvb3QgYmxvY2tzIGZvciBhbGwKPiBSb2NrY2hpcCBTb0Nz IGlzIGhvd2V2ZXIgdXNlbGVzcy4gVGhlIHBhdHRlcm4gb2Ygd2hlcmUgdGhlIG5leHQgcGFnZQo+ IGlzIHdyaXR0ZW4gZGVwZW5kcyBvbiB0aGUgY2hpcCBJRC4gQXMgdGhlIE1URCBmcmFtZXdvcmsg ZG9lc24ndCBwYXNzCj4gdGhpcyBjaGlwIElEIGluIGl0J3MgZGF0YSBzdHJ1Y3R1cmVzLCB3ZSBt dXN0IGNhbGN1bGF0ZSB0aGF0IGluCj4gdXNlcnNwYWNlLgoKeWVzLCBJIGFncmVlIHRoZSByaWdo dCBhcHByb2FjaCBpZiB5b3UgbmVlZCB0byB3cml0ZSB0aGVzZSBpcyB0bwpwZXJmb3JtIHJhdyBP T0Igd3JpdGVzIHdpdGggdmFsdWVzIGNhbGN1bGF0ZWQgbWFudWFsbHkuCgo+IFRoZXJlZm9yZSBi b3RoIFJBVyBhbmQgSFcgbW9kZSBtdXN0IHBhc3MgdGhlIFBBIGJ5dGVzLgoKWWVzLCBubyBwcm9i bGVtIHdpdGggdGhhdC4KCj4gPT09Cj4gCj4gVGhlIE5GQyBoYXJkd2FyZSBpcyBjYXBhYmxlIGZv ciBhIDE2IGJpdCBidXMsIGJ1dCBub3QgaW1wbGVtZW50ZWQgeWV0Lgo+IFJlc2VydmVkIGFyZSBz dGFuZGFyZCAyIGJpdHMgZm9yIHRoZSBCQk0gZm9yIGEgY29uc2lzdGFudGVuY3kgYnkgdGhlCj4g b3JpZ2luYWwgYXV0aG9yLgo+IAo+ID09PQo+IAo+IGNoaXAtPm9vYl9wb2kgYnVmZmVyIGxheW91 dCBmb3IgOCBzdGVwczoKPiAKPiBCQk0wICAgQkJNMSAgT09CMiAgT09CMyAgfCBPT0I0ICBPT0I1 ICBPT0I2ICBPT0I3Cj4gCj4gT09COCAgIE9PQjkgIE9PQjEwIE9PQjExIHwgT09CMTIgT09CMTMg T09CMTUgT09CMTUKPiBPT0IxNiAgT09CMTcgT09CMTggT09CMTkgfCBPT0IyMCBPT0IyMSBPT0Iy MiBPT0IyMwo+IAo+IE9PQjI0ICBPT0IyNSBPT0IyNiBPT0IyNyB8IFBBMCAgIFBBMSAgIFBBMiAg IFBBMwo+IAo+IEVDQzAgICBFQ0MxICBFQ0MyICBFQ0MzICB8IC4uLiAgIC4uLiAgIC4uLiAgIC4u LgoKWWVzLgoKPiAKPiA9PT0KPiAKPiBya19uZmNfb29ibGF5b3V0X2ZyZWU6Cj4gb29iX3JlZ2lv bi0+bGVuZ3RoID0gcmtuYW5kLT5tZXRhZGF0YV9zaXplIC0gTkZDX1NZU19EQVRBX1NJWkUgLSAy Owo+ICAgICAgICAgICAgICAgICAgICA9IDMyIC0gNCAtIDIKPiAgICAgICAgICAgICAgICAgICAg PSAyNgo+IAo+IG9vYl9yZWdpb24tPm9mZnNldCA9IDI7Cj4gCj4gRnJlZSBPT0Igc2hvdWxkIHN0 YXJ0IGF0IE9PQjIgdG8gbm90IG92ZXJ3cml0ZSBQQSBkYXRhLgoKWWVzLgoKPiAKPiA9PT0KPiAK PiBya19uZmNfb29ibGF5b3V0X2VjYzoKPiAJb29iX3JlZ2lvbi0+bGVuZ3RoID0gbXRkLT5vb2Jz aXplIC0gcmtuYW5kLT5tZXRhZGF0YV9zaXplOwo+IAkgICAgICAgICAgICAgICAgICAgPSA2NDAg LSAzMgo+IAkgICAgICAgICAgICAgICAgICAgPSA2MDgKPiAJb29iX3JlZ2lvbi0+b2Zmc2V0ID0g cmtuYW5kLT5tZXRhZGF0YV9zaXplOwo+IAkgICAgICAgICAgICAgICAgICAgPSAzMgo+IAo+IEVD QyBkYXRhIHN0YXJ0cyBhdCBvZmZzZXQgMzIuCgpZZXMuCgo+IAo+ID09PQo+IAo+IAo+ID4gICAK PiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEpvaGFuIEpvbmtlciA8amJ4NjI0NEBnbWFpbC5jb20+ Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3JvY2tjaGlwLW5hbmQtY29udHJv bGxlci5jIHwgMTEgKysrKy0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9yb2NrY2hpcC1uYW5kLWNvbnRyb2xsZXIuYwo+ID4+IGIvZHJpdmVycy9tdGQvbmFu ZC9yYXcvcm9ja2NoaXAtbmFuZC1jb250cm9sbGVyLmMgaW5kZXgKPiA+PiAzMWQ4YzdhODcuLmZj ZGE0Yzc2MCAxMDA2NDQgLS0tCj4gPj4gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9yb2NrY2hpcC1u YW5kLWNvbnRyb2xsZXIuYyArKysKPiA+PiBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3JvY2tjaGlw LW5hbmQtY29udHJvbGxlci5jIEBAIC01NjYsOQo+ID4+ICs1NjYsMTAgQEAgc3RhdGljIGludCBy a19uZmNfd3JpdGVfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcAo+ID4+ICpjaGlwLCBjb25zdCB1 OCAqYnVmLAo+ID4+ICAJCSAqICAgIEJCTSAgT09CMSBPT0IyIE9PQjMgfC4uLi4uLnwgIFBBMCAg UEExICBQQTIKPiA+PiAgUEEzICoKPiA+PiAgCQkgKiBUaGUgcmtfbmZjX29vYmxheW91dF9mcmVl KCkgZnVuY3Rpb24gYWxyZWFkeQo+ID4+IGhhcyByZXNlcnZlZAo+ID4+IC0JCSAqIHRoZXNlIDQg Ynl0ZXMgd2l0aDoKPiA+PiArCQkgKiB0aGVzZSA0IGJ5dGVzIHRvZ2V0aGVyIHdpdGggMiBieXRl cyBmb3IgQkJNCj4gPj4gKwkJICogYnkgcmVkdWNpbmcgaXQncyBsZW5ndGg6Cj4gPj4gIAkJICoK PiA+PiAtCQkgKiBvb2JfcmVnaW9uLT5vZmZzZXQgPSBORkNfU1lTX0RBVEFfU0laRSArIDI7Cj4g Pj4gKwkJICogb29iX3JlZ2lvbi0+bGVuZ3RoID0gcmtuYW5kLT5tZXRhZGF0YV9zaXplIC0KPiA+ PiBORkNfU1lTX0RBVEFfU0laRSAtIDI7ICovCj4gPj4gIAkJaWYgKCFpKQo+ID4+ICAJCQltZW1j cHkocmtfbmZjX29vYl9wdHIoY2hpcCwgaSksCj4gPj4gQEAgLTk0NSwxMiArOTQ2LDggQEAgc3Rh dGljIGludCBya19uZmNfb29ibGF5b3V0X2ZyZWUoc3RydWN0Cj4gPj4gbXRkX2luZm8gKm10ZCwg aW50IHNlY3Rpb24sIGlmIChzZWN0aW9uKQo+ID4+ICAJCXJldHVybiAtRVJBTkdFOwo+ID4+Cj4g Pj4gLQkvKgo+ID4+IC0JICogVGhlIGJlZ2lubmluZyBvZiB0aGUgT09CIGFyZWEgc3RvcmVzIHRo ZSByZXNlcnZlZCBkYXRhCj4gPj4gZm9yIHRoZSBORkMsCj4gPj4gLQkgKiB0aGUgc2l6ZSBvZiB0 aGUgcmVzZXJ2ZWQgZGF0YSBpcyBORkNfU1lTX0RBVEFfU0laRQo+ID4+IGJ5dGVzLgo+ID4+IC0J ICovCj4gPj4gIAlvb2JfcmVnaW9uLT5sZW5ndGggPSBya25hbmQtPm1ldGFkYXRhX3NpemUgLQo+ ID4+IE5GQ19TWVNfREFUQV9TSVpFIC0gMjsKPiA+PiAtCW9vYl9yZWdpb24tPm9mZnNldCA9IE5G Q19TWVNfREFUQV9TSVpFICsgMjsKPiA+PiArCW9vYl9yZWdpb24tPm9mZnNldCA9IDI7Cj4gPj4K PiA+PiAgCXJldHVybiAwOwo+ID4+ICB9Cj4gPj4gLS0KPiA+PiAyLjMwLjIKPiA+PiAgCj4gPiAK PiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobCAgCgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBt YWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAC69EB64D9 for ; Wed, 14 Jun 2023 16:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5VGDKoF8YjQXbG83wpC9xo2JJHxQBwzWof6Beqne5lY=; b=jOlHRaSAq9XH5Z KSq8HcpTFtU3ZOcDdXMca1CPU+JVXWnv1Ux1AlmJJe0H9HPuIyB9/NqH90IlO0JqIta+JHdhjiFNi qnXWbk/Ml7jtaxiMD7ErZmp3yfQa7v18wE+6ec4KA0Q6DHBt6rkry+FRUw2+3hLsWPzOio4+ylpPA gQcTTPgF6LoW8n52GHxSo6adm+fxAVspyr0L2E0ETBWi4jaw1b9pE3P+Oqf1Olzj6dR0vjc5JvPNV WGLsKLiABi2qGvM624tL/Bdm9D5Iyv8cucatdkIyg7GwkQeTkHNu2ZzBmWlllTKnHdrkMwvv1233u fEXggGFJ3RjjQU6VhmYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9Svv-00C9MC-0B; Wed, 14 Jun 2023 16:01:19 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9Svq-00C9LN-1h; Wed, 14 Jun 2023 16:01:17 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686758470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOV8LTn0vFlBeWdljLVATJ2Xq6J3HagcK9Y6oImy8+I=; b=fRGb2XnKJ8tgpUp/9ld7byMjVBjI+NtTqmuPLCJQswKll3RH+qfto8GuosQiirtT9+NZnS HF+mc5EJGkvXfdHHjlKJ8ZuZnEtq5zK/sgepxyCDk12T4bhqrAZQGtKSi5qE/SEmCJkn82 vQ0e7s8aN9BLy3BMzSx79JEqpFVwFDxT94IZk7b/K7ZaAilMKpcHGGfLvEbqvAe8JLVf2R DW9Rgvf76DtSFQfStU8xfDwSg122Orq2k67dvdqEf89xf/UVICkA8wQOnzsN+8stD11FEz KVzgEbOSrFTejmgPrjkMyob9lZRTD77L3J3qFTQgxAxja/cH71wSruox1JRCtg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B83E20004; Wed, 14 Jun 2023 16:01:09 +0000 (UTC) Date: Wed, 14 Jun 2023 18:01:08 +0200 From: Miquel Raynal To: Johan Jonker Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com Subject: Re: [PATCH v2 3/5] mtd: nand: raw: rockchip-nand-controller: fix oobfree offset and description Message-ID: <20230614180108.5b202077@xps-13> In-Reply-To: <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> References: <11e16c3b-6f7b-a6a9-b0ed-b7ac0cd703e3@gmail.com> <20230612192640.63baf3e8@xps-13> <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_090114_884625_29B6D65E X-CRM114-Status: GOOD ( 48.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSm9oYW4sCgpqYng2MjQ0QGdtYWlsLmNvbSB3cm90ZSBvbiBXZWQsIDE0IEp1biAyMDIzIDEx OjIzOjQ0ICswMjAwOgoKPiBPbiA2LzEyLzIzIDE5OjI2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ ID4gSGkgSm9oYW4sCj4gPiAKPiA+IGpieDYyNDRAZ21haWwuY29tIHdyb3RlIG9uIE1vbiwgMTIg SnVuIDIwMjMgMTc6MDM6MTggKzAyMDA6Cj4gPiAgIAo+ID4+IFRoZSBNVEQgZnJhbWV3b3JrIHJl c2VydmVzIDEgb3IgMiBieXRlcyBmb3IgdGhlIGJhZCBibG9jayBtYXJrZXIKPiA+PiBkZXBlbmRp bmcgb24gdGhlIGJ1cyBzaXplLiBUaGUgcm9ja2NoaXAtbmFuZC1jb250cm9sbGVyIGRyaXZlcgo+ ID4+IGN1cnJlbnRseSBvbmx5IHN1cHBvcnRzIGEgOCBiaXQgYnVzLCBidXQgcmVzZXJ2ZXMgc3Rh bmRhcmQgMiBieXRlcwo+ID4+IGZvciB0aGUgQkJNLiAgCj4gPiAKPiA+IFdlIGFsd2F5cyByZXNl cnZlIDIgYnl0ZXMsIG5vPyAgCj4gCj4gTm90IGFsd2F5cyB1c2VkLCBidXQgZm9yIGNvbnNpc3Rl bmN5L3NpbXBsaWNpdHkgdGhlIGF1dGhvciBhc3N1bWVzL3Jlc2VydmVzIDIgYnl0ZXMuIAoKSXQn cyBraW5kIG9mIGFuIGltcGxpY2l0IHJ1bGUgaW4gdGhlIHJhdyBOQU5EIHN1YnN5c3RlbS4gSXQn cyBub3QgYW4KYXV0aG9yIGNob2ljZS4KCj4gPj4gVGhlIGZpcnN0IGZyZWUgT09CIGJ5dGUgaXMg dGhlcmVmb3JlIE9PQjIgYXQgb2Zmc2V0IDIuCj4gPj4gUGFnZSBhZGRyZXNzKFBBKSBieXRlcyBh cmUgbW92ZWQgdG8gdGhlIGxhc3QgNCBwb3NpdGlvbnMgYmVmb3JlCj4gPj4gRUNDLiBVcGRhdGUg dGhlIGRlc2NyaXB0aW9uIGZvciBMaW51eC4gIAo+ID4gCj4gPiBUaGUgZGVzY3JpcHRpb24gc2hv dWxkIGp1c3QgYmU6Cj4gPiAgIAo+IAo+ID4gTW92ZSBQYWdlIEFkZHJlc3MgKFBBKSBieXRlcyB0 byB0aGUgbGFzdCA0IHBvc2l0aW9ucyBiZWZvcmUgRUNDLiAgCj4gCj4gU3BhY2UgaXMgYWxyZWFk eSByZXNlcnZlZCwgYnV0IG92ZXJ3cml0dGVuLgoKV2VsbCwgSSBkb24ndCBrbm93LCBidXQgSSdt IHF1b3RpbmcgeW91ciBjb21taXQgbG9nICJQYWdlIGFkZHJlc3MoUEEpCmJ5dGVzIGFyZSBtb3Zl ZCB0byB0aGUgbGFzdCA0IHBvc2l0aW9ucyBiZWZvcmUgRUNDIiBhbmQgaWYgdGhpcwpzZW50ZW5j ZSBpcyByaWdodCwgSSBhbSBwcm9wb3NpbmcgYW5vdGhlciB3YXkgdG8gc2F5IHRoaXMgd2hpY2gg c291bmRzCm1vcmUgZGVjbGFyYXRpdmUuCgo+IAo+ID4gCj4gPiBBbmQgdGhlbiB5b3Ugc2hvdWxk IGp1c3RpZnkgd2h5IHRoaXMgaXMgbmVlZGVkLiBBbHNvLCB0aGlzIHdvdWxkCj4gPiBicmVhayBh bGwgZXhpc3RpbmcgamZmczIgdXNlcnMsIHJpZ2h0PyAgCj4gCj4gSGkgTWlxdWVsLAo+IAo+IEZy b20geW91ciBjb21tZW50cyBpdCBzZWVtcyB0aGF0IHRoZSBjaGlwLT5vb2JfcG9pIGJ1ZmZlciBs YXlvdXQgaXMKPiBzdGlsbCBub3QgY2xlYXIgdG8geW91LiBIb3BlIHRoYXQgdGhpcyB0ZXh0IGJl bG93IGhlbHBzLgo+IElmIGV4aXN0aW5nIGpmZnMyIHVzZXJzIG9mIGZyZWUgT09CIGFyZSB3cml0 aW5nCgpUaGV5IGFyZSwgaXQncyB0aGUgZmlyc3QgdGhpbmcgdGhhdCBqamZzMiBkb2VzOiB3cml0 aW5nIGNsZWFubWFya2VycyBpbgp0aGUgZnJlZSBhcmVhLgoKPiB0aGV5IGFyZSBjb3JydXB0aW5n Cj4gb3VyIFBBIGRhdGEgaW4gUkFXIG1vZGUuIFNvIHRoYXQgbXVzdCBiZSBmaXhlZC4gCgpJIGRp ZCBub3QgeWV0IHVuZGVyc3RhbmQgd2hldGhlciBjb3JydXB0aW5nIHRoZSBQQSBkYXRhIHdhcyBh biBhYnNvbHV0ZQptaXN0YWtlIG9yIGlmIGl0IHdhcyBzcGVjaWZpYyB0byBhIGdpdmVuIHJhbmdl IG9mIFJPTSBjb2Rlcy4gQnV0IGxldCdzCmFzc3VtZSBpdCBtdXN0IGJlIGZpeGVkLgoKPiBQbGVh c2UgYWR2aXNlIGhvdyB3ZQo+IHNwbGl0IHByZSBhbmQgcG9zdCBjaGFuZ2UgdXNlcnMuCgpJZiB5 b3UgY2hhbmdlIHRoZSBsYXlvdXQsIHlvdSBicmVhayB1c2Vycy4gVGhlcmUgaXMgbm8gcXVlc3Rp b24gaGVyZS4KQnV0IGlmIHlvdSBkbyB0aGF0LCB3ZSBuZWVkOgotIGEgY3J5c3RhbCBjbGVhciBl eHBsYW5hdGlvbiBvZiB3aHkgdGhpcyBpcyBuZWVkZWQKLSB0byBzYXkgaXQgY2xlYXJseTogdGhp cyBjaGFuZ2UgYnJlYWtzIGV4aXN0aW5nIGpmZnMyIHVzZXJzCgo+IChXaXRoIGEgTW9kdWxlIHBh cmFtZXRlciBsaWtlCj4gc2tpcGJidCByZW5hbWVkIHRvICJ1c2VyX21vZGUiID0gMCBvZmZzZXQg NiwgInVzZXJfbW9kZSIgPSAxIG9mZnNldAoKSSBrbm93IHRoZSBjYWZlIGRyaXZlciBkb2VzIHRo YXQsIGl0IGlzIGF3ZnVsIElNSE8uCgo+IDIpIENvcHlpbmcgUEEgZGF0YSBpbiBib3RoIFJBVyBh bmQgSFcgbW9kZSBoYXMgYWxyZWFkeSByZXNlcnZlZCBzcGFjZQo+IGluIHRoZSBsYXlvdXQuIExl dCBtZSBrbm93IGlmIEkgY2FuIGhlbHAgdG8gZ2V0IGZvcndhcmQgaGVyZS4KPiAKPiBKb2hhbgo+ IAo+ID09PQo+IAo+IEdpdmVuOgo+IAo+IFJvY2tjaGlwIHJrMzA2NiBNSzgwOCB3aXRoIE5BTkQ6 Cj4gbmFuZDogSHluaXggSDI3VUNHOFQyQVRSLUJDIDY0RyAzLjNWIDgtYml0Cj4gbmFuZDogODE5 MiBNaUIsIE1MQywgZXJhc2Ugc2l6ZTogMjA0OCBLaUIsIHBhZ2Ugc2l6ZTogODE5MiwgT09CIHNp emU6Cj4gNjQwCj4gCj4gPT09Cj4gCj4gQ2FsdWxhdGlvbnM6Cj4gCj4gI2RlZmluZSBORkNfU1lT X0RBVEFfU0laRQkJKDQpIC8qIDQgYnl0ZXMgc3lzIGRhdGEgaW4KPiBvb2IgcHJlIDEwMjQgZGF0 YS4qLwo+IAo+IFNvIHBlciBzdGVwIG9ubHkgNCBieXRlcyBvZiBPT0IgY2FuIGJlIHJlYWQuCgpJ IHRoaW5rIEkgZ2V0IHdoYXQgeW91IG1lYW4gYnV0IHRoZSBhYm92ZSBzZW50ZW5jZSBpcyB3cm9u Zy4gWW91IGNhbgphbHdheXMgcmVhZCB0aGUgZnVsbCBPT0IgaW4gcmF3IG1vZGUuIEFuZCBpbiBn ZW5lcmFsIHlvdSBjYW4gYXMgd2VsbCBpbgpob3N0IEVDQyBtb2RlLiBUaGVuIHdoYXQgdXNlcnMg ZG8gd2l0aCB0aGUgT09CIGluZm9ybWF0aW9uIGlzCm9ydGhvZ29uYWwuIEhvd2V2ZXIsIGlmIHRo ZXkgZG9uJ3Qgd2FudCB0aGVpciBkYXRhIHRvIGJlIHNtYXNoZWQsIHRoZXkKY2FuIHJlcXVlc3Qg dGhlIGluZm9ybWF0aW9uIGFib3V0IHdoaWNoIGJ5dGVzIGFyZSBmcmVlIHRvIGJlIHVzZWQKKHR5 cGljYWxseSB3aGF0IGpmZnMyIGRvZXMsIHdoaWxlIHViaSBkb2VzIG5vdCBjYXJlIGFib3V0IE9P QikuIFRoZSBvb2IKbGF5b3V0IGhlbHBlcnMgY2FuIHRoZW4gcmVzdHJhaW4gdGhlIGFkdmVydGlz ZWQgZnJlZSBhcmVhIHRvIG9ubHkgc2hhcmUKYnl0ZXMgd2hpY2ggYXJlIG5vdCB1c2VkIGJ5IHRo ZSBQQS4KCj4gCj4gPT09Cj4gCj4gVGhlIE5GQyBjYW4gcmVhZC93cml0ZSBpbiAxMDI0IGRhdGEg Ynl0ZXMgcGVyIHN0ZXAuCj4gVG8gcmVhZC93cml0ZSBhIGZ1bGwgcGFnZSBpdCBuZWVkcyA4IHN0 ZXBzLgo+IAo+IGNoaXAtPmVjYy5zaXplID0gMTAyNDsKPiBjaGlwLT5lY2Muc3RlcHMgPSBtdGQt PndyaXRlc2l6ZSAvIGNoaXAtPmVjYy5zaXplOwo+ICAgICAgICAgICAgICAgICA9IDgxOTIgLyAx MDI0Cj4gICAgICAgICAgICAgICAgID0gOCBzdGVwcwo+ID09PQo+IAo+IFRoZSB0b3RhbCBzaXpl IG9mIHVzZWZ1bGwgT09CIGJlZm9yZSBFQ0M6Cj4gCj4gcmtuYW5kLT5tZXRhZGF0YV9zaXplID0g TkZDX1NZU19EQVRBX1NJWkUgKiBlY2MtPnN0ZXBzOwo+ICAgICAgICAgICAgICAgICAgICAgICA9 IDQgKiA4Cj4gICAgICAgICAgICAgICAgICAgICAgID0gMzIKPiA9PT0KPiAKPiBXcm9uZyBmcmVl IE9PQiBvZmZzZXQgc3RhcnRzIGF0IE9PQjY6Cj4gb29iX3JlZ2lvbi0+b2Zmc2V0ID0gTkZDX1NZ U19EQVRBX1NJWkUgKyAyOwo+ICAgICAgICAgICAgICAgICAgICA9IDQgKyAyCj4gICAgICAgICAg ICAgICAgICAgID0gNgo+IAo+IFdpdGggYSBmcmVlIE9PQiBvZmZzZXQgb2YgNiBhbmQgYSBsZW5n dGggb2YgMjYgPT0+IDYgKyAyNiA9IDMyIHdlCj4gY29ycnVwdCB0aGUgUEEgYWRkcmVzcyBzdGFy dGluZyBhdCBvZmZzZXQgMjguCj4gCj4gTmV3IG9mZnNldCBPT0IyOgo+IG9vYl9yZWdpb24tPm9m ZnNldCA9IDI7Cj4gCj4gVGhlIGZ1bGwgcmFuZ2Ugb2YgZnJlZSBydW5zIGZyb20gT09CMiB0aWxs L2luY2x1ZGluZyBPT0IyNy4KPiA9PT0KPiAKPiBUaGUgbGFzdCA0IGJ5dGVzIG9mIG1ldGFkYXRh IGFyZSByZXNlcnZlZCBmb3IgdGhpcyBQYWdlIEFkZHJlc3MoUEEpCj4gZm9yIHRoZSBib290cm9t LiBDdXJyZW50bHkgb25seSBpbiB1c2UgaW4gUkFXIG1vZGUuCgpJJ20gbm90IHN1cmUgdG8gdW5k ZXJzdGFuZCB3aGF0ICJjdXJyZW50bHkgb24gbHkgaW4gdXNlIGluIHJhdyBtb2RlIi4KCkluIHJh dyBtb2RlLCB0aGUgdXNlciBjYW4gb3ZlcndyaXRlIHRoZSB3aG9sZSBPT0IgYXJlYSwgaXQgaXMg dGhlIHVzZXIKaW5wdXQgd2hhdCBzaG91bGQgYmUgd3JpdHRlbiBpbiBlYWNoIGFuZCBldmVyeSBi eXRlLgoKSW4gRUNDIG1vZGUgdGhlIEVDQyBlbmdpbmUgd2lsbCBzbWFzaCBzb21lIG9mIHRoaXMg ZGF0YSB0byB3cml0ZSBpdHMKb3duIEVDQyBieXRlcy4KCj4gVGhlIGN1cnJlbnQgUEEgY2FsY3Vs YXRpb24gbmVlZGVkIHRvIHdyaXRlIGJvb3QgYmxvY2tzIGZvciBhbGwKPiBSb2NrY2hpcCBTb0Nz IGlzIGhvd2V2ZXIgdXNlbGVzcy4gVGhlIHBhdHRlcm4gb2Ygd2hlcmUgdGhlIG5leHQgcGFnZQo+ IGlzIHdyaXR0ZW4gZGVwZW5kcyBvbiB0aGUgY2hpcCBJRC4gQXMgdGhlIE1URCBmcmFtZXdvcmsg ZG9lc24ndCBwYXNzCj4gdGhpcyBjaGlwIElEIGluIGl0J3MgZGF0YSBzdHJ1Y3R1cmVzLCB3ZSBt dXN0IGNhbGN1bGF0ZSB0aGF0IGluCj4gdXNlcnNwYWNlLgoKeWVzLCBJIGFncmVlIHRoZSByaWdo dCBhcHByb2FjaCBpZiB5b3UgbmVlZCB0byB3cml0ZSB0aGVzZSBpcyB0bwpwZXJmb3JtIHJhdyBP T0Igd3JpdGVzIHdpdGggdmFsdWVzIGNhbGN1bGF0ZWQgbWFudWFsbHkuCgo+IFRoZXJlZm9yZSBi b3RoIFJBVyBhbmQgSFcgbW9kZSBtdXN0IHBhc3MgdGhlIFBBIGJ5dGVzLgoKWWVzLCBubyBwcm9i bGVtIHdpdGggdGhhdC4KCj4gPT09Cj4gCj4gVGhlIE5GQyBoYXJkd2FyZSBpcyBjYXBhYmxlIGZv ciBhIDE2IGJpdCBidXMsIGJ1dCBub3QgaW1wbGVtZW50ZWQgeWV0Lgo+IFJlc2VydmVkIGFyZSBz dGFuZGFyZCAyIGJpdHMgZm9yIHRoZSBCQk0gZm9yIGEgY29uc2lzdGFudGVuY3kgYnkgdGhlCj4g b3JpZ2luYWwgYXV0aG9yLgo+IAo+ID09PQo+IAo+IGNoaXAtPm9vYl9wb2kgYnVmZmVyIGxheW91 dCBmb3IgOCBzdGVwczoKPiAKPiBCQk0wICAgQkJNMSAgT09CMiAgT09CMyAgfCBPT0I0ICBPT0I1 ICBPT0I2ICBPT0I3Cj4gCj4gT09COCAgIE9PQjkgIE9PQjEwIE9PQjExIHwgT09CMTIgT09CMTMg T09CMTUgT09CMTUKPiBPT0IxNiAgT09CMTcgT09CMTggT09CMTkgfCBPT0IyMCBPT0IyMSBPT0Iy MiBPT0IyMwo+IAo+IE9PQjI0ICBPT0IyNSBPT0IyNiBPT0IyNyB8IFBBMCAgIFBBMSAgIFBBMiAg IFBBMwo+IAo+IEVDQzAgICBFQ0MxICBFQ0MyICBFQ0MzICB8IC4uLiAgIC4uLiAgIC4uLiAgIC4u LgoKWWVzLgoKPiAKPiA9PT0KPiAKPiBya19uZmNfb29ibGF5b3V0X2ZyZWU6Cj4gb29iX3JlZ2lv bi0+bGVuZ3RoID0gcmtuYW5kLT5tZXRhZGF0YV9zaXplIC0gTkZDX1NZU19EQVRBX1NJWkUgLSAy Owo+ICAgICAgICAgICAgICAgICAgICA9IDMyIC0gNCAtIDIKPiAgICAgICAgICAgICAgICAgICAg PSAyNgo+IAo+IG9vYl9yZWdpb24tPm9mZnNldCA9IDI7Cj4gCj4gRnJlZSBPT0Igc2hvdWxkIHN0 YXJ0IGF0IE9PQjIgdG8gbm90IG92ZXJ3cml0ZSBQQSBkYXRhLgoKWWVzLgoKPiAKPiA9PT0KPiAK PiBya19uZmNfb29ibGF5b3V0X2VjYzoKPiAJb29iX3JlZ2lvbi0+bGVuZ3RoID0gbXRkLT5vb2Jz aXplIC0gcmtuYW5kLT5tZXRhZGF0YV9zaXplOwo+IAkgICAgICAgICAgICAgICAgICAgPSA2NDAg LSAzMgo+IAkgICAgICAgICAgICAgICAgICAgPSA2MDgKPiAJb29iX3JlZ2lvbi0+b2Zmc2V0ID0g cmtuYW5kLT5tZXRhZGF0YV9zaXplOwo+IAkgICAgICAgICAgICAgICAgICAgPSAzMgo+IAo+IEVD QyBkYXRhIHN0YXJ0cyBhdCBvZmZzZXQgMzIuCgpZZXMuCgo+IAo+ID09PQo+IAo+IAo+ID4gICAK PiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IEpvaGFuIEpvbmtlciA8amJ4NjI0NEBnbWFpbC5jb20+ Cj4gPj4gLS0tCj4gPj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3JvY2tjaGlwLW5hbmQtY29udHJv bGxlci5jIHwgMTEgKysrKy0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9yb2NrY2hpcC1uYW5kLWNvbnRyb2xsZXIuYwo+ID4+IGIvZHJpdmVycy9tdGQvbmFu ZC9yYXcvcm9ja2NoaXAtbmFuZC1jb250cm9sbGVyLmMgaW5kZXgKPiA+PiAzMWQ4YzdhODcuLmZj ZGE0Yzc2MCAxMDA2NDQgLS0tCj4gPj4gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9yb2NrY2hpcC1u YW5kLWNvbnRyb2xsZXIuYyArKysKPiA+PiBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3JvY2tjaGlw LW5hbmQtY29udHJvbGxlci5jIEBAIC01NjYsOQo+ID4+ICs1NjYsMTAgQEAgc3RhdGljIGludCBy a19uZmNfd3JpdGVfcGFnZV9yYXcoc3RydWN0IG5hbmRfY2hpcAo+ID4+ICpjaGlwLCBjb25zdCB1 OCAqYnVmLAo+ID4+ICAJCSAqICAgIEJCTSAgT09CMSBPT0IyIE9PQjMgfC4uLi4uLnwgIFBBMCAg UEExICBQQTIKPiA+PiAgUEEzICoKPiA+PiAgCQkgKiBUaGUgcmtfbmZjX29vYmxheW91dF9mcmVl KCkgZnVuY3Rpb24gYWxyZWFkeQo+ID4+IGhhcyByZXNlcnZlZAo+ID4+IC0JCSAqIHRoZXNlIDQg Ynl0ZXMgd2l0aDoKPiA+PiArCQkgKiB0aGVzZSA0IGJ5dGVzIHRvZ2V0aGVyIHdpdGggMiBieXRl cyBmb3IgQkJNCj4gPj4gKwkJICogYnkgcmVkdWNpbmcgaXQncyBsZW5ndGg6Cj4gPj4gIAkJICoK PiA+PiAtCQkgKiBvb2JfcmVnaW9uLT5vZmZzZXQgPSBORkNfU1lTX0RBVEFfU0laRSArIDI7Cj4g Pj4gKwkJICogb29iX3JlZ2lvbi0+bGVuZ3RoID0gcmtuYW5kLT5tZXRhZGF0YV9zaXplIC0KPiA+ PiBORkNfU1lTX0RBVEFfU0laRSAtIDI7ICovCj4gPj4gIAkJaWYgKCFpKQo+ID4+ICAJCQltZW1j cHkocmtfbmZjX29vYl9wdHIoY2hpcCwgaSksCj4gPj4gQEAgLTk0NSwxMiArOTQ2LDggQEAgc3Rh dGljIGludCBya19uZmNfb29ibGF5b3V0X2ZyZWUoc3RydWN0Cj4gPj4gbXRkX2luZm8gKm10ZCwg aW50IHNlY3Rpb24sIGlmIChzZWN0aW9uKQo+ID4+ICAJCXJldHVybiAtRVJBTkdFOwo+ID4+Cj4g Pj4gLQkvKgo+ID4+IC0JICogVGhlIGJlZ2lubmluZyBvZiB0aGUgT09CIGFyZWEgc3RvcmVzIHRo ZSByZXNlcnZlZCBkYXRhCj4gPj4gZm9yIHRoZSBORkMsCj4gPj4gLQkgKiB0aGUgc2l6ZSBvZiB0 aGUgcmVzZXJ2ZWQgZGF0YSBpcyBORkNfU1lTX0RBVEFfU0laRQo+ID4+IGJ5dGVzLgo+ID4+IC0J ICovCj4gPj4gIAlvb2JfcmVnaW9uLT5sZW5ndGggPSBya25hbmQtPm1ldGFkYXRhX3NpemUgLQo+ ID4+IE5GQ19TWVNfREFUQV9TSVpFIC0gMjsKPiA+PiAtCW9vYl9yZWdpb24tPm9mZnNldCA9IE5G Q19TWVNfREFUQV9TSVpFICsgMjsKPiA+PiArCW9vYl9yZWdpb24tPm9mZnNldCA9IDI7Cj4gPj4K PiA+PiAgCXJldHVybiAwOwo+ID4+ICB9Cj4gPj4gLS0KPiA+PiAyLjMwLjIKPiA+PiAgCj4gPiAK PiA+IAo+ID4gVGhhbmtzLAo+ID4gTWlxdcOobCAgCgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B95EB64D9 for ; Wed, 14 Jun 2023 16:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245289AbjFNQBt (ORCPT ); Wed, 14 Jun 2023 12:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245118AbjFNQBo (ORCPT ); Wed, 14 Jun 2023 12:01:44 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 073C8295B for ; Wed, 14 Jun 2023 09:01:21 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1686758470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qOV8LTn0vFlBeWdljLVATJ2Xq6J3HagcK9Y6oImy8+I=; b=fRGb2XnKJ8tgpUp/9ld7byMjVBjI+NtTqmuPLCJQswKll3RH+qfto8GuosQiirtT9+NZnS HF+mc5EJGkvXfdHHjlKJ8ZuZnEtq5zK/sgepxyCDk12T4bhqrAZQGtKSi5qE/SEmCJkn82 vQ0e7s8aN9BLy3BMzSx79JEqpFVwFDxT94IZk7b/K7ZaAilMKpcHGGfLvEbqvAe8JLVf2R DW9Rgvf76DtSFQfStU8xfDwSg122Orq2k67dvdqEf89xf/UVICkA8wQOnzsN+8stD11FEz KVzgEbOSrFTejmgPrjkMyob9lZRTD77L3J3qFTQgxAxja/cH71wSruox1JRCtg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B83E20004; Wed, 14 Jun 2023 16:01:09 +0000 (UTC) Date: Wed, 14 Jun 2023 18:01:08 +0200 From: Miquel Raynal To: Johan Jonker Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com Subject: Re: [PATCH v2 3/5] mtd: nand: raw: rockchip-nand-controller: fix oobfree offset and description Message-ID: <20230614180108.5b202077@xps-13> In-Reply-To: <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> References: <11e16c3b-6f7b-a6a9-b0ed-b7ac0cd703e3@gmail.com> <20230612192640.63baf3e8@xps-13> <8457ff3d-f033-8d06-42ca-d95f77ec8145@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johan, jbx6244@gmail.com wrote on Wed, 14 Jun 2023 11:23:44 +0200: > On 6/12/23 19:26, Miquel Raynal wrote: > > Hi Johan, > >=20 > > jbx6244@gmail.com wrote on Mon, 12 Jun 2023 17:03:18 +0200: > > =20 > >> The MTD framework reserves 1 or 2 bytes for the bad block marker > >> depending on the bus size. The rockchip-nand-controller driver > >> currently only supports a 8 bit bus, but reserves standard 2 bytes > >> for the BBM. =20 > >=20 > > We always reserve 2 bytes, no? =20 >=20 > Not always used, but for consistency/simplicity the author assumes/reserv= es 2 bytes.=20 It's kind of an implicit rule in the raw NAND subsystem. It's not an author choice. > >> The first free OOB byte is therefore OOB2 at offset 2. > >> Page address(PA) bytes are moved to the last 4 positions before > >> ECC. Update the description for Linux. =20 > >=20 > > The description should just be: > > =20 >=20 > > Move Page Address (PA) bytes to the last 4 positions before ECC. =20 >=20 > Space is already reserved, but overwritten. Well, I don't know, but I'm quoting your commit log "Page address(PA) bytes are moved to the last 4 positions before ECC" and if this sentence is right, I am proposing another way to say this which sounds more declarative. >=20 > >=20 > > And then you should justify why this is needed. Also, this would > > break all existing jffs2 users, right? =20 >=20 > Hi Miquel, >=20 > From your comments it seems that the chip->oob_poi buffer layout is > still not clear to you. Hope that this text below helps. > If existing jffs2 users of free OOB are writing They are, it's the first thing that jjfs2 does: writing cleanmarkers in the free area. > they are corrupting > our PA data in RAW mode. So that must be fixed.=20 I did not yet understand whether corrupting the PA data was an absolute mistake or if it was specific to a given range of ROM codes. But let's assume it must be fixed. > Please advise how we > split pre and post change users. If you change the layout, you break users. There is no question here. But if you do that, we need: - a crystal clear explanation of why this is needed - to say it clearly: this change breaks existing jffs2 users > (With a Module parameter like > skipbbt renamed to "user_mode" =3D 0 offset 6, "user_mode" =3D 1 offset I know the cafe driver does that, it is awful IMHO. > 2) Copying PA data in both RAW and HW mode has already reserved space > in the layout. Let me know if I can help to get forward here. >=20 > Johan >=20 > =3D=3D=3D >=20 > Given: >=20 > Rockchip rk3066 MK808 with NAND: > nand: Hynix H27UCG8T2ATR-BC 64G 3.3V 8-bit > nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: > 640 >=20 > =3D=3D=3D >=20 > Calulations: >=20 > #define NFC_SYS_DATA_SIZE (4) /* 4 bytes sys data in > oob pre 1024 data.*/ >=20 > So per step only 4 bytes of OOB can be read. I think I get what you mean but the above sentence is wrong. You can always read the full OOB in raw mode. And in general you can as well in host ECC mode. Then what users do with the OOB information is orthogonal. However, if they don't want their data to be smashed, they can request the information about which bytes are free to be used (typically what jffs2 does, while ubi does not care about OOB). The oob layout helpers can then restrain the advertised free area to only share bytes which are not used by the PA. >=20 > =3D=3D=3D >=20 > The NFC can read/write in 1024 data bytes per step. > To read/write a full page it needs 8 steps. >=20 > chip->ecc.size =3D 1024; > chip->ecc.steps =3D mtd->writesize / chip->ecc.size; > =3D 8192 / 1024 > =3D 8 steps > =3D=3D=3D >=20 > The total size of usefull OOB before ECC: >=20 > rknand->metadata_size =3D NFC_SYS_DATA_SIZE * ecc->steps; > =3D 4 * 8 > =3D 32 > =3D=3D=3D >=20 > Wrong free OOB offset starts at OOB6: > oob_region->offset =3D NFC_SYS_DATA_SIZE + 2; > =3D 4 + 2 > =3D 6 >=20 > With a free OOB offset of 6 and a length of 26 =3D=3D> 6 + 26 =3D 32 we > corrupt the PA address starting at offset 28. >=20 > New offset OOB2: > oob_region->offset =3D 2; >=20 > The full range of free runs from OOB2 till/including OOB27. > =3D=3D=3D >=20 > The last 4 bytes of metadata are reserved for this Page Address(PA) > for the bootrom. Currently only in use in RAW mode. I'm not sure to understand what "currently on ly in use in raw mode". In raw mode, the user can overwrite the whole OOB area, it is the user input what should be written in each and every byte. In ECC mode the ECC engine will smash some of this data to write its own ECC bytes. > The current PA calculation needed to write boot blocks for all > Rockchip SoCs is however useless. The pattern of where the next page > is written depends on the chip ID. As the MTD framework doesn't pass > this chip ID in it's data structures, we must calculate that in > userspace. yes, I agree the right approach if you need to write these is to perform raw OOB writes with values calculated manually. > Therefore both RAW and HW mode must pass the PA bytes. Yes, no problem with that. > =3D=3D=3D >=20 > The NFC hardware is capable for a 16 bit bus, but not implemented yet. > Reserved are standard 2 bits for the BBM for a consistantency by the > original author. >=20 > =3D=3D=3D >=20 > chip->oob_poi buffer layout for 8 steps: >=20 > BBM0 BBM1 OOB2 OOB3 | OOB4 OOB5 OOB6 OOB7 >=20 > OOB8 OOB9 OOB10 OOB11 | OOB12 OOB13 OOB15 OOB15 > OOB16 OOB17 OOB18 OOB19 | OOB20 OOB21 OOB22 OOB23 >=20 > OOB24 OOB25 OOB26 OOB27 | PA0 PA1 PA2 PA3 >=20 > ECC0 ECC1 ECC2 ECC3 | ... ... ... ... Yes. >=20 > =3D=3D=3D >=20 > rk_nfc_ooblayout_free: > oob_region->length =3D rknand->metadata_size - NFC_SYS_DATA_SIZE - 2; > =3D 32 - 4 - 2 > =3D 26 >=20 > oob_region->offset =3D 2; >=20 > Free OOB should start at OOB2 to not overwrite PA data. Yes. >=20 > =3D=3D=3D >=20 > rk_nfc_ooblayout_ecc: > oob_region->length =3D mtd->oobsize - rknand->metadata_size; > =3D 640 - 32 > =3D 608 > oob_region->offset =3D rknand->metadata_size; > =3D 32 >=20 > ECC data starts at offset 32. Yes. >=20 > =3D=3D=3D >=20 >=20 > > =20 > >> > >> Signed-off-by: Johan Jonker > >> --- > >> drivers/mtd/nand/raw/rockchip-nand-controller.c | 11 ++++------- > >> 1 file changed, 4 insertions(+), 7 deletions(-) > >> > >> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c > >> b/drivers/mtd/nand/raw/rockchip-nand-controller.c index > >> 31d8c7a87..fcda4c760 100644 --- > >> a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ > >> b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -566,9 > >> +566,10 @@ static int rk_nfc_write_page_raw(struct nand_chip > >> *chip, const u8 *buf, > >> * BBM OOB1 OOB2 OOB3 |......| PA0 PA1 PA2 > >> PA3 * > >> * The rk_nfc_ooblayout_free() function already > >> has reserved > >> - * these 4 bytes with: > >> + * these 4 bytes together with 2 bytes for BBM > >> + * by reducing it's length: > >> * > >> - * oob_region->offset =3D NFC_SYS_DATA_SIZE + 2; > >> + * oob_region->length =3D rknand->metadata_size - > >> NFC_SYS_DATA_SIZE - 2; */ > >> if (!i) > >> memcpy(rk_nfc_oob_ptr(chip, i), > >> @@ -945,12 +946,8 @@ static int rk_nfc_ooblayout_free(struct > >> mtd_info *mtd, int section, if (section) > >> return -ERANGE; > >> > >> - /* > >> - * The beginning of the OOB area stores the reserved data > >> for the NFC, > >> - * the size of the reserved data is NFC_SYS_DATA_SIZE > >> bytes. > >> - */ > >> oob_region->length =3D rknand->metadata_size - > >> NFC_SYS_DATA_SIZE - 2; > >> - oob_region->offset =3D NFC_SYS_DATA_SIZE + 2; > >> + oob_region->offset =3D 2; > >> > >> return 0; > >> } > >> -- > >> 2.30.2 > >> =20 > >=20 > >=20 > > Thanks, > > Miqu=C3=A8l =20 Thanks, Miqu=C3=A8l