All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jacek Tomasiak <jacek.tomasiak@gmail.com>,
	netfilter-devel@vger.kernel.org,
	Jacek Tomasiak <jtomasiak@arista.com>
Subject: Re: [conntrack-tools PATCH] conntrack: Don't override mark in non-list mode
Date: Thu, 15 Jun 2023 15:45:35 +0200	[thread overview]
Message-ID: <20230615134535.GD13263@breakpoint.cc> (raw)
In-Reply-To: <20230615133643.GC13263@breakpoint.cc>

Florian Westphal <fw@strlen.de> wrote:
> This should be
> 
> -                       tmpl->mark.value = status;
> -                       tmpl->filter_status_kernel.val = tmpl->mark.value;
> +                       tmpl->filter_status_kernel.val = status;
>                         tmpl->filter_status_kernel_set = true;

I've pushed Jaceks patch with the content amended as above.

Jan, please report if that doesn't resolve the bug you reported.

Thanks everyone.

      reply	other threads:[~2023-06-15 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 16:24 [conntrack-tools PATCH] conntrack: Don't override mark in non-list mode Jacek Tomasiak
2023-06-15 11:29 ` Pablo Neira Ayuso
2023-06-15 13:36   ` Florian Westphal
2023-06-15 13:45     ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615134535.GD13263@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=jacek.tomasiak@gmail.com \
    --cc=jtomasiak@arista.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.