From: Lee Jones <lee@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: rsmu: turn rsmu-{core,i2c,spi} into single-object modules
Date: Thu, 15 Jun 2023 15:00:10 +0100 [thread overview]
Message-ID: <20230615140010.GE3635807@google.com> (raw)
In-Reply-To: <20230604042557.900590-2-masahiroy@kernel.org>
On Sun, 04 Jun 2023, Masahiro Yamada wrote:
> With the previous fix, these modules are built from a single C file.
>
> Rename the source files so they match the module names.
Should this be part of the previous patch?
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> drivers/mfd/Makefile | 3 ---
> drivers/mfd/{rsmu_core.c => rsmu-core.c} | 0
> drivers/mfd/{rsmu_i2c.c => rsmu-i2c.c} | 0
> drivers/mfd/{rsmu_spi.c => rsmu-spi.c} | 0
> 4 files changed, 3 deletions(-)
> rename drivers/mfd/{rsmu_core.c => rsmu-core.c} (100%)
> rename drivers/mfd/{rsmu_i2c.c => rsmu-i2c.c} (100%)
> rename drivers/mfd/{rsmu_spi.c => rsmu-spi.c} (100%)
>
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 2a0e80f941a1..0fe213858974 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -271,9 +271,6 @@ obj-$(CONFIG_MFD_INTEL_M10_BMC_PMCI) += intel-m10-bmc-pmci.o
> obj-$(CONFIG_MFD_ATC260X) += atc260x-core.o
> obj-$(CONFIG_MFD_ATC260X_I2C) += atc260x-i2c.o
>
> -rsmu-core-objs := rsmu_core.o
> -rsmu-i2c-objs := rsmu_i2c.o
> -rsmu-spi-objs := rsmu_spi.o
> obj-$(CONFIG_MFD_RSMU_CORE) += rsmu-core.o
> obj-$(CONFIG_MFD_RSMU_I2C) += rsmu-i2c.o
> obj-$(CONFIG_MFD_RSMU_SPI) += rsmu-spi.o
> diff --git a/drivers/mfd/rsmu_core.c b/drivers/mfd/rsmu-core.c
> similarity index 100%
> rename from drivers/mfd/rsmu_core.c
> rename to drivers/mfd/rsmu-core.c
> diff --git a/drivers/mfd/rsmu_i2c.c b/drivers/mfd/rsmu-i2c.c
> similarity index 100%
> rename from drivers/mfd/rsmu_i2c.c
> rename to drivers/mfd/rsmu-i2c.c
> diff --git a/drivers/mfd/rsmu_spi.c b/drivers/mfd/rsmu-spi.c
> similarity index 100%
> rename from drivers/mfd/rsmu_spi.c
> rename to drivers/mfd/rsmu-spi.c
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-15 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 4:25 [PATCH 1/2] mfd: rsmu: fix mixed module-builtin object Masahiro Yamada
2023-06-04 4:25 ` [PATCH 2/2] mfd: rsmu: turn rsmu-{core,i2c,spi} into single-object modules Masahiro Yamada
2023-06-15 14:00 ` Lee Jones [this message]
2023-06-16 5:03 ` Masahiro Yamada
2023-06-19 8:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615140010.GE3635807@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.